提交 · 6130e7a9c34d01afbd4e7e215846d1f2d70333bb · openanolis / cloud-kernel

10 11月, 2014 40 次提交

mmc: dw_mmc: Remove old card detect infrastructure · 6130e7a9

由 Doug Anderson 提交于 10月 14, 2014

The dw_mmc driver had a bunch of code that ran whenever a card was
ejected and inserted.  However, this code was old and crufty and
should be removed.  Some evidence that it's really not needed:

1. Is is supposed to be legal to use 'cd-gpio' on dw_mmc instead of
   using the built-in card detect mechanism.  The 'cd-gpio' code
   doesn't run any of the crufty old code but yet still works.

2. While looking at this, I realized that my old change (369ac861 mmc:
   dw_mmc: don't queue up a card detect at slot startup) actually
   castrated the old code a little bit already and nobody noticed.
   Specifically "last_detect_state" was left as 0 at bootup.  That
   means that on the first card removal none of the crufty code ran.

3. I can run "while true; do dd if=/dev/mmcblk1 of=/dev/null; done"
   while ejecting and inserting an SD Card and the world doesn't
   explode.

If some of the crufty old code is actually needed, we should justify
it and also put it in some place where it will be run even with
"cd-gpio".

Note that in my case I'm using the "cd-gpio" mechanism but for various
reasons the hardware triggers a dw_mmc "card detect" at bootup.  That
was actually causing a real bug.  The card detect workqueue was
running while the system was trying to enumerate the card.  The
"present != slot->last_detect_state" triggered and we were doing all
kinds of crazy stuff and messing up enumeration.  The new mechanism of
just asking the core to check the card is much safer and then the
bogus interrupt doesn't hurt.
Signed-off-by: NDoug Anderson <dianders@chromium.org>
Tested-by: NJaehoon Chung <jh80.chung@samsung.com>
Acked-by: NJaehoon Chung <jh80.chung@samsung.com>
Tested-by: Nalim.akhtar <alim.akhtar@samsung.com>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>

6130e7a9

mmc: core: silence a shift wrapping warning · 51d34606

由 Dan Carpenter 提交于 10月 23, 2014

Presumably ->slotno is normally fairly small and the shift doesn't wrap
but static checkers will complain about it.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>

51d34606

mmc: sdhci-of-arasan: Use signed formatting in error messages · 5d0e1194

由 Mike Looijmans 提交于 10月 23, 2014

"ret" is a signed int, so use "%d" in format strings instead of "%u".
This prevents cryptic codes in error messages like this:
sdhci-arasan e0101000.sdhci: platform register failed (4294966779)
Signed-off-by: NMike Looijmans <mike.looijmans@topic.nl>
Reviewed-by: NMichal Simek <michal.simek@xilinx.com>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>

5d0e1194

avr32: remove mach/atmel-mci.h · 4df10e02

由 Alexandre Belloni 提交于 10月 17, 2014

Use the generic platform_data header file instead of mach/atmel-mci.h
Signed-off-by: NAlexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NLudovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>

4df10e02

ARM: at91: remove mach/atmel-mci.h · 19336880

由 Alexandre Belloni 提交于 10月 17, 2014

Use the generic platform_data header file instead of mach/atmel-mci.h
Signed-off-by: NAlexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NLudovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>

19336880

mmc: atmel-mci: move mach header to platform_data · 9cbef73c

由 Alexandre Belloni 提交于 10月 17, 2014

Move the mach header that can come either from arm/mach-at91 or avr32 to
platform_data to be able to switch the AT91 platforms to multiplatform.
Signed-off-by: NAlexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NLudovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>
[Ulf: Fixed compile error]

9cbef73c

mmc: core: Report firmware version for eMMC 5.0 devices. · 0f762426

由 Gwendal Grignou 提交于 10月 16, 2014

For eMMC 5.0 compliant device, firmware version is stored in ext_csd.
Report firmware as a 64bit hexa decimal. Vendor can use hexa or ascii
string to report firmware version.
Also add FFU related EXT_CSD register and note if the device is FFU capable.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>

0f762426

mmc: dw_mmc: rockchip: Don't recalc the clock when it goes off · e7791079

由 Doug Anderson 提交于 10月 14, 2014

The "set_ios" function is called with a clock of 0 when the clock is
turning off.  There's no reason to go through all the extra Rockchip
logic (whose goal is to make sure DIV is 0 or 1) in that case.  The
Rockchip logic happened to work because the CCF will pick the lowest
possible rate when you ask it for a clock of 0, but it's silly to go
through all the remuxing and adjusting for no reason.
Signed-off-by: NDoug Anderson <dianders@chromium.org>
Acked-by: NJaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>

e7791079

mmc: dw_mmc: Change signal voltage error to dev_dbg() · b19caf37

由 Doug Anderson 提交于 10月 10, 2014

In (28f92b5 mmc: core: Try other signal levels during power up) we can
see that there are times when it's valid to try several signal
voltages.  Don't print an ugly error in the logs when that happens.
Signed-off-by: NDoug Anderson <dianders@chromium.org>
Reviewed-by: NAlim Akhtar <alim.akhtar@samsung.com>
Acked-by: NJaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>

b19caf37

mmc: dw_mmc: Reset DMA before enabling IDMAC · 536f6b91

由 Sonny Rao 提交于 10月 16, 2014

We've already got a reset of DMA after it's done.  Add one before we
start DMA too.  This fixes a data corruption on Rockchip SoCs which
will get bad data when doing a DMA transfer after doing a PIO transfer.

We tested this on an Exynos 5800 with HS200 and didn't notice any
difference in sequential read throughput.
Signed-off-by: NSonny Rao <sonnyrao@chromium.org>
Signed-off-by: NDoug Anderson <dianders@chromium.org>
Tested-by: NDoug Anderson <dianders@chromium.org>
Acked-by: NJaehoon Chung <jh80.chung@samsung.com>
Tested-by: NJaehoon Chung <jh80.chung@samsung.com>
Reviewed-by: NAlim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>

536f6b91

U
mmc: core: Remove unused mmc_list_to_card() macro · 390e316c
由 Ulf Hansson 提交于 10月 06, 2014
```
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>
```
390e316c

mmc: block: Use dev_set|get_drvdata() · fc95e30b