1. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  2. 05 3月, 2010 2 次提交
    • D
      ALSA: usb-audio: refactor code · e5779998
      Daniel Mack 提交于
      Clean up the usb audio driver by factoring out a lot of functions to
      separate files. Code for procfs, quirks, urbs, format parsers etc all
      got a new home now.
      
      Moved almost all special quirk handling to quirks.c and introduced new
      generic functions to handle them, so the exceptions do not pollute the
      whole driver.
      
      Renamed usbaudio.c to card.c because this is what it actually does now.
      Renamed usbmidi.c to midi.c for namespace clarity.
      Removed more things from usbaudio.h.
      
      The non-standard drivers were adopted accordingly.
      Signed-off-by: NDaniel Mack <daniel@caiaq.de>
      Cc: Clemens Ladisch <clemens@ladisch.de>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      e5779998
    • D
      ALSA: usb-audio: header file cleanups · 3e1aebef
      Daniel Mack 提交于
      Rename snd-usb-lib to snd-usbmidi-lib as MIDI functions are the only
      thing it actually contains. Introduce a new header file to only declare
      these functions.
      
      Introduced usbmixer.h for all functions exported by usbmixer.c.
      Signed-off-by: NDaniel Mack <daniel@caiaq.de>
      Cc: Clemens Ladisch <clemens@ladisch.de>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      3e1aebef
  3. 23 2月, 2010 1 次提交
  4. 08 12月, 2009 1 次提交
  5. 24 11月, 2009 2 次提交
  6. 13 10月, 2009 1 次提交
  7. 28 9月, 2009 1 次提交
  8. 22 9月, 2009 1 次提交
  9. 02 7月, 2009 1 次提交
  10. 20 4月, 2009 1 次提交
    • K
      ALSA: us122l: add snd_us122l_free() · 5d4af1be
      Karsten Wiese 提交于
      Use it to clean up snd_us122l_card_used[].
      
      Without patch unplugging of an US122L soundcard didn't reset the
      corresponding element of snd_us122l_card_used[] to 0.
      The (SNDRV_CARDS + 1)th plugging in did not result in creating the soundcard
      device anymore.
      Index values supplied with the modprobe command line were not used correctly
      anymore after the first unplugging of an US122L.
      Signed-off-by: NKarsten Wiese <fzu@wemgehoertderstaat.de>
      Cc: stable@kernel.org
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      5d4af1be
  11. 14 4月, 2009 1 次提交
  12. 12 1月, 2009 2 次提交
  13. 02 1月, 2009 1 次提交
    • J
      ALSA: Use usb_set/get_intfdata · f4e9749f
      Julia Lawall 提交于
      Use the USB functions usb_get_intfdata and usb_set_intfdata instead of
      dev_get_drvdata and dev_set_drvdata, respectively.
      
      The semantic patch that makes this change for the usb_get_intfdata case is
      as follows: (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @header@
      @@
      
      #include <linux/usb.h>
      
      @same depends on header@
      position p;
      @@
      
      usb_get_intfdata@p(...) { ... }
      
      @depends on header@
      position _p!=same.p;
      identifier _f;
      struct usb_interface*intf;
      @@
      
      _f@_p(...) { <+...
      - dev_get_drvdata(&intf->dev)
      + usb_get_intfdata(intf)
      ...+> }
      // </smpl>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      f4e9749f
  14. 15 10月, 2008 1 次提交
  15. 01 8月, 2008 1 次提交