1. 04 12月, 2015 1 次提交
  2. 10 8月, 2015 1 次提交
    • A
      crypto: talitos - Prevent panic in probe error path · 35a3bb3d
      Aaron Sierra 提交于
      The probe error path for this driver, for all intents and purposes,
      is the talitos_remove() function due to the common "goto err_out".
      
      Without this patch applied, talitos_remove() will panic under these
      two conditions:
      
      1. If the RNG device hasn't been registered via
         talitos_register_rng() prior to entry into talitos_remove(),
         then the attempt to unregister the RNG "device" will cause a panic.
      
      2. If the priv->chan array has not been allocated prior to entry
         into talitos_remove(), then the per-channel FIFO cleanup will panic
         because of the dereference of that NULL "array".
      
      Both of the above scenarios occur if talitos_probe_irq() fails.
      
      This patch resolves issue #1 by introducing a boolean to mask the
      hwrng_unregister() call in talitos_unregister_rng() if RNG device
      registration was unsuccessful.
      
      It resolves issue #2 by checking that priv->chan is not NULL in the
      per-channel FIFO cleanup for loop.
      Signed-off-by: NAaron Sierra <asierra@xes-inc.com>
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      35a3bb3d
  3. 04 8月, 2015 1 次提交
    • A
      crypto: talitos - Remove zero_entry static initializer · 76bea64c
      Aaron Sierra 提交于
      Compiling the talitos driver with my GCC 4.3.1 e500v2 cross-compiler
      resulted in a failed build due to the anonymous union/structures
      introduced in this commit:
      
        crypto: talitos - enhanced talitos_desc struct for SEC1
      
      The build error was:
      
        drivers/crypto/talitos.h:56: error: unknown field 'len' specified in initializer
        drivers/crypto/talitos.h:56: warning: missing braces around initializer
        drivers/crypto/talitos.h:56: warning: (near initialization for 'zero_entry.<anonymous>')
        drivers/crypto/talitos.h:57: error: unknown field 'j_extent' specified in initializer
        drivers/crypto/talitos.h:58: error: unknown field 'eptr' specified in initializer
        drivers/crypto/talitos.h:58: warning: excess elements in struct initializer
        drivers/crypto/talitos.h:58: warning: (near initialization for 'zero_entry')
        make[2]: *** [drivers/crypto/talitos.o] Error 1
        make[1]: *** [drivers/crypto] Error 2
        make: *** [drivers] Error 2
      
      This patch eliminates the errors by relying on the C standard's
      implicit assignment of zero to static variables.
      Signed-off-by: NAaron Sierra <asierra@xes-inc.com>
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      76bea64c
  4. 21 4月, 2015 6 次提交
  5. 11 7月, 2012 3 次提交
  6. 21 11月, 2011 2 次提交
  7. 19 5月, 2010 2 次提交
  8. 13 8月, 2009 1 次提交
  9. 25 12月, 2008 3 次提交
  10. 10 7月, 2008 2 次提交