Move the ioctl and enum fe_status to a separate xml file and
put it into a better format.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Keeping everything altogether makes harder to reorganize the
DocBook. So, move the FE_GET_INFO ioctl and the associated structures
into a separate file.

No functional changes.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

The DVB part of the docbook has a completely different format
than the V4L2 part, as it was written as a separate document.

As the V4L2 documentation is on better shape, and its format
allows adding more information, let's use it for FE_GET_INFO
and gradually update the non-legacy DVB ioctls using the new
format.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Using typedefs is already bad enough, but doing it together
with enum declaration is even worse.

Also, it breaks the scripts at DocBook that would be generating
reference pointers for the enums.

Well, we can't get rid of typedef right now, but let's at least
declare it on a separate line, and let the scripts to generate
the cross-reference, as this is needed for the next DocBook
patches.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Although the recommended usage is the DVBv5 API calls, the
documentation doesn't make it clear about what's the recommended
calls and what's legacy.

So, move the legacy API bits to a separate xml, putting them into
a new section.

Please notice that more changes are needed, since some of the
bits there are cross-referenced elsewhere.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

The DVB frontend API got bitrotten. Update it.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Currently, it is using 'role="tt"', but this is not defined at
the DocBook 4.5 spec. The net result is that no emphasis happens.

So, replace them to bold emphasis.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

An illustration of what's considered a typical media device
may help people to better understand the contents of the media
infrastructure API docbook. So, add it.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

The Docbook mistakenly makes to believe that all needed APIs for
media devices are there. Add a note there pointing that some
sub-devices are actually be controlled via ALSA API.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

The list of standards at the media docbook is incomplete, and it
is mentioning that the DVB-S2 & friends is "currently being updated".
That's wrong, as such update occurred back in 2008.

So, provide a more complete list of supported standards and add
a reference to the actual list.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

The ucblocks register is probably a counter and not a rate; assume
it is so and change the calculations as required.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Frontend bandwidth calculation overflows on very high DVB-S/S2
symbol rates. Use mult_frac() macro in order to keep calculation
correct.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

As reported by smatch:

drivers/media/tuners/e4000.c:287:32: warning: constant 2208000000 is so big it is long long
drivers/media/tuners/e4000.c:287:32: warning: decimal constant 2208000000 is between LONG_MAX and ULONG_MAX. For C99 that means long long, C90 compilers are very likely to produce unsigned long (and a warning) here
drivers/media/tuners/e4000.c:287:3: warning: this decimal constant is unsigned only in ISO C90
   .rangehigh  =  2208000000,
   ^

Cc: Antti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Implement V4L2 subdevice tuner and core ops. After that this driver
is hybrid driver implementing both V4L2 and DVB ops.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

* Rename device state from 's' to 'dev'.
* Move single include to driver private header.
* Change error handling type of each function to one I tend use
nowadays.
* Remove dummy register write from init. Even Windows driver does this
multiple times remove it as I have never seen any I2C errors.
* Define I2C client pointer for each function and use it.
* Do not clean tuner ops during driver remove - not needed.
* Disable sysfs device bind / unbind. We are not allowed manually
bind / unbind device from the driver currently.
* Rename some other variables.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Update synthesizer calculation to model I prefer nowadays. It is
mostly just renaming some variables to ones I think are most standard.
Also add 'schematic' of synthesizer following my current understanding.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

This code works fine but static checkers complain.  The test_bit()
function takes the bit number and not a mask.  Then the other issue is
that we were using USB_STATE_URB_BUF which is BIT(0) instead of URB_BUF.
Also we were open coding that instead of using the test/clear/set_bit()
functions.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

The cobalt device is a PCIe card with 4 HDMI inputs (adv7604) and a
connector that can be used to hook up an adv7511 transmitter or an
adv7842 receiver daughterboard.

This device is used within Cisco but is sadly not available outside
of Cisco. Nevertheless it is a very interesting driver that can serve
as an example of how to support HDMI hardware and how to use the popular
adv devices.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

This makes it easier for the bridge driver to just passthrough such
events to the corresponding device node.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

All drivers use custom notifications, in particular when source changes.
The bridge only has to map the subdev that sends it to whatever video node it is connected to.
Signed-off-by: NJean-Michel Hautbois <jean-michel.hautbois@vodalys.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

vb2_buffer_done() already allows STATE_QUEUED, but currently only when not
streaming. It is useful to allow it while streaming as well, as this makes
it possible for drivers to requeue buffers while waiting for a stable
video signal.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Replace the dummy video format operations by pad format operations that
configure the output format.

Copied from the adv7604 driver.

Note: while arch/blackfin/mach-bf609/boards/ezkit.c uses adv7842_platform_data
this source has not been updated because it is broken since the very
beginning. It depends on a struct adv7842_output_format that does not
exist.

And besides that gcc has no support for bf609 so nobody can compile it
except by installing a toolchain from ADI.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Cc: Scott Jiang <scott.jiang.linux@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Remove multiple blank likes.
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

These state vars are used for more than just ber calculation, also
fix typo.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

BER & UCB aren't available unless we're locked; don't update dvbv5
stats when not locked and mark these counters as unavailable.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

DVBv3 is a legacy API. Drivers should use DVBv5, in order to support
modern applications. So, implement UCB using dvbv5.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Instead of reading BER again for DVBv3 call, use the value from the cache.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

DVBv3 is a legacy API. Drivers should use DVBv5, in order to support
modern applications. So, implement BER using dvbv5.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Use const on the static data, as gcc may optimize better the
code. Also, would prevent that some code would override the
data there.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>

drivers/media/dvb-frontends/cx24120.c:1182:5: warning: no previous prototype for 'cx24120_init' [-Wmissing-prototypes]
 int cx24120_init(struct dvb_frontend *fe)
     ^
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>

As reported by smatch:
drivers/media/dvb-frontends/cx24120.c: In function 'cx24120_message_send':
drivers/media/dvb-frontends/cx24120.c:368:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
  int ret, ficus;
      ^

The values written by cx24120 are never checked. So, remove the
check here too. That's said, the best would be to do the reverse,
but globally: to properly handle the error codes.
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>

Add in all the likely values for setting fec on tuning. Some values
yet to be tested but very likely to be correct.
In the very unlikely event that these are wrong tuning with
FEC_AUTO will still work.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

If set, all the other drivers reset no_base_addr on failure to
attach - git commit for this being added to some of them seems to
be eccd15aa

This driver has been floating around outside the mainline for so
long it hasn't had this fix, so add it in.

Whilst here tidy surrounding code to fix style issues.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Remove reg1 by refactoring for loops
Change ret into an int as it's only used for return values now,
and remove reset_result by using ret instead.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Use reg instead of ret for all calls to readreg, remove ret_EA
as it doesn't need to be a separate var anymore.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Probably a remnant of this driver being reverse engineered,
cx24120_init assigned ret on each call to writereg - they're not
used for anything so remove them to clear up the codebase.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Remove __func__ from calls to dev_dbg as dynamic debug can add in
the function name anyway.
Remove debug call in dvbv3 read_signal_strength as userspace has
this value anyway.
Reword some strings to make them simpler / more obvious.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Better to report CNR via DVBv5 stats, as scale can be used.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Previous version of this driver had a memset before every call
to cmd. This meant the default value of cmd.arg[1] was zero unless
burst is set. Make sure it remains zero.
Also fe_sec_mini_cmd_t is an enum, so test against it.
Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>

Signed-off-by: NJemma Denson <jdenson@gmail.com>
Signed-off-by: NPatrick Boettcher <patrick.boettcher@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>