1. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  2. 15 2月, 2010 1 次提交
  3. 24 12月, 2009 1 次提交
  4. 13 7月, 2009 3 次提交
  5. 16 6月, 2009 3 次提交
  6. 25 3月, 2009 1 次提交
  7. 28 2月, 2009 1 次提交
    • D
      usb: musb: make Davinci *work* in mainline · 34f32c97
      David Brownell 提交于
      Now that the musb build fixes for DaVinci got merged (RC3?), kick in
      the other bits needed to get it finally *working* in mainline:
      
       - Use clk_enable()/clk_disable() ... the "always enable USB clocks"
         code this originally relied on has since been removed.
      
       - Initialize the USB device only after the relevant I2C GPIOs are
         available, so the host side can properly enable VBUS.
      
       - Tweak init sequencing to cope with mainline's relatively late init
         of the I2C system bus for power switches, transceivers, and so on.
      
      Sanity tested on DM6664 EVM for host and peripheral modes; that system
      won't boot with CONFIG_PM enabled, so OTG can't yet be tested.  Also
      verified on OMAP3.
      
      (Unrelated:  correct the MODULE_PARM_DESC spelling of musb_debug.)
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Cc: Felipe Balbi <me@felipebalbi.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      34f32c97
  8. 28 1月, 2009 1 次提交
    • D
      USB: musb davinci buildfix · 10b4eade
      David Brownell 提交于
      Trying once more to get this merged.  The original was submitted
      for 2.6.27-rc2 or so, and never got correctly merged.  Neither
      were any of the numerous subsequent resends.  Sigh.
      
        CC      drivers/usb/musb/davinci.o
      drivers/usb/musb/davinci.c:35:32: error: mach/arch/hardware.h: No such file or directory
      drivers/usb/musb/davinci.c:36:30: error: mach/arch/memory.h: No such file or directory
      drivers/usb/musb/davinci.c:37:28: error: mach/arch/gpio.h: No such file or directory
      drivers/usb/musb/davinci.c:373: error: redefinition of 'musb_platform_set_mode'
      drivers/usb/musb/davinci.c:368: error: previous definition of 'musb_platform_set_mode' was here
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Acked-by: NFelipe Balbi <felipe.balbi@nokia.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      10b4eade
  9. 08 1月, 2009 2 次提交
  10. 18 10月, 2008 1 次提交
    • D
      usb: musb_hdrc build fixes · c767c1c6
      David Brownell 提交于
      Minor musb_hdrc updates:
      
        - so it'll build on DaVinci, given relevant platform updates;
            * remove support for an un-shipped OTG prototype
            * rely on gpiolib framework conversion for the I2C GPIOs
            * the <asm/arch/hdrc_cnf.h> mechanism has been removed
      
        - catch comments up to the recent removal of the per-SOC header
          with the silicon configuration data;
      
        - and remove two inappropriate "inline" declarations which
          just bloat host side code.
      
      There are still some more <asm/arch/XYZ.h> ==> <mach/XYZ.h>
      changes needed in this driver, catching up to the relocation
      of most of the include/asm-arm/arch-* contents.
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NFelipe Balbi <felipe.balbi@nokia.com>
      Cc: stable <stable@kernel.org> [2.6.27]
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      c767c1c6
  11. 14 8月, 2008 1 次提交