1. 20 8月, 2009 1 次提交
    • J
      HID: support larger reports than 64 bytes in hiddev · affbb8c6
      Jiri Kosina 提交于
      hiddev userspace driver uses a rignbuffer to store the parsed usages
      that should be returned through read(). This buffer is 64 bytes long,
      which is sufficient for queueing single USB 1.0 low-speed report, which
      is of maximum size 48 bytes.
      
      There are however USB HID devices which are full-speed USB devices, and
      therefore they are free to produce reports 64 bytes long. This is correctly
      handled by HID core, but read() on hiddev node gets stuck forever, because
      the ring buffer loops infinitely (as it is exactly 64 bytes long as well),
      never advancing the buffer pointer.
      
      Plus, the core driver is ready to handle highspeed devices, so we should be
      able to handle reports from such devices in the hiddev driver as well, which
      means we need larger ringbuffer.
      Reported-by: NMichael Zeisel <michael.zeisel@philips.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      affbb8c6
  2. 22 6月, 2009 1 次提交
  3. 16 6月, 2009 1 次提交
  4. 30 3月, 2009 1 次提交
    • O
      HID: fix race between usb_register_dev() and hiddev_open() · e43bd67d
      Oliver Neukum 提交于
      upon further thought this code is still racy.
      
      	retval = usb_register_dev(usbhid->intf, &hiddev_class);
      
      here you open a window during which open can happen
      
      	if (retval) {
      		err_hid("Not able to get a minor for this device.");
      		hid->hiddev = NULL;
      		kfree(hiddev);
      		return -1;
      	} else {
      		hid->minor = usbhid->intf->minor;
      		hiddev_table[usbhid->intf->minor - HIDDEV_MINOR_BASE] = hiddev;
      
      and will fail because hiddev_table hasn't been updated
      
      The obvious fix of using a mutex to guard hiddev_table doesn't work because
      usb_open() and usb_register_dev() take minor_rwsem and we'd have an AB-BA
      deadlock. We need a lock usb_open() also takes in the right order and that leaves
      only one option, BKL. I don't like it but I see no alternative.
      
      Once the usb_open() implements something better than lock_kernel(), we could also
      do so.
      Signed-off-by: NOliver Neukum <oneukum@suse.de>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      e43bd67d
  5. 26 3月, 2009 1 次提交
    • O
      HID: autosuspend support for USB HID · 0361a28d
      Oliver Neukum 提交于
      This uses the USB busy mechanism for aggessive autosuspend of USB
      HID devices. It autosuspends all opened devices supporting remote wakeup
      after a timeout unless
      
      - output is being done to the device
      - a key is being held down (remote wakeup isn't triggered upon key release)
      - LED(s) are lit
      - hiddev is opened
      
      As in the current driver closed devices will be autosuspended even if they
      don't support remote wakeup.
      
      The patch is quite large because output to devices is done in hard interrupt
      context meaning a lot a queuing and locking had to be touched. The LED stuff
      has been solved by means of a simple counter. Additions to the generic HID code
      could be avoided. In addition it now covers hidraw. It contains an embryonic
      version of an API to let the generic HID code tell the lower levels which
      capabilities with respect to power management are needed.
      Signed-off-by: NOliver Neukum <oneukum@suse.de>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      0361a28d
  6. 16 3月, 2009 1 次提交
    • J
      Rationalize fasync return values · 60aa4924
      Jonathan Corbet 提交于
      Most fasync implementations do something like:
      
           return fasync_helper(...);
      
      But fasync_helper() will return a positive value at times - a feature used
      in at least one place.  Thus, a number of other drivers do:
      
           err = fasync_helper(...);
           if (err < 0)
                   return err;
           return 0;
      
      In the interests of consistency and more concise code, it makes sense to
      map positive return values onto zero where ->fasync() is called.
      
      Cc: Al Viro <viro@ZenIV.linux.org.uk>
      Signed-off-by: NJonathan Corbet <corbet@lwn.net>
      60aa4924
  7. 11 3月, 2009 2 次提交
    • J
      HID: fix waitqueue usage in hiddev · 96fe2ab8
      Johannes Weiner 提交于
      DECLARE_WAITQUEUE doesn't initialize the wait descriptor's task_list
      to 'empty' but to zero.
      
      prepare_to_wait() will not enqueue the descriptor to the waitqueue and
      finish_wait() will do list_del_init() on a list head that contains
      NULL pointers, which oopses.
      
      This was introduced by 07903407 "HID: hiddev cleanup -- handle all
      error conditions properly".
      
      The prior code used an unconditional add_to_waitqueue() which didn't
      care about the wait descriptor's list head and enqueued the thing
      unconditionally.
      
      The new code uses prepare_to_wait() which DOES check the prior list
      state, so use DEFINE_WAIT instead.
      Signed-off-by: NJohannes Weiner <hannes@cmpxchg.org>
      Cc: Oliver Neukum <oliver@neukum.name>
      Cc: Jiri Kosina <jkosina@suse.cz>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      96fe2ab8
    • J
      HID: fix incorrect free in hiddev · 48e7a3c9
      Johannes Weiner 提交于
      If hiddev_open() fails, it wrongly frees the shared hiddev structure
      kept in hiddev_table instead of the hiddev_list structure allocated
      for the opened file descriptor.  Existing references to this structure
      will then accessed free memory.
      
      This was introduced by 07903407 "HID: hiddev cleanup -- handle all
      error conditions properly".
      Signed-off-by: NJohannes Weiner <hannes@cmpxchg.org>
      Cc: Oliver Neukum <oliver@neukum.name>
      Cc: Jiri Kosina <jkosina@suse.cz>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      48e7a3c9
  8. 29 1月, 2009 1 次提交
  9. 08 1月, 2009 1 次提交
  10. 04 1月, 2009 1 次提交
    • O
      HID: hiddev cleanup -- handle all error conditions properly · 07903407
      Oliver Neukum 提交于
      This is a cleanup of hiddev and fixes the following issues:
      
      - thread safety by locking in read & ioctl, introducing a per device mutex
      - race between ioctl and disconnect, introducing a flag and locking
        in form of a per low level device mutex
      - race between open and other methods, making sure only successfully
        opened devices are put on the list, changing order of events
      - range checking both upper and lower limits of the minor range
      - make sure further calls to open fail for unplugged devices even if
        the device still has opened files
      - error checking for low level open
      - possible loss of wakeup events, using standard waiting macros
      - race in initialisation by moving registration after full initialisation
      Signed-off-by: NOliver Neukum <oneukum@suse.de>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      07903407
  11. 02 11月, 2008 1 次提交
    • A
      saner FASYNC handling on file close · 233e70f4
      Al Viro 提交于
      As it is, all instances of ->release() for files that have ->fasync()
      need to remember to evict file from fasync lists; forgetting that
      creates a hole and we actually have a bunch that *does* forget.
      
      So let's keep our lives simple - let __fput() check FASYNC in
      file->f_flags and call ->fasync() there if it's been set.  And lose that
      crap in ->release() instances - leaving it there is still valid, but we
      don't have to bother anymore.
      Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      233e70f4
  12. 23 10月, 2008 1 次提交
  13. 15 10月, 2008 1 次提交
  14. 23 7月, 2008 3 次提交
  15. 22 4月, 2008 1 次提交
  16. 31 10月, 2007 1 次提交
    • J
      HID: hiddev - fix compiler warning · d624284b
      Jiri Kosina 提交于
      drivers/hid/usbhid/hiddev.c: In function 'hiddev_compat_ioctl':
      drivers/hid/usbhid/hiddev.c:746: warning: passing argument 4 of 'hiddev_ioctl' makes
      integer from pointer without a cast
      
      Add cast to hiddev_compat_ioctl()
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      d624284b
  17. 14 10月, 2007 1 次提交
  18. 09 7月, 2007 1 次提交
    • J
      HID: make debugging output runtime-configurable · 58037eb9
      Jiri Kosina 提交于
      There have been many reports recently about broken HID devices, the
      diagnosis of which required users to recompile their kernels in order
      to be able to provide debugging output needed for coding a quirk for
      a particular device.
      
      This patch makes CONFIG_HID_DEBUG default y if !EMBEDDED and makes it
      possible to control debugging output produced by HID code by supplying
      'debug=1' module parameter.
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      58037eb9
  19. 10 5月, 2007 1 次提交
  20. 11 4月, 2007 1 次提交
  21. 22 1月, 2007 1 次提交
    • A
      HID: put usb_interface instead of usb_device into hid->dev to fix udevinfo breakage · be820975
      Anssi Hannula 提交于
      The commit 4916b3a5 introduced a
      hid regression between 2.6.19 and 2.6.20-rc1. The device put in
      input_dev->cdev is now of type usb_device instead of usb_interface.
      
      Before:
      > # readlink -f /sys/class/input/input6/event4/device
      > /sys/devices/pci0000:00/0000:00:10.0/usb2/2-1/2-1:1.1
      After:
      > # readlink -f /sys/class/input/input3/event3/device
      > /sys/devices/pci0000:00/0000:00:10.0/usb1/1-1
      
      This causes breakage:
      > # udevinfo -q all -n /dev/input/event3
      > P: /class/input/input3/event3
      > N: input/event3
      > S: input/by-path/pci-1-1--event-
      > E: ID_SERIAL=noserial
      > E: ID_PATH=pci-1-1-
      
      No ID_MODEL, ID_VENDOR, ID_REVISION, ID_TYPE etc etc.
      
      Fix this by assigning the intf->dev into hid->dev, and fixing
      all the users.
      Signed-off-by: NAnssi Hannula <anssi.hannula@gmail.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      be820975
  22. 09 12月, 2006 4 次提交
  23. 05 10月, 2006 1 次提交
    • D
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells 提交于
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: NDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  24. 28 9月, 2006 1 次提交
  25. 19 7月, 2006 1 次提交
  26. 01 7月, 2006 1 次提交
  27. 22 5月, 2006 1 次提交
  28. 21 3月, 2006 1 次提交
  29. 01 2月, 2006 1 次提交
  30. 31 1月, 2006 1 次提交
  31. 05 1月, 2006 1 次提交
  32. 29 10月, 2005 1 次提交
    • G
      [PATCH] devfs: Remove the mode field from usb_class_driver as it's no longer needed · d6e5bcf4
      Greg Kroah-Hartman 提交于
      Also fixes all drivers that set this field, and removes some other devfs
      specfic USB logic.
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      
       drivers/usb/class/usblp.c           |    3 +--
       drivers/usb/core/file.c             |   19 ++++---------------
       drivers/usb/image/mdc800.c          |    3 +--
       drivers/usb/input/aiptek.c          |    2 +-
       drivers/usb/input/hiddev.c          |    3 +--
       drivers/usb/media/dabusb.c          |    3 +--
       drivers/usb/misc/auerswald.c        |    3 +--
       drivers/usb/misc/idmouse.c          |    5 ++---
       drivers/usb/misc/legousbtower.c     |    5 ++---
       drivers/usb/misc/rio500.c           |    3 +--
       drivers/usb/misc/sisusbvga/sisusb.c |    5 -----
       drivers/usb/misc/usblcd.c           |    9 ++++-----
       drivers/usb/usb-skeleton.c          |    3 +--
       include/linux/usb.h                 |    7 ++-----
       14 files changed, 22 insertions(+), 51 deletions(-)
      d6e5bcf4
  33. 05 9月, 2005 1 次提交
  34. 29 5月, 2005 1 次提交