In case psataPayload->status has a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
ts->stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a
fallthrough to the default handler of the switch statement overriding ts->stat
to SAS_DEV_NO_RESPONSE.
Signed-off-by: NJohannes Thumshirn <jthumshirn@suse.de>
Acked-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

The request has to be retried incase if the length of the SSP
Response IU is invalid.
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Reviewed-by: NHannes Reinecke <hare@suse.com>
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

PORT RECOVERY TIMEOUT is the maximum time between the controller's
detection of the PHY down until the receipt of the ID_Frame (from the
same remote SAS port). If the time expires before the ID_FRAME is
received, the port is considered INVALID and can be removed. The
IOP_EVENT_PORT_RECOVERY_TIMER_TMO event is reported following the
IOP_EVENT_ PHY_DOWN event when the PHY/port does not recover after
Port Recovery Time.
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Reviewed-by: NHannes Reinecke <hare@suse.com>
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

If the link error happens, we don't need to disconnect the phy,
which will remove the drive. Instead acknowledging the controller
and logging the error will be enough.
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Reviewed-by: NHannes Reinecke <hare@suse.com>
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Thermal page code has been changed to 7 for the 12G controllers.
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Reviewed-by: NHannes Reinecke <hare@suse.com>
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Odin.com>

Use the ata device class from libata in libsas instead of checking
the supported command set and switch to using ata_dev_classify()
instead of our own method.

Cc: Tejun Heo <tj@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Acked-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NHannes Reinecke <hare@suse.de>
Signed-off-by: NTejun Heo <tj@kernel.org>

There is a risk that the variable will be used without being initialized.

This was largely found by using a static code analysis program called cppche
Signed-off-by: NRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Acked-by: NJack Wang <xjtuwjp@gmail.com>
Signed-off-by: NChristoph Hellwig <hch@lst.de>

The driver ignores the return value in a lot of places, fix
it at least somewhere (and release the resources in such cases),
to avoid that bad things happen.
Signed-off-by: NTomas Henzl <thenzl@redhat.com>
Acked-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Acked-by: NJack Wang <xjtuwjp@gmail.com>
Signed-off-by: NChristoph Hellwig <hch@lst.de>

spin_lock_irqsave for the HBA lock is called in one function where flag
is local to that function. Another function is called from the first
function where lock has to be released using spin_unlock_irqrestore for
calling task_done of libsas. In the second function also flag is declared
and used. For calling task_done there is no need to enable the irq. So
instead of using spin_lock_irqsave and spin_unlock_irqrestore, spin_lock
and spin_unlock is used now. This also avoids passing the flags across all
the functions where HBA lock is being used. Also removed redundant code.
Reported-by: NJason Seba <jason.seba42@gmail.com>
Signed-off-by: NOleg Nesterov <oleg@redhat.com>
Signed-off-by: NSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Signed-off-by: NViswas G <viswas.g@pmcs.com>
Acked-by: NJack Wang <xjtuwjp@gmail.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

pm80xx_get_gsm_dump() was returning "1" in error case
instead of negative error value.
Signed-off-by: NViswas G <Viswas.G@pmcs.com>
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: NTomas Henzl <thenzl@redhat.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Setting the phy state for hard reset response.
After sending hard reset for a device ,phy down event sets
the phy state to zero but for phy up event it will not set
the phy state again.This will cause problem to successive
hard resets.

Signed-off-by: Nikith.Ganigarakoppal@pmcs.com
Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Supports below logging facilities,
Inbound outbound queues dump.
Non fatal dump in case of IO failures.
Fatal dump in case of firmware failure.

[jejb: checkpatch spacing fixes]
Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Phy profile implementation to support phy settings feature
for motherboard controllers.

[jejb: checkpatch fixes]
Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

[jejb: checkpatch fixes]
Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Firmware is having an issue.  When a single IO request crosses
4G boundary, system will crash.  To avoid the issue single sg is
converted into extended sg.

Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Fix for indirect data transfer mode in case of SMP request.

Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Updated pci id table with device, vendor, subdevice and subvendor ids
for 8074, 8076, 8077 SAS/SATA 12G controllers. Added 12G related macros.

Signed-off-by: Anandkumar.Santhanam@pmcs.com
Reviewed-by: NJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

The IO command size is 128 bytes for these new controllers as opposed to 64
for the old 8001 controller.

The Adaptec out-of-tree driver did this correctly. After comparing the two
this turned out to be the crucial difference.

So don't hardcode the IO command size, instead use pm8001_ha->iomb_size as
that is the correct value for both old and new controllers.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Acked-by: NAnand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com>
Acked-by: NJack Wang <xjtuwjp@gmail.com>
Cc: stable@vger.kernel.org      # for v3.10 and up
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Remove the arbitrary expectation in libsas that all SCSI commands are 16 bytes
or less.  Instead do all copies via cmd->cmd_len (and use a pointer to this in
the libsas task instead of a copy).  Note that this still doesn't enable > 16
byte CDB support in the underlying drivers because their internal format has
to be fixed and the wire format of > 16 byte CDBs according to the SAS spec is
different.  the libsas drivers (isci, aic94xx, mvsas and pm8xxx are all
updated for this change.

Cc: Lukasz Dorau <lukasz.dorau@intel.com>
Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Jack Wang <xjtuwjp@gmail.com>
Cc: Lindar Liu <lindar_liu@usish.com>
Cc: Xiangliang Yu <yuxiangl@marvell.com>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Correct spelling typo in various part of drivers
Signed-off-by: NMasanari Iida <standby24x7@gmail.com>
Signed-off-by: NJiri Kosina <jkosina@suse.cz>

These enums have been separate since the dawn of SAS, mainly because the
latter is a procotol only enum and the former includes additional state
for libsas.  The dichotomy causes endless confusion about which one you
should use where and leads to pointless warnings like this:

drivers/scsi/mvsas/mv_sas.c: In function 'mvs_update_phyinfo':
drivers/scsi/mvsas/mv_sas.c:1162:34: warning: comparison between 'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare]

Fix by eliminating one of them.  The one kept is effectively the sas.h
one, but call it sas_device_type and make sure the enums are all
properly namespaced with the SAS_ prefix.
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Modified thermal configuration to happen after interrupt registration
Added SAS controller configuration during initialization
Added error handling logic to handle I_T_Nexus errors and variants

[jejb: fix up tabs and spaces issues]
Signed-off-by: NAnand Kumar S <AnandKumar.Santhanam@pmcs.com>
Acked-by: NJack Wang <jack_wang@usish.com>
Reviewed-by: NHannes Reinecke <hare@suse.de>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Handled NCQ errors in the low level driver as the FW
is not providing the faulty tag for NCQ errors for libsas
to recover.

[jejb: fix checkpatch issues]
Signed-off-by: NAnand Kumar S <AnandKumar.Santhanam@pmcs.com>
Acked-by: NJack Wang <jack_wang@usish.com>
Reviewed-by: NHannes Reinecke <hare@suse.de>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>

Implementation of SPCv/ve specific hardware functionality and
macros. Changing common functionalities wrt SPCv/ve operations.
Conditional checks for SPC specific operations.
Signed-off-by: NSakthivel K <Sakthivel.SaravananKamalRaju@pmcs.com>
Signed-off-by: NAnand Kumar S <AnandKumar.Santhanam@pmcs.com>
Acked-by: NJack Wang <jack_wang@usish.com>
Reviewed-by: NHannes Reinecke <hare@suse.de>
Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>