1. 29 5月, 2014 1 次提交
  2. 17 5月, 2014 8 次提交
  3. 07 5月, 2014 6 次提交
    • L
      ACPICA: Tables: Add new mechanism to skip NULL entries in RSDT and XSDT. · 0f929fbf
      Lv Zheng 提交于
      It is reported that there are buggy BIOSes in the world: AMI uses an XSDT
      compiler for early BIOSes, this compiler will generate XSDT with a NULL
      entry.  The affected BIOS versions are "AMI BIOS F2-F4".
      
      Original solution on Linux is to use an alternative heathy root table
      instead of the ill one.  This commit is:
        Commit: 671cc68d
        Subject: ACPICA: Back port and refine validation of the XSDT root table.
      
      This is an example of such XSDT dumped from B85-HD3 (AMI F3 BIOS):
      [000h 0000   4]                    Signature : "XSDT"    [Extended System Description Table]
      [004h 0004   4]                 Table Length : 00000074
      [008h 0008   1]                     Revision : 01
      [009h 0009   1]                     Checksum : 18
      [00Ah 0010   6]                       Oem ID : "ALASKA"
      [010h 0016   8]                 Oem Table ID : "A M I"
      [018h 0024   4]                 Oem Revision : 01072009
      [01Ch 0028   4]              Asl Compiler ID : "AMI "
      [020h 0032   4]        Asl Compiler Revision : 00010013
      
      [024h 0036   8]       ACPI Table Address   0 : 00000000BA5F8180
      [02Ch 0044   8]       ACPI Table Address   1 : 00000000BA5F8290
      [034h 0052   8]       ACPI Table Address   2 : 00000000BA5F8308
      [03Ch 0060   8]       ACPI Table Address   3 : 00000000BA5F8848
      [044h 0068   8]       ACPI Table Address   4 : 00000000BA5F9320
      [04Ch 0076   8]       ACPI Table Address   5 : 00000000BA5F9360
      [054h 0084   8]       ACPI Table Address   6 : 00000000BA5F9398
      [05Ch 0092   8]       ACPI Table Address   7 : 00000000BA5F9708
      [064h d100   8]       ACPI Table Address   8 : 00000000BA5FC9A8
      [06Ch 0108   8]       ACPI Table Address   9 : 0000000000000000
      
      But according to the bug report, the XSDT in fact is not broken. In the
      above XSDT, ACPI Table Address 1-8 contains the same value as RSDT.  The
      differences can only be seen on the following 2 entries:
      1. The first entry points to a FADT whose Revision is 5 while the first
         entry in RSDT points to a FADT whose Revision is 2.
         The FADT dumped from the address indicated by the first entry of XSDT:
          FACP @ 0x00000000BA5F8180
            0000: 46 41 43 50 0C 01 00 00<05>4B 41 4C 41 53 4B 41  FACP.....KALASKA
            ...
         The FADT dumped from the address indicated by the first entry of RSDT:
          FACP @ 0x00000000BA5ED0F0
            0000: 46 41 43 50 84 00 00 00<02>A7 41 4C 41 53 4B 41  FACP......ALASKA
            ...
      2. The last entry is a NULL terminator.
      According to the test result, the Revision 5 FADT is accessible.  Thus the
      original solution turns out to be a work around that is preventing the
      higher revision tables to be used for such platforms (they are all x86-64
      platforms, and should use XSDT and higher revision FADT).
      
      This patch offers a new solution, where a sanity check is performed before
      installing a table address from XSDT. If the entry is NULL, it is simply
      discarded.
      
      Note that, this patch doesn't remove the original solution, so for Linux
      kernel, this commit is actually a no-op, but it allows acpidump to be
      working on such platforms. By doing so, we allow another easy revertable
      commit to enable this feature so that when that commit is reverted, the
      useful sanity check will not be affected. Lv Zheng.
      
      References: https://bugzilla.kernel.org/show_bug.cgi?id=73911
      References: https://bugs.archlinux.org/task/39811Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Reported-and-tested-by: NBruce Chiarelli <mano155@gmail.com>
      Reported-and-tested-by: NSpyros Stathopoulos <spystath@gmail.com>
      Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      0f929fbf
    • L
      ACPICA: acpidump: Add support to force using RSDT. · c7932267
      Lv Zheng 提交于
      This patch adds "-x" and "-x -x" options to disable XSDT for acpidump.
      
      The single "-x" can be used to stop using XSDT, RSDT will be forced to find
      static tables, note that XSDT will still be dumped. The double "-x" can
      stop dumping XSDT, which is useful when the XSDT address reported by RSDP
      is pointing to an invalid address.
      
      It is reported there are platforms having broken XSDT shipped, acpidump
      will stop working while accessing such XSDT. This patch adds new option so
      that users can force acpidump to dump tables listed in the RSDT. Lv Zheng.
      
      Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=73911
      Buglink: https://bugs.archlinux.org/task/39811Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Reported-and-tested-by: NBruce Chiarelli <mano155@gmail.com>
      Reported-and-tested-by: NSpyros Stathopoulos <spystath@gmail.com>
      Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      c7932267
    • L
      ACPICA: acpidump: Fix truncated RSDP signature validation. · d63f3790
      Lv Zheng 提交于
      This patch enforces a rule to always use ACPI_VALIDATE_RSDP_SIG for RSDP
      signatures passed from table header or ACPI_SIG_RSDP so that truncated
      string comparison can be avoided.  This could help to fix the issue that
      "RSD " matches but "RSD PTR " doesn't match.  Lv Zheng.
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      d63f3790
    • L
      ACPICA: acpidump: Fix code issue in invoking fread in the loop. · d87a2b75
      Lv Zheng 提交于
      This patch fixes an issue that the while loop is not needed as fread()
      should return exact the bytes of expected.
      
      The patch is tested by runing diff against the output of "-c" mode and
      the normal mode, and only finds the following differences:
      1. table addresses: the "-c" mode will always fill 0x0000000000000000 for
                          the address.
      2. RSDP/RSDT/XSDT: there is no generation of such tables for "-c" mode.
      So the test result shows the fix is valid.  Lv Zheng.
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      d87a2b75
    • P
      PM / tools: cpupower: add option to display values without round offs · e091abc7
      Prarit Bhargava 提交于
      The command "cpupower frequency-info" can be used when using cpupower to
      monitor and test processor behaviour to determine if the processor is
      behaving as expected.  This data can be compared to the output of
      /proc/cpuinfo or the output of
      /sys/devices/system/cpu/cpuX/cpufreq/scaling_available_frequencies
      to determine if the cpu is in an expected state.
      
      When doing this I noticed comparison test failures due to the way the
      data is displayed in cpupower.  For example,
      
      [root@intel-s3e37-02 cpupower]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_frequencies
      2262000 2261000 2128000 1995000 1862000 1729000 1596000 1463000 1330000
      1197000 1064000
      
      compared to
      
      [root@intel-s3e37-02 cpupower]# cpupower frequency-info
      analyzing CPU 0:
        driver: acpi-cpufreq
        CPUs which run at the same hardware frequency: 0
        CPUs which need to have their frequency coordinated by software: 0
        maximum transition latency: 10.0 us.
        hardware limits: 1.06 GHz - 2.26 GHz
        available frequency steps: 2.26 GHz, 2.26 GHz, 2.13 GHz, 2.00 GHz, 1.86 GHz, 1.73 GHz, 1.60 GHz, 1.46 GHz, 1.33 GHz, 1.20 GHz, 1.06 GHz
        available cpufreq governors: conservative, userspace, powersave, ondemand, performance
        current policy: frequency should be within 1.06 GHz and 2.26 GHz.
                        The governor "performance" may decide which speed to use
                        within this range.
        current CPU frequency is 2.26 GHz (asserted by call to hardware).
        boost state support:
          Supported: yes
          Active: yes
      
      shows very different values for the available frequency steps.  The cpupower
      output rounds off values at 2 decimal points and this causes problems with
      test scripts.  For example, with the data above,
      
      1.064 is 1.06
      1.197 is 1.20
      1.596 is 1.60
      1.995 is 2.00
      2.128 is 2.13
      
      and most confusingly,
      
      2.261 is 2.26
      2.262 is 2.26
      
      Truncating these values serves no real purpose other than making the output
      pretty.  Since the default has been to round off these values I am adding
      a -n/--no-rounding option to the cpupower utility that will display the
      data without rounding off the still significant digits.
      
      After patch,
      
      analyzing CPU 0:
        driver: acpi-cpufreq
        CPUs which run at the same hardware frequency: 0
        CPUs which need to have their frequency coordinated by software: 0
        maximum transition latency: 10.000 us.
        hardware limits: 1.064000 GHz - 2.262000 GHz
        available frequency steps: 2.262000 GHz, 2.261000 GHz, 2.128000 GHz, 1.995000 GHz, 1.862000 GHz, 1.729000 GHz, 1.596000 GHz, 1.463000 GHz, 1.330000 GHz, 1.197000 GHz, 1.064000 GHz
        available cpufreq governors: conservative, userspace, powersave, ondemand, performance
        current policy: frequency should be within 1.064000 GHz and 2.262000 GHz.
                        The governor "performance" may decide which speed to use
                        within this range.
        current CPU frequency is 2.262000 GHz (asserted by call to hardware).
        boost state support:
          Supported: yes
          Active: yes
      Acked-by: NThomas Renninger <trenn@suse.de>
      Signed-off-by: NPrarit Bhargava <prarit@redhat.com>
      [rjw: Subject]
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      e091abc7
    • J
      tools / power: turbostat: Drop temperature checks · 3482124a
      Jean Delvare 提交于
      The Intel 64 and IA-32 Architectures Software Developer's Manual says
      that TjMax is stored in bits 23:16 of MSR_TEMPERATURE TARGET (0x1a2).
      That's 8 bits, not 7, so it must be masked with 0xFF rather than 0x7F.
      
      The manual has no mention of which values should be considered valid,
      which kind of implies that they all are. Arbitrarily discarding values
      outside a specific range is wrong. The upper range check had to be
      fixed recently (commit 144b44b1) and the lower range check is just as
      wrong. See bug #75071:
      
      https://bugzilla.kernel.org/show_bug.cgi?id=75071
      
      There are many Xeon processor series with TjMax of 70, 71 or 80
      degrees Celsius, way below the arbitrary 85 degrees Celsius limit.
      There may be other (past or future) models with even lower limits.
      
      So drop this arbitrary check. The only value that would be clearly
      invalid is 0. Everything else should be accepted.
      
      After these changes, turbostat is aligned with what the coretemp
      driver does.
      Signed-off-by: NJean Delvare <jdelvare@suse.de>
      Cc: Len Brown <len.brown@intel.com>
      Acked-by: NGuenter Roeck <linux@roeck-us.net>
      Reviewed-by: NJosh Triplett <josh@joshtriplett.org>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      3482124a
  4. 01 5月, 2014 1 次提交
  5. 28 4月, 2014 1 次提交
  6. 22 4月, 2014 1 次提交
  7. 21 4月, 2014 5 次提交
  8. 06 3月, 2014 2 次提交
    • L
      tools/power turbostat: Run on Broadwell · 4e8e863f
      Len Brown 提交于
      Signed-off-by: NLen Brown <len.brown@intel.com>
      4e8e863f
    • L
      tools/power turbostat: simplify output, add Avg_MHz · fc04cc67
      Len Brown 提交于
      Use 8 columns for each number ouput.
      We don't fit into 80 columns on most machines,
      so keep the format simple.
      
      Print frequency in MHz instead of GHz.
      We've got 8 columns now, so use them to
      show low frequency in a more natural unit.
      
      Many users didn't understand what %c0 meant,
      so re-name it to be %Busy.
      
      Add Avg_MHz column, which is the frequency that many
      users expect to see -- the total number of cycles executed
      over the measurement interval.
      
      People found the previous GHz to be confusing, since
      it was the speed only over the non-idle interval.
      That measurement has been re-named Bzy_MHz.
      
      Suggested-by: Dirk J. Brandewie
      Signed-off-by: NLen Brown <len.brown@intel.com>
      fc04cc67
  9. 02 2月, 2014 2 次提交
  10. 19 1月, 2014 10 次提交
  11. 16 1月, 2014 1 次提交
    • L
      ACPICA: acpidump: Cleanup tools/power/acpi makefiles. · f677b30b
      Lv Zheng 提交于
      This patch cleans up old tools/power/acpi Makefile for further porting,
      make it compiled in a similar way as the other tools.  No functional
      changes.
      
      The CFLAGS is modified as follows:
      1. Previous cc flags:
         -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Os -s \
         -D_LINUX -DDEFINE_ALTERNATE_TYPES -I../../../include
      2. Current cc flags:
         DEBUG=false:
         -D_LINUX -DDEFINE_ALTERNATE_TYPES -I../../../include -Wall \
         -Wstrict-prototypes -Wdeclaration-after-statement -Os \
         -fomit-frame-pointer
         Normal:
         -D_LINUX -DDEFINE_ALTERNATE_TYPES -I../../../include -Wall \
         -Wstrict-prototypes -Wdeclaration-after-statement -O1 -g -DDEBUG
      
      There is only one difference: -fomit-frame-pointer.
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      f677b30b
  12. 08 1月, 2014 1 次提交
  13. 18 12月, 2013 1 次提交