1. 29 9月, 2012 1 次提交
  2. 06 3月, 2012 2 次提交
  3. 03 3月, 2012 1 次提交
  4. 02 3月, 2012 1 次提交
    • T
      NFSv4.1: Get rid of NFS4CLNT_LAYOUTRECALL · 0cb3284b
      Trond Myklebust 提交于
      The NFS4CLNT_LAYOUTRECALL bit is a long-term impediment to scalability. It
      basically stops all other recalls by a given server once any layout recall
      is requested.
      
      If the recall is for a different file, then we don't care.
      If the recall applies to the same file, then we're in one of two situations:
      Either we are in the case of a replay of an existing request, in which case
      the session is supposed to deal with matters, or we are dealing with a
      completely different request, in which case we should just try to process
      it.
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      0cb3284b
  5. 07 2月, 2012 1 次提交
  6. 01 2月, 2012 1 次提交
  7. 05 1月, 2012 1 次提交
  8. 04 8月, 2011 2 次提交
    • T
      NFSv4.1: Return NFS4ERR_BADSESSION to callbacks during session resets · 910ac68a
      Trond Myklebust 提交于
      If the client is in the process of resetting the session when it receives
      a callback, then returning NFS4ERR_DELAY may cause a deadlock with the
      DESTROY_SESSION call.
      
      Basically, if the client returns NFS4ERR_DELAY in response to the
      CB_SEQUENCE call, then the server is entitled to believe that the
      client is busy because it is already processing that call. In that
      case, the server is perfectly entitled to respond with a
      NFS4ERR_BACK_CHAN_BUSY to any DESTROY_SESSION call.
      
      Fix this by having the client reply with a NFS4ERR_BADSESSION in
      response to the callback if it is resetting the session.
      
      Cc: stable@kernel.org [2.6.38+]
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      910ac68a
    • T
      NFSv4.1: Fix the callback 'highest_used_slotid' behaviour · 55a67399
      Trond Myklebust 提交于
      Currently, there is no guarantee that we will call nfs4_cb_take_slot() even
      though nfs4_callback_compound() will consistently call
      nfs4_cb_free_slot() provided the cb_process_state has set the 'clp' field.
      The result is that we can trigger the BUG_ON() upon the next call to
      nfs4_cb_take_slot().
      
      This patch fixes the above problem by using the slot id that was taken in
      the CB_SEQUENCE operation as a flag for whether or not we need to call
      nfs4_cb_free_slot().
      It also fixes an atomicity problem: we need to set tbl->highest_used_slotid
      atomically with the check for NFS4_SESSION_DRAINING, otherwise we end up
      racing with the various tests in nfs4_begin_drain_session().
      
      Cc: stable@kernel.org [2.6.38+]
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      55a67399
  9. 13 7月, 2011 1 次提交
  10. 30 5月, 2011 3 次提交
  11. 12 3月, 2011 1 次提交
    • F
      pnfs: fix pnfs lock inversion of i_lock and cl_lock · f49f9baa
      Fred Isaman 提交于
      The pnfs code was using throughout the lock order i_lock, cl_lock.
      This conflicts with the nfs delegation code.  Rework the pnfs code
      to avoid taking both locks simultaneously.
      
      Currently the code takes the double lock to add/remove the layout to a
      nfs_client list, while atomically checking that the list of lsegs is
      empty.  To avoid this, we rely on existing serializations.  When a
      layout is initialized with lseg count equal zero, LAYOUTGET's
      openstateid serialization is in effect, making it safe to assume it
      stays zero unless we change it.  And once a layout's lseg count drops
      to zero, it is set as DESTROYED and so will stay at zero.
      Signed-off-by: NFred Isaman <iisaman@netapp.com>
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      f49f9baa
  12. 26 1月, 2011 2 次提交
  13. 07 1月, 2011 5 次提交
  14. 25 10月, 2010 1 次提交
  15. 07 8月, 2010 1 次提交
  16. 23 6月, 2010 1 次提交
  17. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  18. 10 2月, 2010 7 次提交
  19. 06 12月, 2009 2 次提交
  20. 18 6月, 2009 3 次提交
  21. 17 5月, 2008 1 次提交
  22. 30 1月, 2008 1 次提交