1. 19 4月, 2013 2 次提交
    • A
      ixgbe: in shutdown, do netif_running() under rtnl_lock · 499ab5cc
      akepner 提交于
      During shutdown it's possible for __dev_close() (which holds
      rtnl_lock) to clear the __LINK_STATE_START bit, and for ixgbe
      to then read that bit (without holding rtnl_lock), and then
      not fail to free irqs, etc. The result is a crash like this:
      
      ------------[ cut here ]------------
      kernel BUG at drivers/pci/msi.c:313!
      invalid opcode: 0000 [#1] SMP
      last sysfs file: /sys/devices/system/cpu/cpu3/cache/index2/shared_cpu_map
      CPU 1
      Pid: 5910, comm: reboot Tainted: P           ----------------   2.6.32 #1 empty
      RIP: 0010:[<ffffffff81305c2b>]  [<ffffffff81305c2b>] free_msi_irqs+0x11b/0x130
      RSP: 0018:ffff880185c9bc88  EFLAGS: 00010282
      RAX: ffff880219f58bc0 RBX: ffff88021ac53b00 RCX: 0000000000000000
      RDX: 0000000000000001 RSI: 0000000000000246 RDI: 000000000000004a
      RBP: ffff880185c9bcc8 R08: 0000000000000002 R09: 0000000000000106
      R10: 0000000000000000 R11: 0000000000000006 R12: ffff88021e524778
      R13: 0000000000000001 R14: ffff88021e524000 R15: 0000000000000000
      FS:  00007f90821b7700(0000) GS:ffff880028220000(0000) knlGS:0000000000000000
      CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
      CR2: 00007f90818bd010 CR3: 0000000132c64000 CR4: 00000000000006e0
      DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
      Process reboot (pid: 5910, threadinfo ffff880185c9a000, task ffff88021bf04a80)
      Stack:
       ffff880185c9bc98 000000018130529d ffff880185c9bcc8 ffff88021e524000
      <0> 0000000000000004 ffff88021948c700 0000000000000000 ffff880185c9bda7
      <0> ffff880185c9bce8 ffffffff81305cbd ffff880185c9bce8 ffff88021948c700
      Call Trace:
       [<ffffffff81305cbd>] pci_disable_msix+0x3d/0x50
       [<ffffffffa00501d5>] ixgbe_reset_interrupt_capability+0x65/0x90 [ixgbe]
       [<ffffffffa00512f6>] ixgbe_clear_interrupt_scheme+0xb6/0xd0 [ixgbe]
       [<ffffffffa005330b>] __ixgbe_shutdown+0x5b/0x200 [ixgbe]
       [<ffffffffa00534ca>] ixgbe_shutdown+0x1a/0x60 [ixgbe]
       [<ffffffff812f6c7c>] pci_device_shutdown+0x2c/0x50
       [<ffffffff813727fb>] device_shutdown+0x4b/0x160
       [<ffffffff8107d98c>] kernel_restart_prepare+0x2c/0x40
       ehci timer_action, mod_timer io_watchdog
       [<ffffffff8107d9e6>] kernel_restart+0x16/0x60
       [<ffffffff8107dbfd>] sys_reboot+0x1ad/0x200
       [<ffffffff811676cf>] ? __d_free+0x3f/0x60
       [<ffffffff81167748>] ? d_free+0x58/0x60
       [<ffffffff8116f7c0>] ? mntput_no_expire+0x30/0x100
       [<ffffffff81152b11>] ? __fput+0x191/0x200
       [<ffffffff816565fe>] ? do_page_fault+0x3e/0xa0
       [<ffffffff8100b132>] system_call_fastpath+0x16/0x1b
      Code: 4c 89 ef e8 98 8c e3 ff 4d 39 f4 48 8b 43 10 75 cf 48 83 c4 18 5b 41 5c
      41 5d 41 5e 41 5f c9 c3 49 8b 7d 20 e8 07 5a d3 ff eb c9 <0f> 0b 0f 1f 00 eb fb
      66 66 66 66 66 2e 0f 1f 84 00 00 00 00 00
       ehci timer_action, mod_timer io_watchdog
      RIP  [<ffffffff81305c2b>] free_msi_irqs+0x11b/0x130
       RSP <ffff880185c9bc88>
      ---[ end trace 27de882a0fe75593 ]---
      
      (This was seen on a pretty old kernel/driver, but looks like
      the same bug is still possible.)
      
      Signed-off-by: <akepner@riverbed.com>
      Tested-by: NPhil Schmitt <phillip.j.schmitt@intel.com>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      499ab5cc
    • F
      fec: Remove unneeded asm header files · 5a5967d8
      Fabio Estevam 提交于
      There is nothing in the driver that requires <asm/coldfire.h> and
      <asm/mcfsim.h>.
      Signed-off-by: NFabio Estevam <fabio.estevam@freescale.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      5a5967d8
  2. 18 4月, 2013 10 次提交
  3. 17 4月, 2013 12 次提交
  4. 16 4月, 2013 5 次提交
    • O
      can: sja1000: use common prefix for all sja1000 defines · 06e1d1d7
      Oliver Hartkopp 提交于
      This is a follow up patch to:
      
          f901b6bc can: sja1000: fix define conflict on SH
      
      That patch fixed a define conflict between the SH architecture and the sja1000
      driver, by addind a prefix to one macro only. This patch consistently renames
      the prefix of the SJA1000 controller registers from "REG_" to "SJA1000_".
      Signed-off-by: NOliver Hartkopp <socketcan@hartkopp.net>
      Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      06e1d1d7
    • V
      team: Use new sync_multiple api to sync devices adressess. · 72b27032
      Vlad Yasevich 提交于
      Team drivers attempts to sync addresses to each of the port
      devices; however, the current api doesn't really perform the sync
      for any device after the first one.  Switch to using the new api
      that will actually sync the addresses to all ports.
      
      CC: Jiri Pirko <jiri@resnulli.us>
      Signed-off-by: NVlad Yasevich <vyasevic@redhat.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      72b27032
    • D
      sis900: check for DMA map errors · 1e8edc2a
      Denis Kirjanov 提交于
      The first backtrace appears on tx path with DMA mapping operations debug
      enabled.
      
      [  345.637919] ------------[ cut here ]------------
      [  345.637971] WARNING: at lib/dma-debug.c:937 check_unmap+0x4df/0x910()
      [  345.637977] Hardware name: System Name
      [  345.637987] sis900 0000:00:01.1: DMA-API: device driver failed to check map error[device address=0x000000000d4aed02] [si
      ze=60 bytes] [mapped as single]
      [  345.637993] Modules linked in: bridge stp llc dmfe sundance 3c59x sis900
      [  345.638022] Pid: 0, comm: swapper Not tainted 3.9.0-rc6+ #4
      [  345.638028] Call Trace:
      [  345.638042]  [<c122097f>] ? check_unmap+0x4df/0x910
      [  345.638059]  [<c102b19c>] warn_slowpath_common+0x7c/0xa0
      [  345.638070]  [<c122097f>] ? check_unmap+0x4df/0x910
      [  345.638081]  [<c102b23e>] warn_slowpath_fmt+0x2e/0x30
      [  345.638092]  [<c122097f>] check_unmap+0x4df/0x910
      [  345.638107]  [<c100bfeb>] ? save_stack_trace+0x2b/0x50
      [  345.638120]  [<c107238e>] ? mark_lock+0x31e/0x5d0
      [  345.638132]  [<c1072b2c>] ? __lock_acquire+0x4ec/0x7d0
      [  345.638143]  [<c1220f6d>] debug_dma_unmap_page+0x6d/0x80
      [  345.638166]  [<cf834dec>] sis900_interrupt+0x49c/0x860 [sis900]
      [  345.638195]  [<c1094b73>] handle_irq_event_percpu+0x43/0x1c0
      [  345.638206]  [<c1094d1e>] ? handle_irq_event+0x2e/0x60
      [  345.638217]  [<c1094d27>] handle_irq_event+0x37/0x60
      [  345.638235]  [<c10973f0>] ? irq_set_chip_data+0x40/0x40
      [  345.638246]  [<c1097442>] handle_level_irq+0x52/0xa0
      [  345.638251]  <IRQ>  [<c1003629>] ? do_IRQ+0x39/0xa0
      [  345.638293]  [<c1484631>] ? common_interrupt+0x31/0x36
      [  345.638347]  [<d08c2c52>] ? br_flood_forward+0x12/0x20 [bridge]
      [  345.638364]  [<d08c2d40>] ? br_dev_queue_push_xmit+0x60/0x60 [bridge]
      [  345.638381]  [<d08c3b2b>] ? br_handle_frame_finish+0x25b/0x280 [bridge]
      [  345.638399]  [<d08c3ce3>] ? br_handle_frame+0x193/0x290 [bridge]
      [  345.638416]  [<d08c3b50>] ? br_handle_frame_finish+0x280/0x280 [bridge]
      [  345.638431]  [<c13b3c87>] ? __netif_receive_skb_core+0x1d7/0x710
      [  345.638442]  [<c13b3b19>] ? __netif_receive_skb_core+0x69/0x710
      [  345.638454]  [<c13b41e1>] ? __netif_receive_skb+0x21/0x70
      [  345.638464]  [<c13b42b5>] ? process_backlog+0x85/0x130
      [  345.638476]  [<c13b4bbb>] ? net_rx_action+0xfb/0x1d0
      [  345.638497]  [<c1032768>] ? __do_softirq+0xa8/0x1f0
      [  345.638527]  [<c147daad>] ? _raw_spin_unlock+0x1d/0x20
      [  345.638538]  [<c10038c0>] ? handle_irq+0x20/0xd0
      [  345.638550]  [<c1032f27>] ? irq_exit+0x97/0xa0
      [  345.638560]  [<c1003632>] ? do_IRQ+0x42/0xa0
      [  345.638580]  [<c104d003>] ? hrtimer_start+0x23/0x30
      [  345.638580]  [<c1484631>] ? common_interrupt+0x31/0x36
      [  345.638580]  [<c1008703>] ? default_idle+0x33/0xc0
      [  345.638580]  [<c10086ac>] ? cpu_idle+0x4c/0x70
      [  345.638580]  [<c14787e0>] ? rest_init+0xa0/0xb0
      [  345.638580]  [<c1478740>] ? reciprocal_value+0x50/0x50
      [  345.638580]  [<c16b5bcf>] ? start_kernel+0x28f/0x320
      [  345.638580]  [<c16b54e0>] ? repair_env_string+0x60/0x60
      [  345.638580]  [<c16b5269>] ? i386_start_kernel+0x39/0xa0
      [  345.638580] ---[ end trace a244264b69b8a7ae ]---
      [  345.638580] Mapped at:
      [  345.638580]  [<c1221c65>] debug_dma_map_page+0x65/0x110
      [  345.638580]  [<cf8355a9>] sis900_start_xmit+0x129/0x210 [sis900]
      [  345.638580]  [<c13b2527>] dev_hard_start_xmit+0x1b7/0x530
      [  345.638580]  [<c13cc32e>] sch_direct_xmit+0x8e/0x280
      [  345.638580]  [<c13b4e39>] dev_queue_xmit+0x1a9/0x5b0
      Signed-off-by: NDenis Kirjanov <kda@linux-powerpc.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      1e8edc2a
    • N
      net/macb: fix error return code in macb_probe() · 72ca820b
      Nicolas Ferre 提交于
      Fix to return a negative error code from the error handling
      case instead of 0, as returned elsewhere in this function.
      
      Original-idea-by: <yongjun_wei@trendmicro.com.cn>
      Signed-off-by: NNicolas Ferre <nicolas.ferre@atmel.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      72ca820b
    • M
      vxlan: don't bypass encapsulation for multi- and broadcasts · ab09a6d0
      Mike Rapoport 提交于
      The multicast and broadcast packets may have RTCF_LOCAL set in rt_flags
      and therefore will be sent out bypassing encapsulation. This breaks
      delivery of packets sent to the vxlan multicast group.
      Disabling encapsulation bypass for multicasts and broadcasts fixes the
      issue.
      Signed-off-by: NMike Rapoport <mike.rapoport@ravellosystems.com>
      Tested-by: NCong Wang <xiyou.wangcong@gmail.com>
      Acked-by: NSridhar Samudrala <sri@us.ibm.com>
      Tested-by: NSridhar Samudrala <sri@us.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      ab09a6d0
  5. 15 4月, 2013 4 次提交
  6. 14 4月, 2013 1 次提交
  7. 13 4月, 2013 5 次提交
  8. 12 4月, 2013 1 次提交