1. 06 4月, 2016 1 次提交
    • T
      ALSA: intel8x0: Drop superfluous VM checks · 4926c804
      Takashi Iwai 提交于
      intel8x0 driver has the inside_vm check for skipping a buggy hardware
      workaround in the PCM pointer callback in the commit [228cf793:
      ALSA: intel8x0: Improve performance in virtual environment].  This was
      originally applied to all devices on known VMs, but the code was
      switched to use the PCI  ID matching for applying to only known
      devices (KVM and Parallels), in order to avoid applying wrongly to
      VT-d and other such cases, in the commit [7fb4f392: ALSA:
      intel8x0: improve virtual environment detection].
      
      Meanwhile, the original VM check was kept even after switching to the
      PCI ID matching.  It was partly because we weren't 100% sure whether
      we had covered all well, and partly because this would help
      identifying the issue once when a user of another VM hit the same
      problem or a regression.  Currently the VM check is used only for
      showing the kernel message that the VM-optimization isn't applied, and
      the VM check itself doesn't change the actual driver behavior at all.
      
      Despite the relatively safe driver behavior, the code caught attention
      of developers badly and brought many confusion / misunderstanding.
      Since we've got neither regression nor enhancement report for other
      VMs for five years long, it's likely safe to drop this superfluous VM
      check now.
      
      The module option is still kept, so if a user still needs to adjust,
      it can be applied as was.
      Acked-by: NKonstantin Ozerkov <kozerkov@parallels.com>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      4926c804
  2. 14 3月, 2016 1 次提交
  3. 09 3月, 2016 1 次提交
  4. 29 5月, 2015 1 次提交
  5. 16 4月, 2015 1 次提交
  6. 05 4月, 2015 1 次提交
  7. 28 1月, 2015 1 次提交
  8. 09 1月, 2015 1 次提交
    • T
      ALSA: intel8x0: Simplify PM callbacks · 3c5a03d4
      Takashi Iwai 提交于
      This is a similar cleanup like the commit [3db084fd: ALSA: fm801:
      PCI core handles power state for us].
      
      Since pci_set_power_state(), pci_save_state() and pci_restore_state()
      are already done in the PCI core side, so we don't need to it doubly.
      
      Also, pci_enable_device(), pci_disable_device() and pci_set_master()
      calls in PM callbacks are superfluous nowadays, too, so get rid of
      them as well.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      3c5a03d4
  9. 13 8月, 2014 1 次提交
  10. 12 6月, 2014 1 次提交
  11. 26 2月, 2014 1 次提交
  12. 12 2月, 2014 1 次提交
  13. 06 11月, 2013 1 次提交
  14. 29 5月, 2013 1 次提交
    • T
      ALSA: PCI: Remove superfluous pci_set_drvdata(pci, NULL) at remove · 20a24225
      Takashi Iwai 提交于
      As drvdata is cleared to NULL at probe failure or at removal by the
      driver core, we don't have to call pci_set_drvdata(pci, NULL) any
      longer in each driver.
      
      The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in
      hda_intel.c.  Since this function itself releases the card instance,
      we need to clear drvdata here as well, so that it won't be released
      doubly in the remove callback.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      20a24225
  15. 26 1月, 2013 1 次提交
    • T
      ALSA: Make snd_printd() and snd_printdd() inline · 86b27237
      Takashi Iwai 提交于
      Because currently snd_printd() and snd_printdd() macros are expanded
      to empty when CONFIG_SND_DEBUG=n, a compile warning like below
      appears sometimes, and we had to covert it by ugly ifdefs:
        sound/pci/hda/patch_sigmatel.c: In function ‘stac92hd71bxx_fixup_hp’:
        sound/pci/hda/patch_sigmatel.c:2434:24: warning: unused variable ‘spec’ [-Wunused-variable]
      
      For "fixing" these issues better, this patch replaces snd_printd() and
      snd_printdd() definitions with empty inline functions instead of
      macros.  This should have the same effect but shut up warnings like
      above.
      
      But since we had already put ifdefs, changing to inline functions
      would trigger compile errors.  So, such ifdefs is removed in this
      patch.
      
      In addition, snd_pci_quirk name field is defined only when
      CONFIG_SND_DEBUG_VERBOSE is set, and the reference to it in
      snd_printdd() argument triggers the build errors, too.  For avoiding
      these errors, introduce a new macro snd_pci_quirk_name() that is
      defined no matter how the debug option is set.
      Reported-by: NStratos Karafotis <stratosk@semaphore.gr>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      86b27237
  16. 07 12月, 2012 1 次提交
  17. 06 10月, 2012 1 次提交
  18. 07 9月, 2012 1 次提交
  19. 15 8月, 2012 1 次提交
  20. 03 7月, 2012 1 次提交
  21. 24 4月, 2012 1 次提交
  22. 14 2月, 2012 1 次提交
  23. 13 1月, 2012 1 次提交
    • R
      module_param: avoid bool abuse, add bint for special cases. · 69116f27
      Rusty Russell 提交于
      For historical reasons, we allow module_param(bool) to take an int (or
      an unsigned int).  That's going away.
      
      A few drivers really want an int: they set it to -1 and a parameter
      will set it to 0 or 1.  This sucks: reading them from sysfs will give
      'Y' for both -1 and 1, but if we change it to an int, then the users
      might be broken (if they did "param" instead of "param=1").
      
      Use a new 'bint' parser for them.
      
      (ntfs has a different problem: it needs an int for debug_msgs because
      it's also exposed via sysctl.)
      
      Cc: Steve Glendinning <steve.glendinning@smsc.com>
      Cc: Jean Delvare <khali@linux-fr.org>
      Cc: Guenter Roeck <guenter.roeck@ericsson.com>
      Cc: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
      Cc: Christoph Raisch <raisch@de.ibm.com>
      Cc: Roland Dreier <roland@kernel.org>
      Cc: Sean Hefty <sean.hefty@intel.com>
      Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
      Cc: linux390@de.ibm.com
      Cc: Anton Altaparmakov <anton@tuxera.com>
      Cc: Jaroslav Kysela <perex@perex.cz>
      Cc: Takashi Iwai <tiwai@suse.de>
      Cc: lm-sensors@lm-sensors.org
      Cc: linux-rdma@vger.kernel.org
      Cc: linux-s390@vger.kernel.org
      Cc: linux-ntfs-dev@lists.sourceforge.net
      Cc: alsa-devel@alsa-project.org
      Acked-by: Takashi Iwai <tiwai@suse.de> (For the sound part)
      Acked-by: Guenter Roeck <guenter.roeck@ericsson.com> (For the hwmon driver)
      Signed-off-by: NRusty Russell <rusty@rustcorp.com.au>
      69116f27
  24. 19 12月, 2011 1 次提交
  25. 10 11月, 2011 2 次提交
  26. 08 11月, 2011 1 次提交
  27. 01 11月, 2011 2 次提交
  28. 31 10月, 2011 1 次提交
    • K
      ALSA: intel8x0: Improve performance in virtual environment · 228cf793
      Konstantin Ozerkov 提交于
      v3: detection code is x86 and KVM specific, hide it under ifdef
      v2: add detection for virtual environments (KVM and Parallels)
      
      This patch is intended to improve performance in virtualized environments
      like Parallels Desktop or KVM/VirtualBox/QEMU (virtual ICH/AC97 audio).
      
      I/O access is very time-expensive operation in virtual world: VCPU
      can be rescheduled and in the worst case we get more than 10ms delay on
      each I/O access.
      
      In the virtual environment loop exit rule
      (old_civ == current_civ && old_picb == current_picb) is never satisfied,
      because old_picb is never the same as current_picb due to delay inspired
      by reading current_civ. As a result loop ended by timeout and we get 10x
      more I/O operations.
      
      Experimental data from Prallels Desktop 7, RHEL6 guest (I/O ops per
      second):
      
      Original code:
      In Port    Counter         Callback
         f014      41550         fffff00000179d00 ac97_bm_read_civ+0x000
         f018      41387         fffff0000017a580 ac97_bm_read_picb+0x000
      
      With patch:
      In Port    Counter         Callback
         f014       4090         fffff00000179d00 ac97_bm_read_civ+0x000
         f018       1964         fffff0000017a580 ac97_bm_read_picb+0x000
      Signed-off-by: NKonstantin Ozerkov <kozerkov@parallels.com>
      Signed-off-by: NDenis V. Lunev <den@openvz.org>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      228cf793
  29. 15 7月, 2011 1 次提交
  30. 10 6月, 2011 2 次提交
    • T
      ALSA: use KBUILD_MODNAME for request_irq argument in sound/pci/* · 934c2b6d
      Takashi Iwai 提交于
      The name argument of request_irq() appears in /proc/interrupts, and
      it's quite ugly when the name entry contains a space or special letters.
      In general, it's simpler and more readable when the module name appears
      there, so let's replace all entries with KBUILD_MODNAME.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      934c2b6d
    • T
      ALSA: Use KBUILD_MODNAME for pci_driver.name entries · 3733e424
      Takashi Iwai 提交于
      The convention for pci_driver.name entry in kernel drivers seem to be
      the module name or equivalent ones.  But, so far, almost all PCI sound
      drivers use more verbose name like "ABC Xyz (12)", and these are fairly
      confusing when appearing as a file name.
      
      This patch converts the all pci_driver.name entries in sound/pci/* to
      use KBUILD_MODNAME for more unified appearance.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      3733e424
  31. 31 3月, 2011 1 次提交
  32. 22 11月, 2010 1 次提交
  33. 18 10月, 2010 1 次提交
  34. 19 8月, 2010 1 次提交
  35. 09 2月, 2010 1 次提交
  36. 25 11月, 2009 1 次提交
  37. 05 11月, 2009 1 次提交