1. 23 10月, 2015 1 次提交
  2. 25 8月, 2015 1 次提交
    • A
      perf ui tui progress: Implement the ui_progress_ops->finish() method · 1e259ad4
      Arnaldo Carvalho de Melo 提交于
      So that we can erase the progress bar after we're done with it, avoiding
      things like:
      
      -------------------------------------------------------------------
      
                ┌─Error:──────────────────────────────────────────────────────┐
                │Can't annotate unmapped_area_topdown:                        │
                │                                                             │
                │No vmlinux file with build id a826726b5ddacfab1f0bade868f1a79│
                │was found in the path.                                       │
                │                                                             │
                │Note that annotation using /proc/kcore requires CAP_SYS_RAWIO│
      ┌Processin│                                                             │──┐
      │         │Please use:                                                  │  │
      └─────────│                                                             │──┘
                │  perf buildid-cache -vu vmlinux                             │
                │                                                             │
                │or:                                                          │
                │                                                             │
                │  --vmlinux vmlinux                                          │
                │                                                             │
                │                                                             │
                │Press any key...                                             │
                └─────────────────────────────────────────────────────────────┘
      
      Can't annotate unmapped_area_topdown:
      -------------------------------------------------------------------
      
      I.e. that finished progress bar behind the error window. It is not a
      problem when we end up redrawing the whole screen, but its ugly when
      we present such error windows, provide a TUI method so that code like
      the above may avoid this situation, as will be done with the annotation
      code in the next cset.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Borislav Petkov <bp@suse.de>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-qvktnojzwwe37pweging058t@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      1e259ad4
  3. 12 8月, 2015 1 次提交
  4. 29 5月, 2015 1 次提交
  5. 12 2月, 2015 1 次提交
  6. 23 1月, 2015 1 次提交
  7. 23 12月, 2014 1 次提交
  8. 26 12月, 2013 1 次提交
  9. 12 11月, 2013 1 次提交
    • P
      perf ui tui progress: Don't force a refresh during progress update · d53e57d0
      Patrick Palka 提交于
      Each call to tui_progress__update() would forcibly refresh the entire
      screen.  This is somewhat inefficient and causes noticable flickering
      during the startup of perf-report, especially on large/slow terminals.
      
      It looks like the force-refresh in tui_progress__update() serves no
      purpose other than to clear the screen so that the progress bar of a
      previous operation does not subsume that of a subsequent operation.  But
      we can do just that in a much more efficient manner by clearing only the
      region that a previous progress bar may have occupied before repainting
      the new progress bar.  Then the force-refresh could be removed with no
      change in visuals.
      
      This patch disables the slow force-refresh in tui_progress__update() and
      instead calls SLsmg_fill_region() on the entire area that the progress
      bar may occupy before repainting it.  This change makes the startup of
      perf-report much faster and appear much "smoother".
      
      It turns out that this was a big bottleneck in the startup speed of
      perf-report -- with this patch, perf-report starts up ~2x faster (1.1s
      vs 0.55s) on my machines.  (These numbers were measured by running "time
      perf report" on an 8MB perf.data and pressing 'q' immediately.)
      Signed-off-by: NPatrick Palka <patrick@parcs.ath.cx>
      Acked-by: NIngo Molnar <mingo@kernel.org>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Link: http://lkml.kernel.org/r/1382747149-9716-1-git-send-email-patrick@parcs.ath.cxSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      d53e57d0
  10. 24 10月, 2013 2 次提交
  11. 01 4月, 2013 1 次提交
  12. 09 12月, 2012 1 次提交
  13. 15 11月, 2012 2 次提交
  14. 11 9月, 2012 1 次提交
    • I
      perf tools: Use __maybe_used for unused variables · 1d037ca1
      Irina Tirdea 提交于
      perf defines both __used and __unused variables to use for marking
      unused variables. The variable __used is defined to
      __attribute__((__unused__)), which contradicts the kernel definition to
      __attribute__((__used__)) for new gcc versions. On Android, __used is
      also defined in system headers and this leads to warnings like: warning:
      '__used__' attribute ignored
      
      __unused is not defined in the kernel and is not a standard definition.
      If __unused is included everywhere instead of __used, this leads to
      conflicts with glibc headers, since glibc has a variables with this name
      in its headers.
      
      The best approach is to use __maybe_unused, the definition used in the
      kernel for __attribute__((unused)). In this way there is only one
      definition in perf sources (instead of 2 definitions that point to the
      same thing: __used and __unused) and it works on both Linux and Android.
      This patch simply replaces all instances of __used and __unused with
      __maybe_unused.
      Signed-off-by: NIrina Tirdea <irina.tirdea@intel.com>
      Acked-by: NPekka Enberg <penberg@kernel.org>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Namhyung Kim <namhyung.kim@lge.com>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Steven Rostedt <rostedt@goodmis.org>
      Link: http://lkml.kernel.org/r/1347315303-29906-7-git-send-email-irina.tirdea@intel.com
      [ committer note: fixed up conflict with a116e05d in builtin-sched.c ]
      Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      1d037ca1
  15. 09 9月, 2012 1 次提交
  16. 17 8月, 2012 2 次提交
  17. 20 6月, 2012 1 次提交
  18. 03 5月, 2012 2 次提交