1. 06 9月, 2012 1 次提交
    • S
      perf tools: Remove the node from rblist in strlist__remove · 45922814
      Suzuki K. Poulose 提交于
      The following commit:
      
      author	David Ahern <dsahern@gmail.com>
      	Tue, 31 Jul 2012 04:31:33 +0000 (22:31 -0600)
      committer	Arnaldo Carvalho de Melo <acme@redhat.com>
      	Fri, 3 Aug 2012 13:39:51 +0000 (10:39 -0300)
      commit	ee8dd3ca
      
      causes a double free during a probe deletion as the node is never
      removed from the list via strlist__remove(), even though it gets
      'deleted' (read free()'d). This causes a double free when we do
      strlist__delete() as the node is already deleted but present in the
      rblist.
      
      [suzukikp@suzukikp perf]$ sudo ./perf probe -a do_fork
      Added new event:
        probe:do_fork        (on do_fork)
      
      You can now use it in all perf tools, such as:
      
      	perf record -e probe:do_fork -aR sleep 1
      
      [suzukikp@suzukikp perf]$ sudo ./perf probe -d do_fork
      Removed event: probe:do_fork
      *** glibc detected *** ./perf: double free or corruption (fasttop): 0x000000000133d600 ***
      ======= Backtrace: =========
      /lib64/libc.so.6[0x38eec7dda6]
      ./perf(rblist__delete+0x5c)[0x47d3dc]
      ./perf(del_perf_probe_events+0xb6)[0x47b826]
      ./perf(cmd_probe+0x471)[0x42c8d1]
      ./perf[0x4150b3]
      ./perf(main+0x501)[0x4148e1]
      /lib64/libc.so.6(__libc_start_main+0xed)[0x38eec2169d]
      ./perf[0x414a61]
      
      Make sure we remove the node from the rblist before we delete the node.
      The rblist__remove_node() will invoke rblist->node_delete, which  will
      take care of deleting the node with the suitable function provided by
      the user.
      Reported-by: NAnanth N. Mavinakayanahalli <ananth@in.ibm.com>
      Signed-off-by: NSuzuki K. Poulose <suzuki@in.ibm.com>
      Acked-by: NDavid Ahern <dsahern@gmail.com>
      Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/20120829055840.7802.1459.stgit@suzukikp.in.ibm.comSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      45922814
  2. 03 8月, 2012 1 次提交
  3. 16 12月, 2009 1 次提交
    • M
      perf probe: Fix --del to update current event list · 3e340590
      Masami Hiramatsu 提交于
      Fix --del option to update current existing event list
      after perf probe deleted an event.
      Signed-off-by: NMasami Hiramatsu <mhiramat@redhat.com>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Steven Rostedt <rostedt@goodmis.org>
      Cc: Jim Keniston <jkenisto@us.ibm.com>
      Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
      Cc: Christoph Hellwig <hch@infradead.org>
      Cc: Frank Ch. Eigler <fche@redhat.com>
      Cc: Jason Baron <jbaron@redhat.com>
      Cc: K.Prasad <prasad@linux.vnet.ibm.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
      Cc: systemtap <systemtap@sources.redhat.com>
      Cc: DLE <dle-develop@lists.sourceforge.net>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      LKML-Reference: <20091215153149.17436.61265.stgit@dhcp-100-2-132.bos.redhat.com>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      3e340590
  4. 12 7月, 2009 1 次提交
  5. 01 7月, 2009 1 次提交