In this commit sec_level, force_reliable, role_switch and flushable.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

l2cap_chan_connect() is a much better name and reflects what this
functions is doing (or will do once socket dependence is removed from the
core).
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

First move of elements depending on user data.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

If the allocation happens at l2cap_sock_create() will be able to use the
struct l2cap_chan to store channel info that comes from the user via
setsockopt.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

The locking with SMPS requests means that the
debugs file should lock the mgd mutex, not the
iflist mutex. Calls to __ieee80211_request_smps()
need to hold that mutex, so add an assertion.

This has always been wrong, but for some reason
never been noticed, probably because the locking
error only happens while unassociated.

Cc: stable@kernel.org [2.6.34+]
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>

When retrasmitting one frame, only SAR bits in control field should
be kept.
Signed-off-by: NRuiyi Zhang <Ruiyi.zhang@atheros.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

shutdown should wait for SCO link to be properly disconnected before
detroying the socket, otherwise an application using the socket may
assume link is properly disconnected before it really happens which
can be a problem when e.g synchronizing profile switch.
Signed-off-by: NLuiz Augusto von Dentz <luiz.dentz-von@nokia.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

In the teardown path the reset command is sent to the controller,
this event causes the command timer to be reactivated.

So the timer is removed in two situations, when the adapter isn't
marked as UP and when we know that some command has been sent.
Reported-by: NKeith Packard <keithp@keithp.com>
Signed-off-by: NVinicius Costa Gomes <vinicius.gomes@openbossa.org>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

hci_io_capa_reply_evt() holds reference for hciconnection. It's useless since
hci_io_capa_request_evt()/hci_simple_pair_complete_evt() already protects the
connection. In addition it leaves connection open after failed SSP pairing.
Signed-off-by: NVille Tervo <ville.tervo@nokia.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Fix a regression from the L2CAP "rewrite" patches.
Purge the tx_q already happens on l2cap_chan_del() so we don't need it at
l2cap_disconnect_req().
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

l2cap_get_sock_by_scid was changed to not lock the socket anymore, but I
forgot to change all the users of this function.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Fix an locking issue with the new l2cap_att_channel(). l2cap_att_channel()
was trying to lock a locked socket.
Reported-by: NAnderson Lizardo <anderson.lizardo@openbossa.org>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Use kernel stored remote Out Of Band data only if management interface
is enabled. Otherwise HCI_OP_REMOTE_OOB_DATA_NEG_REPLY was sent to
controller even if remote Out Of Band data was present in bluetoothd.
Signed-off-by: NSzymon Janc <szymon.janc@tieto.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Despite it works, handling through l2cap_data_channel() is wrongs.
That function should handle only connection oriented data.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

We should check for the pi->scid there.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

tx_q is the queue used by ERTM mode.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

That was unnecessary use of it.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Change some BT_DBG messages and consequently remove some struct sock
declarations.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of moving all the Channel related operation to struct l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

This is a regression acctually, caused by the first patch series for
creating a formal strcut l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel stuff to l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel stuff to l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

This also triggered a change in l2cap_send_disconn_req() parameters.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel stuff to l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel stuff to l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel stuff to l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel to stuff to struct l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

This is part of "moving things to l2cap_chan". As one the first move it
triggered a big number of changes in the funcions parameters, basically
changing the struct sock param to struct l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Move some channel specific stuff to l2cap_core.c, this will make things
more clear.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

They are also l2cap_chan specific.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

ident is chan property, no need to reside on socket.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As we use struct list_head to keep L2CAP channels list the workaround with
del_list is not needed anymore.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Use a well known Kernel API is always a good idea than implement your own
list.
In the future we might use RCU on this list.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

struct l2cap_chan cames to create a clear separation between what
properties and data belongs to the L2CAP channel and what belongs to the
socket. By now we just fold the struct sock * in struct l2cap_chan as all
the channel info is struct l2cap_pinfo today.

In the next commits we will see a move of channel stuff to struct
l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Convert from strict_strto*() interfaces to kstrto*() interfaces.
Signed-off-by: NAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

The allocation in mgmt_control() code are in user context and not locked
by any spinlock, so it's not recommended the use of GFP_ATOMIC there.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

spin_lock() and spin_unlock() are more apropiated for user context.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

kernel_thread() is a low-level implementation detail and
EXPORT_SYMBOL(kernel_thread) is scheduled for removal.
Use the <linux/kthread.h> API instead.
Signed-off-by: NSzymon Janc <szymon.janc@tieto.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

kernel_thread() is a low-level implementation detail and
EXPORT_SYMBOL(kernel_thread) is scheduled for removal.
Use the <linux/kthread.h> API instead.
Signed-off-by: NSzymon Janc <szymon.janc@tieto.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

kernel_thread() is a low-level implementation detail and
EXPORT_SYMBOL(kernel_thread) is scheduled for removal.
Use the <linux/kthread.h> API instead.
Signed-off-by: NSzymon Janc <szymon.janc@tieto.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>