1. 07 3月, 2017 2 次提交
    • J
      scsi: lpfc: Rename LPFC_MAX_EQ_DELAY to LPFC_MAX_EQ_DELAY_EQID_CNT · 43140ca6
      James Smart 提交于
      Without apriori understanding of what the define is, the name gives
      a very different impression of what it is (a max delay value
      for an EQ).  Rename the define so it reflects what it is: the number
      of EQ IDs that can be set in one instance of the MODIFY_EQ_DELAY
      mbx command.
      Signed-off-by: NDick Kennedy <dick.kennedy@broadcom.com>
      Signed-off-by: NJames Smart <james.smart@broadcom.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      43140ca6
    • J
      scsi: lpfc: Fix eh_deadline setting for sli3 adapters. · 96418b5e
      James Smart 提交于
      A previous change unilaterally removed the hba reset entry point
      from the sli3 host template. This was done to allow tape devices
      being used for back up from being removed. Why was this done ?
      When there was non-responding device on the fabric, the error
      escalation policy would escalate to the reset handler. When the
      reset handler was called, it would reset the adapter, dropping
      link, thus logging out and terminating all i/o's - on any target.
      If there was a tape device on the same adapter that wasn't in
      error, it would kill the tape i/o's, effectively killing the
      tape device state.  With the reset point removed, the adapter
      reset avoided the fabric logout, allowing the other devices to
      continue to operate unaffected. A hack - yes. Hint: we really
      need a transport I_T nexus reset callback added to the eh process
      (in between the SCSI target reset and hba reset points), so a
      fc logout could occur to the one bad target only and stop the error
      escalation process.
      
      This patch commonizes the approach so it can be used for sli3 and sli4
      adapters, but mandates the admin, via module parameter, specifically
      identify which adapters the resets are to be removed for. Additionally,
      bus_reset, which sends Target Reset TMFs to all targets, is also removed
      from the template as it too has the same effect as the adapter reset.
      Signed-off-by: NDick Kennedy <dick.kennedy@broadcom.com>
      Signed-off-by: NJames Smart <james.smart@broadcom.com>
      Reviewed-by: NLaurence Oberman <loberman@redhat.com>
      Tested-by: NLaurence Oberman <loberman@redhat.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      96418b5e
  2. 23 2月, 2017 5 次提交
  3. 21 1月, 2017 1 次提交
  4. 06 1月, 2017 1 次提交
  5. 05 1月, 2017 4 次提交
  6. 09 11月, 2016 9 次提交
  7. 21 7月, 2016 1 次提交
    • A
      scsi: lpfc: avoid harmless comparison warning · de8c36bb
      Arnd Bergmann 提交于
      When building with -Wextra, we get a lot of warnings for the lpfc driver
      concerning expressions that are always true, starting with:
      
      drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_npiv_init':
      drivers/scsi/lpfc/lpfc_attr.c:2786:77: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
      drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_rrq_init':
      drivers/scsi/lpfc/lpfc_attr.c:2802:76: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
      drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_suppress_link_up_init':
      drivers/scsi/lpfc/lpfc_attr.c:2812:2050: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
      drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_log_verbose_init':
      drivers/scsi/lpfc/lpfc_attr.c:3064:1930: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
      
      The code works as intended, but it would be nice to shut up the warning
      so we don't clutter up build logs with this. Using a separate inline
      function for it makes it clear to the compiler that the comparison is
      necessary in the caller but still lets it do the constant-folding.
      
      [mkp: fix typo]
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Reviewed-by: NJohannes Thumshirn <jthumshirn@suse.de>
      Acked-by: NJames Smart <james.smart@broadcom.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      de8c36bb
  8. 16 7月, 2016 6 次提交
  9. 12 4月, 2016 3 次提交
  10. 22 12月, 2015 2 次提交
  11. 27 10月, 2015 2 次提交
  12. 10 4月, 2015 3 次提交
  13. 17 9月, 2014 1 次提交