1. 14 8月, 2012 1 次提交
    • T
      workqueue: use mod_delayed_work() instead of cancel + queue · 41f63c53
      Tejun Heo 提交于
      Convert delayed_work users doing cancel_delayed_work() followed by
      queue_delayed_work() to mod_delayed_work().
      
      Most conversions are straight-forward.  Ones worth mentioning are,
      
      * drivers/edac/edac_mc.c: edac_mc_workq_setup() converted to always
        use mod_delayed_work() and cancel loop in
        edac_mc_reset_delay_period() is dropped.
      
      * drivers/platform/x86/thinkpad_acpi.c: No need to remember whether
        watchdog is active or not.  @fan_watchdog_active and related code
        dropped.
      
      * drivers/power/charger-manager.c: Seemingly a lot of
        delayed_work_pending() abuse going on here.
        [delayed_]work_pending() are unsynchronized and racy when used like
        this.  I converted one instance in fullbatt_handler().  Please
        conver the rest so that it invokes workqueue APIs for the intended
        target state rather than trying to game work item pending state
        transitions.  e.g. if timer should be modified - call
        mod_delayed_work(), canceled - call cancel_delayed_work[_sync]().
      
      * drivers/thermal/thermal_sys.c: thermal_zone_device_set_polling()
        simplified.  Note that round_jiffies() calls in this function are
        meaningless.  round_jiffies() work on absolute jiffies not delta
        delay used by delayed_work.
      
      v2: Tomi pointed out that __cancel_delayed_work() users can't be
          safely converted to mod_delayed_work().  They could be calling it
          from irq context and if that happens while delayed_work_timer_fn()
          is running, it could deadlock.  __cancel_delayed_work() users are
          dropped.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Acked-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Acked-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
      Acked-by: NAnton Vorontsov <cbouatmailru@gmail.com>
      Acked-by: NDavid Howells <dhowells@redhat.com>
      Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Jiri Kosina <jkosina@suse.cz>
      Cc: Doug Thompson <dougthompson@xmission.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Roland Dreier <roland@kernel.org>
      Cc: "John W. Linville" <linville@tuxdriver.com>
      Cc: Zhang Rui <rui.zhang@intel.com>
      Cc: Len Brown <len.brown@intel.com>
      Cc: "J. Bruce Fields" <bfields@fieldses.org>
      Cc: Johannes Berg <johannes@sipsolutions.net>
      41f63c53
  2. 15 5月, 2012 2 次提交
  3. 06 3月, 2012 1 次提交
  4. 26 2月, 2012 1 次提交
  5. 31 1月, 2012 1 次提交
  6. 28 1月, 2012 4 次提交
  7. 26 1月, 2012 1 次提交
  8. 13 1月, 2012 1 次提交
  9. 05 1月, 2012 3 次提交
  10. 06 12月, 2011 2 次提交
  11. 30 11月, 2011 1 次提交
  12. 17 11月, 2011 1 次提交
  13. 19 10月, 2011 1 次提交
  14. 11 10月, 2011 3 次提交
  15. 07 10月, 2011 3 次提交
  16. 27 8月, 2011 1 次提交
  17. 18 8月, 2011 1 次提交
  18. 27 7月, 2011 1 次提交
  19. 22 7月, 2011 1 次提交
  20. 19 7月, 2011 1 次提交
  21. 18 7月, 2011 1 次提交
  22. 25 5月, 2011 1 次提交
  23. 10 5月, 2011 1 次提交
    • R
      RDMA/iwcm: Get rid of enum iw_cm_event_status · d0c49bf3
      Roland Dreier 提交于
      The IW_CM_EVENT_STATUS_xxx values were used in only a couple of places;
      cma.c uses -Exxx values instead, and so do the amso1100, cxgb3 and cxgb4
      drivers -- only nes was using the enum values (with the mild consequence
      that all nes connection failures were treated as generic errors rather
      than reported as timeouts or rejections).
      
      We can fix this confusion by getting rid of enum iw_cm_event_status and
      using a plain int for struct iw_cm_event.status, and converting nes to
      use -Exxx as the other iWARP drivers do.
      
      This also gets rid of the warning
      
          drivers/infiniband/core/cma.c: In function 'cma_iw_handler':
          drivers/infiniband/core/cma.c:1333:3: warning: case value '4294967185' not in enumerated type 'enum iw_cm_event_status'
          drivers/infiniband/core/cma.c:1336:3: warning: case value '4294967186' not in enumerated type 'enum iw_cm_event_status'
          drivers/infiniband/core/cma.c:1332:3: warning: case value '4294967192' not in enumerated type 'enum iw_cm_event_status'
      Signed-off-by: NRoland Dreier <roland@purestorage.com>
      Reviewed-by: NSteve Wise <swise@opengridcomputing.com>
      Reviewed-by: NSean Hefty <sean.hefty@intel.com>
      Reviewed-by: NFaisal Latif <faisal.latif@intel.com>
      d0c49bf3
  24. 30 4月, 2011 1 次提交
    • D
      ethtool: cosmetic: Use ethtool ethtool_cmd_speed API · 70739497
      David Decotigny 提交于
      This updates the network drivers so that they don't access the
      ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
      instead.
      
      For most of the drivers, these changes are purely cosmetic and don't
      fix any problem, such as for those 1GbE/10GbE drivers that indirectly
      call their own ethtool get_settings()/mii_ethtool_gset(). The changes
      are meant to enforce code consistency and provide robustness with
      future larger throughputs, at the expense of a few CPU cycles for each
      ethtool operation.
      
      All drivers compiled with make allyesconfig ion x86_64 have been
      updated.
      
      Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
      Signed-off-by: NDavid Decotigny <decot@google.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      70739497
  25. 20 4月, 2011 1 次提交
  26. 31 3月, 2011 1 次提交
  27. 25 3月, 2011 1 次提交
  28. 18 3月, 2011 1 次提交
  29. 13 3月, 2011 1 次提交