1. 03 5月, 2006 2 次提交
    • C
      [PATCH] via-rhine: zero pad short packets on Rhine I ethernet cards · 3e0d167a
      Craig Brind 提交于
      Fixes Rhine I cards disclosing fragments of previously transmitted frames
      in new transmissions.
      
      Before transmission, any socket buffer (skb) shorter than the ethernet
      minimum length of 60 bytes was zero-padded.  On Rhine I cards the data can
      later be copied into an aligned transmission buffer without copying this
      padding.  This resulted in the transmission of the frame with the extra
      bytes beyond the provided content leaking the previous contents of this
      buffer on to the network.
      
      Now zero-padding is repeated in the local aligned buffer if one is used.
      
      Following a suggestion from the via-rhine maintainer, no attempt is made
      here to avoid the duplicated effort of padding the skb if it is known that
      an aligned buffer will definitely be used.  This is to make the change
      "obviously correct" and allow it to be applied to a stable kernel if
      necessary.  There is no change to the flow of control and the changes are
      only to the Rhine I code path.
      
      The patch has run on an in-service Rhine-I host without incident.  Frames
      shorter than 60 bytes are now correctly zero-padded when captured on a
      separate host.  I see no unusual stats reported by ifconfig, and no unusual
      log messages.
      Signed-off-by: NCraig Brind <craigbrind@gmail.com>
      Signed-off-by: NRoger Luethi <rl@hellgate.ch>
      Cc: Jeff Garzik <jeff@garzik.org>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      3e0d167a
    • O
      [PATCH] mv643xx_eth: provide sysfs class device symlink · b0b8dab2
      Olaf Hering 提交于
      On Sat, Mar 11, Olaf Hering wrote:
      > Why is the /sys/class/net/eth0/device symlink not created for the
      > mv643xx_eth driver? Does this work for other platform device drivers?
      > Seems to work for the ps2 keyboard at least.
      
      The SET_NETDEV_DEV has to be done before a call to register_netdev.  With
      the new patch below, the device symlink for the platform device was
      created.  Unfortunately, after the 4 ls commands, the network connection
      died.  No idea if the box crashed or if something else broke, lost remote
      access.
      
      Provide sysfs 'device' in /class/net/ethN Also, set module owner field,
      like pcnet32 driver does.
      Signed-off-by: NOlaf Hering <olh@suse.de>
      Acked-by: NDale Farnsworth <dale@farnsworth.org>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      b0b8dab2
  2. 02 5月, 2006 38 次提交