1. 20 7月, 2010 1 次提交
  2. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  3. 14 10月, 2009 1 次提交
    • T
      inifiband: Remove BKL from ipath_open() · f96d3015
      Thomas Gleixner 提交于
      cycle_kernel_lock() got pushed down to ipath_open(). I tried hard to
      understand what it might protect, but finally gave up.
      
      Roland noted that qlogic seems to have abandoned the ipath driver and
      came to the following wise conclusion: "So I guess if the BKL stuff is
      blocking you in any way, we can just drop it from ipath and leave it
      as yet another race condition in a rotting old driver."
      Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
      LKML-Reference: <adad44tj090.fsf@cisco.com>
      Cc: Roland Dreier <rdreier@cisco.com>
      f96d3015
  4. 28 9月, 2009 1 次提交
  5. 06 9月, 2009 1 次提交
  6. 30 12月, 2008 1 次提交
  7. 06 12月, 2008 2 次提交
  8. 17 10月, 2008 1 次提交
  9. 22 7月, 2008 1 次提交
  10. 21 6月, 2008 2 次提交
  11. 14 5月, 2008 1 次提交
    • P
      IB/ipath: Make ipath_portdata work with struct pid * not pid_t · 40d97692
      Pavel Emelyanov 提交于
      The official reason is "with the presence of pid namespaces in the
      kernel using pid_t-s inside one is no longer safe."
      
      But the reason I fix this right now is the following:
      
      About a month ago (when 2.6.25 was not yet released) there still was a
      one last caller of a to-be-deprecated-soon function find_pid() - the
      kill_proc() function, which in turn was only used by nfs callback
      code.
      
      During the last merge window, this last caller was finally eliminated
      by some NFS patch(es) and I was about to finally kill this kill_proc()
      and find_pid(), but found, that I was late and the kill_proc is now
      called from the ipath driver since commit 58411d1c ("IB/ipath: Head of
      Line blocking vs forward progress of user apps").
      
      So here's a patch that fixes this code to use struct pid * and (!)
      the kill_pid routine.
      Signed-off-by: NPavel Emelyanov <xemul@openvz.org>
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      40d97692
  12. 08 5月, 2008 1 次提交
    • D
      IB/ipath: Need to always request and handle PIO avail interrupts · e2ab41ca
      Dave Olson 提交于
      Now that we always use PIO for vl15 on 7220, we could get stuck forever
      if we happened to run out of PIO buffers from the verbs code, because
      the setup code wouldn't run; the interrupt was also ignored if SDMA was
      supported.  We also have to reduce the pio update threshold if we have
      fewer kernel buffers than the existing threshold.
      
      Clean up the initialization a bit to get ordering safer and more
      sensible, and use the existing ipath_chg_kernavail call to do init,
      rather than doing it separately.
      
      Drop unnecessary clearing of pio buffer on pio parity error.
      
      Drop incorrect updating of pioavailshadow when exitting freeze mode
      (software state may not match chip state if buffer has been allocated
      and not yet written).
      
      If we couldn't get a kernel buffer for a while, make sure we are
      in sync with hardware, mainly to handle the exitting freeze case.
      Signed-off-by: NDave Olson <dave.olson@qlogic.com>
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      e2ab41ca
  13. 20 4月, 2008 1 次提交
  14. 17 4月, 2008 8 次提交
  15. 26 1月, 2008 9 次提交
  16. 10 10月, 2007 2 次提交
  17. 10 7月, 2007 4 次提交
  18. 19 4月, 2007 2 次提交