1. 10 5月, 2012 1 次提交
    • T
      NFS: Prevent a deadlock in the new writeback code · 3aff4ebb
      Trond Myklebust 提交于
      We have to unlock the nfs_page before we call nfs_end_page_writeback
      to avoid races with functions that expect the page to be unlocked
      when PG_locked and PG_writeback are not set.
      The problem is that nfs_unlock_request also releases the nfs_page,
      causing a deadlock if the release of the nfs_open_context
      triggers an iput() while the PG_writeback flag is still set...
      
      The solution is to separate the unlocking and release of the nfs_page,
      so that we can do the former before nfs_end_page_writeback and the
      latter after.
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      Cc: Fred Isaman <iisaman@netapp.com>
      3aff4ebb
  2. 09 5月, 2012 3 次提交
  3. 05 5月, 2012 2 次提交
    • T
      NFS: Fix sparse warnings · 1385b811
      Trond Myklebust 提交于
      Fix the following sparse warnings:
      
      fs/nfs/direct.c:221:6: warning: symbol 'nfs_direct_readpage_release' was
      not declared. Should it be static?
      fs/nfs/read.c:38:43: warning: non-ANSI function declaration of function
      'nfs_readhdr_alloc'
      fs/nfs/objlayout/objio_osd.c:214:5: warning: symbol '__alloc_objio_seg'
      was not declared. Should it be static?
      Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      Cc: Fred Isaman <iisaman@netapp.com>
      Cc: Boaz Harrosh <bharrosh@panasas.com>
      1385b811
    • T
      NFS: Fix O_DIRECT compile warnings · bf5fc402
      Trond Myklebust 提交于
      Fix the following compile warnings:
      fs/nfs/direct.c: In function 'nfs_direct_read_schedule_segment':
      fs/nfs/direct.c:325:11: warning: comparison of distinct pointer types
      lacks a cast [enabled by default]
      fs/nfs/direct.c:325:11: warning: comparison of distinct pointer types
      lacks a cast [enabled by default]
      fs/nfs/direct.c:325:11: warning: comparison of distinct pointer types
      lacks a cast [enabled by default]
      fs/nfs/direct.c:352:27: warning: comparison of distinct pointer types
      lacks a cast [enabled by default]
      fs/nfs/direct.c: In function 'nfs_direct_write_schedule_segment':
      fs/nfs/direct.c:622:11: warning: comparison of distinct pointer types
      lacks a cast [enabled by default]
      fs/nfs/direct.c:622:11: warning: comparison of distinct pointer types
      lacks a cast [enabled by default]
      fs/nfs/direct.c:622:11: warning: comparison of distinct pointer types
      lacks a cast [enabled by default]
      fs/nfs/direct.c:650:27: warning: comparison of distinct pointer types
      lacks a cast [enabled by default]
      Reported-by: NStephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      Cc: Fred Isaman <iisaman@netapp.com>
      Cc: Stephen Rothwell <sfr@canb.auug.org.au>
      bf5fc402
  4. 02 5月, 2012 19 次提交
  5. 01 5月, 2012 8 次提交
  6. 28 4月, 2012 7 次提交