提交 · 385277bfb57faac44e92497104ba542cdd82d5fe · openanolis / cloud-kernel

09 1月, 2016 1 次提交

dm snapshot: fix hung bios when copy error occurs · 385277bf

由 Mikulas Patocka 提交于 1月 08, 2016

When there is an error copying a chunk dm-snapshot can incorrectly hold
associated bios indefinitely, resulting in hung IO.

The function copy_callback sets pe->error if there was error copying the
chunk, and then calls complete_exception.  complete_exception calls
pending_complete on error, otherwise it calls commit_exception with
commit_callback (and commit_callback calls complete_exception).

The persistent exception store (dm-snap-persistent.c) assumes that calls
to prepare_exception and commit_exception are paired.
persistent_prepare_exception increases ps->pending_count and
persistent_commit_exception decreases it.

If there is a copy error, persistent_prepare_exception is called but
persistent_commit_exception is not.  This results in the variable
ps->pending_count never returning to zero and that causes some pending
exceptions (and their associated bios) to be held forever.

Fix this by unconditionally calling commit_exception regardless of
whether the copy was successful.  A new "valid" parameter is added to
commit_exception -- when the copy fails this parameter is set to zero so
that the chunk that failed to copy (and all following chunks) is not
recorded in the snapshot store.  Also, remove commit_callback now that
it is merely a wrapper around pending_complete.
Signed-off-by: NMikulas Patocka <mpatocka@redhat.com>
Signed-off-by: NMike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org

385277bf

07 1月, 2016 1 次提交

dm thin: bump thin and thin-pool target versions · 1c2e54e1

由 Mike Snitzer 提交于 1月 06, 2016

Commit 3d5f6733 ("dm thin metadata: speed up discard of partially mapped
volumes"), or some other dm-thinp change during the Linux 4.5
development window, really should've bumped these target versions.
Signed-off-by: NMike Snitzer <snitzer@redhat.com>

1c2e54e1

18 12月, 2015 1 次提交

dm thin: fix race condition when destroying thin pool workqueue · 18d03e8c

由 Nikolay Borisov 提交于 12月 17, 2015

When a thin pool is being destroyed delayed work items are
cancelled using cancel_delayed_work(), which doesn't guarantee that on
return the delayed item isn't running.  This can cause the work item to
requeue itself on an already destroyed workqueue.  Fix this by using
cancel_delayed_work_sync() which guarantees that on return the work item
is not running anymore.

Fixes: 905e51b3 ("dm thin: commit outstanding data every second")
Fixes: 85ad643b ("dm thin: add timeout to stop out-of-data-space mode holding IO forever")
Signed-off-by: NNikolay Borisov <kernel@kyup.com>
Signed-off-by: NMike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org

18d03e8c

14 12月, 2015 1 次提交

dm space map metadata: remove unused variable in brb_pop() · 51216778

由 Mike Snitzer 提交于 12月 14, 2015

Remove the unused struct block_op pointer that was inadvertantly
introduced, via cut-and-paste of previous brb_op() code, as part of
commit 50dd842a.

(Cc'ing stable@ because commit 50dd842a did)

Fixes: 50dd842a ("dm space map metadata: fix ref counting bug when bootstrapping a new space map")
Reported-by: NDavid Binderman <dcb314@hotmail.com>
Signed-off-by: NMike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org

51216778

10 12月, 2015 18 次提交

dm verity: add ignore_zero_blocks feature · 0cc37c2d