There are several left overs with my old email address.
Remove their occurrences and add myself at CREDITS, to
allow people to be able to reach me on my new addresses.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Small changes in order to support tuner version R828D @ 16 MHz clock.
There was 'vco_fine_tune' check, which seems to adjust synthesizer
output divider (mixer dix / LO div / Rout) by one. R828D seems to
return vco_fine_tune=1 every time and that condition causes tuning
fail as output divider was increased by one.
Resolve problem by skipping whole condition in case of R828D tuner.
Just to mention, other tuner, R820T, seems to return 2 here.
Synthesizer maximum frequency check was hard coded to check synthesizer N
and thus worked correctly only for clock frequencies around 30 MHz.
As whole test is quite useless in any case, I removed it totally.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

The r820t_imr() calibration function of the Rafael Micro R820T tuner
generates this error at every tune attempt:
r820t 0-001a: No valid PLL values for 2252021 kHz!
The function was inspired by the original Realtek driver for rtl2832 devices
with the r820t tuner; anyway, in the original code the XTAL frequency of
the tuner was expressed in KHz, while in the kernel driver it is expressed
in Hz; so the calibration failed because of an out-of-range initial value.
The final result of the computation is then passed to the r820t_set_mux()
and r820t_set_pll() functions, but the conversion from KHz to Hz is already
correctly implemented.
Signed-off-by: NGianluca Gennari <gennarone@gmail.com>
Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The memcpy in shadow_store() could exceed buffer limits when r > 0.
Signed-off-by: NGianluca Gennari <gennarone@gmail.com>
Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

fe->tuner_priv and fe->ops.tuner_ops are initialized twice in r820t_attach().
Remove the redundant initializations and also move fe->ops.tuner_ops
initialization outside of the mutex lock (as in the xc4000 tuner code for example).
Signed-off-by: NGianluca Gennari <gennarone@gmail.com>
Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

fe->tuner_priv is already freed by hybrid_tuner_release_state().
Signed-off-by: NGianluca Gennari <gennarone@gmail.com>
Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Currently, the driver complains about the pre_detect var:

	drivers/media/tuners/r820t.c: In function 'r820t_sysfreq_sel':
	drivers/media/tuners/r820t.c:722:31: warning: variable 'pre_dect' set but not used [-Wunused-but-set-variable]

While rtl8232 code comments it, perhaps some other driver may use.
So, the better is to keep the code there, allowing to enable it
via r820t config data.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

drivers/media/tuners/r820t.c: In function 'r820t_imr':
 drivers/media/tuners/r820t.c:1871:8: warning: 'n_ring' may be used uninitialized in this function [-Wmaybe-uninitialized]
Mauro: This is a FALSE POSITIVE: the loop will always return a value
for n_ring, as the last test will fill it with 15, if the loop fails.
Signed-off-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

I've moved the kfree(fe->tuner_priv) one line earlier, otherwise it is
a no-op.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The test as written is always false.  It looks like the intent was to
test that the bit was not set.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The original Win driver doesn't do; rtl-sdr also disabled that
piece of the code.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

On field tests, the auto gain routine is not working, nor it is
used by the original driver. Let's comment it for now.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Currently, it is putting it on manual mode.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

The bit mask was inverted here.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

There are a few errors at the PLL calculus, causing the device
to use wrong values.
While here, change the calculus to use 32 bits, as there's no
need for 64 bits there.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

r820t_standby() can be called before r820t_init().
If that happens, just do nothing.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

The rtl-sdr library disabled IMR callibration. While I'm not sure
yet why, it could be a good idea to add a modprobe parameter here,
to allow to also disable it. There are two rationale behind it:
- It helps to compare USB dumps between rtl-sdr and the Kernel module;
- If rtl-sdr disabled it, perhaps there's a good reason (e. g. it
  might not be actually working, or it might be causing some trouble).
For both cases, it seems useful to add a modprobe parameter to allow
testing the device with both configurations.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Add the code to set the GPIO for this tuner. This code is
currently unused, so it is kept there only for completeness.
With this patch there are just two things that got left from
the original driver:
- At standby, there's another mode, not used by rtl2832u.
  Not sure if it might be needed in the future, but I suspect
  it is not used at all;
- There is a "fast tune" mode. As nor DVB or V4L API supports
  it, it seems an overkill to implement it.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

This code seems to calibrate I/Q phase and gain during the
device initialization.
This is done only once, and it doesn't seem to be needed to
happen after resuming.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

The rtl-sdr library, from where this driver was initially
based, doesn't use half PLL clock, but this is used on
the Realtek Kernel driver. So, also do the same here.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Instead of using msleep(), use sleep_range(), as it provides
a closer sleep time.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Just cosmetic changes: all other functions are prefixed
by r820t. Do the same for r820t_read().
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

As we'll need to retrieve cached registers, make this
function explicit.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

If signal is zero, shows it as a zero, not as 0xff.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

This is part of the original driver, and adding it doesn't hurt,
so add it, to better sync the code.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

As the driver's logic uses the bit-reversed order for read,
use it as well when displaying the debug messages.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

The Realtek Kernel driver uses the second DVB-T 7MHz table instead
of the first one. Use it as well.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

On read, the bit order is inverted.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

IF is set at r820t_set_tv_standard(). So, we can't calculate
LO frequency before calling it.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Scale used at get_if_freq and LO freq calculus is Hz.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

	[ 2255.342797] r820t 3-001a: generic_set_freq: PLL locked on frequency 725476191 Hz, gain=45
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

As this tuner can be used by analog and digital parts of the
driver, be sure that all ops that access the hardware will
be be properly locked.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

This tuner works with 2 modes: automatic gain mode and manual
gain mode. Put it into automatic mode, as we currently don't
have any API for manual gain adjustment.
The logic to allow setting the manual mode is there, as it is
just a few extra code. This way, if/when we latter add support
for setting the gain mode, the code is already there.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Instead of a binary signal strength measure, use the tuner gain
to obtain a better estimation of the signal strength.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

This driver was written from scratch, based on an existing driver
that it is part of rtl-sdr git tree, released under GPLv2:
	https://groups.google.com/forum/#!topic/ultra-cheap-sdr/Y3rBEOFtHug
	https://github.com/n1gp/gr-baz
	http://cgit.osmocom.org/rtl-sdr/plain/src/tuner_r820t.c
	(there are also other variants of it out there)
>From what I understood from the threads, the original driver was converted
to userspace from a Realtek tree. I couldn't find the original tree.
However, the original driver look awkward on my eyes. So, I decided to
write a new version from it from the scratch, while trying to reproduce
everything found there.
TODO:
- After locking, the original driver seems to have some routines to
  improve reception. This was not implemented here yet.
- RF Gain set/get is not implemented.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>