1. 02 8月, 2010 4 次提交
  2. 28 7月, 2010 1 次提交
  3. 17 7月, 2010 2 次提交
    • S
      ceph: do not include cap/dentry releases in replayed messages · e979cf50
      Sage Weil 提交于
      Strip the cap and dentry releases from replayed messages.  They can
      cause the shared state to get out of sync because they were generated
      (with the request message) earlier, and no longer reflect the current
      client state.
      Signed-off-by: NSage Weil <sage@newdream.net>
      e979cf50
    • S
      ceph: reuse request message when replaying against recovering mds · 01a92f17
      Sage Weil 提交于
      Replayed rename operations (after an mds failure/recovery) were broken
      because the request paths were regenerated from the dentry names, which
      get mangled when d_move() is called.
      
      Instead, resend the previous request message when replaying completed
      operations.  Just make sure the REPLAY flag is set and the target ino is
      filled in.
      
      This fixes problems with workloads doing renames when the MDS restarts,
      where the rename operation appears to succeed, but on mds restart then
      fails (leading to client confusion, app breakage, etc.).
      Signed-off-by: NSage Weil <sage@newdream.net>
      01a92f17
  4. 22 6月, 2010 1 次提交
    • S
      ceph: delay umount until all mds requests drop inode+dentry refs · 17c688c3
      Sage Weil 提交于
      This fixes a race between handle_reply finishing an mds request, signalling
      completion, and then dropping the request structing and its dentry+inode
      refs, and pre_umount function waiting for requests to finish before
      letting the vfs tear down the dcache.  If umount was delayed waiting for
      mds requests, we could race and BUG in shrink_dcache_for_umount_subtree
      because of a slow dput.
      
      This delays umount until the msgr queue flushes, which means handle_reply
      will exit and will have dropped the ceph_mds_request struct.  I'm assuming
      the VFS has already ensured that its calls have all completed and those
      request refs have thus been dropped as well (I haven't seen that race, at
      least).
      Signed-off-by: NSage Weil <sage@newdream.net>
      17c688c3
  5. 11 6月, 2010 2 次提交
  6. 05 6月, 2010 1 次提交
  7. 30 5月, 2010 3 次提交
    • S
      ceph: clean up on forwarded aborted mds request · 2a8e5e36
      Sage Weil 提交于
      If an mds request is aborted (timeout, SIGKILL), it is left registered to
      keep our state in sync with the mds.  If we get a forward notification,
      though, we know the request didn't succeed and we can unregister it
      safely.  We were trying to resend it, but then bailing out (and not
      unregistering) in __do_request.
      Signed-off-by: NSage Weil <sage@newdream.net>
      2a8e5e36
    • S
      ceph: make lease code DN specific · dd1c9057
      Sage Weil 提交于
      The lease code includes a mask in the CEPH_LOCK_* namespace, but that
      namespace is changing, and only one mask (formerly _DN == 1) is used, so
      hard code for that value for now.
      
      If we ever extend this code to handle leases over different data types we
      can extend it accordingly.
      Signed-off-by: NSage Weil <sage@newdream.net>
      dd1c9057
    • S
      ceph: make mds requests killable, not interruptible · aa91647c
      Sage Weil 提交于
      The underlying problem is that many mds requests can't be restarted.  For
      example, a restarted create() would return -EEXIST if the original request
      succeeds.  However, we do not want a hung MDS to hang the client too.  So,
      use the _killable wait_for_completion variants to abort on SIGKILL but
      nothing else.
      Signed-off-by: NSage Weil <sage@newdream.net>
      aa91647c
  8. 22 5月, 2010 1 次提交
  9. 18 5月, 2010 18 次提交
  10. 12 5月, 2010 2 次提交
    • S
      ceph: fix cap removal races · f818a736
      Sage Weil 提交于
      The iterate_session_caps helper traverses the session caps list and tries
      to grab an inode reference.  However, the __ceph_remove_cap was clearing
      the inode backpointer _before_ removing itself from the session list,
      causing a null pointer dereference.
      
      Clear cap->ci under protection of s_cap_lock to avoid the race, and to
      tightly couple the list and backpointer state.  Use a local flag to
      indicate whether we are releasing the cap, as cap->session may be modified
      by a racing thread in iterate_session_caps.
      Signed-off-by: NSage Weil <sage@newdream.net>
      f818a736
    • S
      ceph: fix locking for waking session requests after reconnect · 9abf82b8
      Sage Weil 提交于
      The session->s_waiting list is protected by mdsc->mutex, not s_mutex.  This
      was causing (rare) s_waiting list corruption.
      
      Fix errors paths too, while we're here.  A more thorough cleanup of this
      function is coming soon.
      Signed-off-by: NSage Weil <sage@newdream.net>
      9abf82b8
  11. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  12. 29 3月, 2010 1 次提交
  13. 23 3月, 2010 3 次提交