1. 07 7月, 2014 3 次提交
    • A
      perf hists browser: Override ui_browser refresh_dimensions method · 357cfff1
      Arnaldo Carvalho de Melo 提交于
      This requires some more work so that we can really just use the width of
      current entries when we want to partition the screen.
      
      Right now its just a prep patch so that we can have where to update
      ui_browser->rows when introducing the column headers line, that will be
      togglable, so we need to update it everytime we refresh the dimensions
      of the browser.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Don Zickus <dzickus@redhat.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-ovk654rx525b4657y0mh6ku9@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      357cfff1
    • A
      perf hists browser: Introduce gotorc method · ca3ff33b
      Arnaldo Carvalho de Melo 提交于
      That will allow us to add a row offset to open up space for the column
      headers.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Don Zickus <dzickus@redhat.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-otc3ployokfci5qi81o7jo22@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      ca3ff33b
    • A
      perf ui browser: Add ->rows to disambiguate from ->height · 62c95ae3
      Arnaldo Carvalho de Melo 提交于
      The ui_browser->height is about the whole browser "window", including
      any header, status lines or any other space needed for some "Yes", "No",
      etc buttons a descendent browser, like hist_browser, may have.
      
      Since the navigation is done mostly on the ui_browser methods, it needs
      to know how many rows are on the screen, while details about what other
      components are, say, if a header (that may be composed of multiple
      lines, etc) is present.
      
      Besides this we'll need to add a ui_browser->refresh_dimensions() hook
      so that browsers like hist_browser can update ->rows in response to
      screen resizes, this will come in a follow up patch.
      
      This patch just adds ->rows and updates it when updating ->height, keeps
      using ->height for the only other widget that can come with ui_browser,
      the scrollbar, that goes on using all the height on the rightmost column
      in the screen, using ->rows for the keyboard navigation needs.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Don Zickus <dzickus@redhat.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-xexmwg1mv7u03j5imn66jdak@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      62c95ae3
  2. 20 6月, 2014 2 次提交
  3. 04 6月, 2014 1 次提交
    • J
      perf tools: Move elide bool into perf_hpp_fmt struct · f2998422
      Jiri Olsa 提交于
      After output/sort fields refactoring, it's expensive
      to check the elide bool in its current location inside
      the 'struct sort_entry'.
      
      The perf_hpp__should_skip function gets highly noticable in
      workloads with high number of output/sort fields, like for:
      
        $ perf report -i perf-test.data -F overhead,sample,period,comm,pid,dso,symbol,cpu --stdio
      
      Performance report:
         9.70%  perf  [.] perf_hpp__should_skip
      
      Moving the elide bool into the 'struct perf_hpp_fmt', which
      makes the perf_hpp__should_skip just single struct read.
      
      Got speedup of around 22% for my test perf.data workload.
      The change should not harm any other workload types.
      
      Performance counter stats for (10 runs):
        before:
         358,319,732,626      cycles                    ( +-  0.55% )
         467,129,581,515      instructions              #    1.30  insns per cycle          ( +-  0.00% )
      
           150.943975206 seconds time elapsed           ( +-  0.62% )
      
        now:
         278,785,972,990      cycles                    ( +-  0.12% )
         370,146,797,640      instructions              #    1.33  insns per cycle          ( +-  0.00% )
      
           116.416670507 seconds time elapsed           ( +-  0.31% )
      Acked-by: NNamhyung Kim <namhyung@kernel.org>
      Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
      Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/r/20140601142622.GA9131@krava.brq.redhat.comSigned-off-by: NJiri Olsa <jolsa@kernel.org>
      f2998422
  4. 01 6月, 2014 2 次提交
  5. 21 5月, 2014 5 次提交
  6. 24 4月, 2014 4 次提交
  7. 16 4月, 2014 2 次提交
  8. 15 3月, 2014 1 次提交
  9. 13 1月, 2014 1 次提交
  10. 28 12月, 2013 2 次提交
  11. 26 12月, 2013 2 次提交
  12. 15 11月, 2013 2 次提交
  13. 06 11月, 2013 1 次提交
  14. 04 11月, 2013 1 次提交
  15. 13 7月, 2013 3 次提交
  16. 28 5月, 2013 4 次提交
  17. 01 4月, 2013 1 次提交
  18. 16 3月, 2013 2 次提交
  19. 07 2月, 2013 1 次提交