Use ACPI_FAILURE() to replace !ACPI_SUCCESS(), this avoid !! operations.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Acked-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Reviewed-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>

The second call to acpi_remove_notify_handler does not result in panic
or generate error messages, but it is unnecessary and the function
returns with an error. Remove the duplicate call. Correct two improperly
indented lines.
Signed-off-by: NAlex Hung <alex.hung@canonical.com>
Signed-off-by: NDarren Hart <dvhart@linux.intel.com>

This is the same as the original workaround from S3 but for S4.  Without
this workaround, a rfkill event will be received and it will toggle
wireless devices when radio hotkey is not pressed.
Signed-off-by: NAlex Hung <alex.hung@canonical.com>
Signed-off-by: NDarren Hart <dvhart@linux.intel.com>

We want the size of the struct, not of a pointer to it. To be future
proof, just dereference the pointer to get the desired type.
Signed-off-by: NWolfram Sang <wsa@the-dreams.de>
Signed-off-by: NDarren Hart <dvhart@linux.intel.com>

intel_hid_keymap contains a duplicate entry for KEY_HOME and an
incorrect HID index for KEY_PAGEDOWN
Reported-by: NPavel Bludov <pbludov@gmail.com>
Signed-off-by: NAlex Hung <alex.hung@canonical.com>

This driver supports various HID events including hotkeys.
Dell XPS 13 9350 requires it for the wireless hotkey.
Signed-off-by: NAlex Hung <alex.hung@canonical.com>
Reviewed-and-tested-by: NAndy Lutomirski <luto@kernel.org>

[dvhart: Kconfig help typo fix and INPUT_SPARSEKMAP fix from Sedat Dilek]
Signed-off-by: NDarren Hart <dvhart@linux.intel.com>