- 23 9月, 2016 7 次提交
-
-
由 Ivan Safonov 提交于
rf_type is always equal to ODM_1T1R. So, only RF PATH A exists for r8188eu device... Signed-off-by: NIvan Safonov <insafonov@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Ivan Safonov 提交于
rf_type is always equal to RF_1T1R. Signed-off-by: NIvan Safonov <insafonov@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Georgiana Rodica Chelu 提交于
The checkpatch.pl found the warning: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Checked if the the Ethernet addresses are __aligned(2) by using pahole tool. The type of pwlanhdr is struct ieee80211_hdr and pahole shows that addr1, addr2, and addr3 are aligned to u16. struct ieee80211_hdr { __le16 frame_control; /* 0 2 */ __le16 duration_id; /* 2 2 */ u8 addr1[6]; /* 4 6 */ u8 addr2[6]; /* 10 6 */ u8 addr3[6]; /* 16 6 */ __le16 seq_ctrl; /* 22 2 */ u8 addr4[6]; /* 24 6 */ /* size: 30, cachelines: 1, members: 7 */ /* last cacheline: 30 bytes */ }; Both eeprompriv from struct adapter and MacAddress from struct wlan_bssid_ex have the offset multiple of sizeof(u16). Also, the array bc_addr and the pointers: StaAddr, mac, and bssid, start from an even offset. Signed-off-by: NGeorgiana Rodica Chelu <georgiana.chelu93@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Juliana Rodrigues 提交于
Removed variables used only for return purposes and replaced them for the return value itself. Found using Coccinelle's semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: NJuliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Juliana Rodrigues 提交于
Removed an unecessary blank line after open brace, fixing a checkpatch issue. Signed-off-by: NJuliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Eva Rachel Retuya 提交于
Declare the 'arche_apb_ctrl_of_match' array as const. This array is only stored in the .of_match_table field of a device_driver structure, which is declared as const. This addresses the checkpatch warning: WARNING: struct of_device_id should be normally const Signed-off-by: NEva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Eva Rachel Retuya 提交于
Declare the arrays 'arche_platform_of_match' and 'arche_combined_id' as const. 'arche_platform_of_match' is only stored in the .of_match_table field of a device_driver structure, which is declared as const. 'arche_combined_id' is passed to MODULE_DEVICE_TABLE. This macro does not modify the array and therefore the array can be declared as const. Checkpatch pointed out both issues. WARNING: struct of_device_id should be normally const Signed-off-by: NEva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 22 9月, 2016 26 次提交
-
-
由 Sandhya Bankar 提交于
This issue was found by checkpatch. Signed-off-by: NSandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Sandhya Bankar 提交于
This patch was found by checkpatch. Signed-off-by: NSandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Rehas Sachdeva 提交于
Move the test to check if a variable is NULL, to right after it is being assigned, rather than some statements later. Signed-off-by: NRehas Sachdeva <aquannie@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 sayli karnik 提交于
This patch removes an unnecessary variable used to store return values in order to reduce memory usage. Done using coccinelle: @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret return - ret + C ; Signed-off-by: Nsayli karnik <karniksayli1995@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Rehas Sachdeva 提交于
Remove 'x=a;' from a consecutive double assignment of the form 'x=a; x=b;'. Issue detected by the semantic patch found here: https://github.com/coccinelle/coccinellery/blob/master/write2/write2.cocciSigned-off-by: NRehas Sachdeva <aquannie@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Yannis Damigos 提交于
This patch fixes multiple black lines issue found by checkpatch.pl Signed-off-by: NYannis Damigos <giannis.damigos@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Rehas Sachdeva 提交于
Remove unnecessary parentheses from right side of an assignment. Issue detected by the following Coccinelle semantic patch: @r@ identifier x; expression e1, e2; @@ - x = (e1 << e2); + x = e1 << e2; Signed-off-by: NRehas Sachdeva <aquannie@gmail.com> Acked-by: NJulia Lawall <julia.lawall@lip6.fr> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Rehas Sachdeva 提交于
Replaces left shift operation (1 << d) by BIT(x) macro. Signed-off-by: NRehas Sachdeva <aquannie@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Rehas Sachdeva 提交于
Setting the variable 'refresh_rate = 60;' has no use to the rest of the function. Hence the if statement setting it and the variable itself can be removed. This was detected using the following Coccinelle semantic patch: @@ type T; identifier i; constant C; @@ ( extern T i; | - T i; <+... when != i - i = C; ...+> ) Signed-off-by: NRehas Sachdeva <aquannie@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Katie Dunne 提交于
Issue found by checkpatch. Signed-off-by: NKatie Dunne <kdunne@mail.ccsf.edu> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Lin 提交于
Add myself as greybus uart and log protocol driver maintainer. Signed-off-by: NDavid Lin <dtwlin@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Chaehyun Lim 提交于
Fixes checkpatch.pl warning: CHECK: Alignment should match open parenthesis Signed-off-by: NChaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Chaehyun Lim 提交于
Fixes checkpatch.pl warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: NChaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Richard Groux 提交于
Minor error spotted by checkpatch.pl in greybus code indent should use tabs where possible Signed-off-by: NRichard Groux <rgroux@sauron-mordor.net> Reviewed-by: NAlex Elder <elder@linaro.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Richard Groux 提交于
Minor error spotted by checkpatch.pl in greybus space required before the open brace '{' Signed-off-by: NRichard Groux <rgroux@sauron-mordor.net> Reviewed-by: NAlex Elder <elder@linaro.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Eva Rachel Retuya 提交于
Modify return statement to use the value being returned directly instead of assigning it first to 'ret' and returning this variable. Coccinelle semantic patch used: @@ expression e; local idexpression ret; @@ -ret = +return e; -return ret; Signed-off-by: NEva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Eva Rachel Retuya 提交于
Eliminate unneeded parentheses around the right hand side of an assignment. Coccinelle semantic patch used: @@ expression e1, e2; identifier v; @@ ( v = (e1 == e2) | v = (e1 != e2) | v = (e1 <= e2) | v = (e1 >= e2) | v = - ( e1 - ) ) Signed-off-by: NEva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Eva Rachel Retuya 提交于
Replace direct comparisons to NULL i.e. 'x == NULL' with '!x' for consistency. Coccinelle semantic patch used: @@ identifier func; expression x; statement Z; @@ x = func(...); if ( ( + ! x - == NULL | + ! - NULL == x ) ) Z Signed-off-by: NEva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Andrey Shvetsov 提交于
This patch replaces the enum value MOST_CH_ISOC_AVP with the more appropriate MOST_CH_ISOC. Signed-off-by: NAndrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by: NChristian Gromm <christian.gromm@microchip.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Christian Gromm 提交于
This patch adds the strings 'rx', 'tx' and 'isoc' to the list of accepted identifiers when setting up a channel configuration. To keep consistency it removes the prefix "dir_" from strings returned by the attributes set_direction and available_directions and it removes the suffix "_avp" from the string "isoc_avp" returned by the attributes set_datatype and available_datatypes. Signed-off-by: NChristian Gromm <christian.gromm@microchip.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Andrey Shvetsov 提交于
This patch removes trailing zeros from the strings returned by the attributes available_datatypes and available_directions. Signed-off-by: NAndrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by: NChristian Gromm <christian.gromm@microchip.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Christian Gromm 提交于
Function most_submit_mbo() causes an exception only if either the pointer mbo or mbo->context equals NULL. From the underlying architecture's point of view both cases must _not_ come true and would happen only, if something has tampered with the pointers. This would render runtime code unable to recover anyway. So, instead trying to hide that things are already critically out of control we're better off with a WARN_ON() assertion. This patch replaces the return type of the function most_submit_mbo() with 'void' and adds a WARN_ONCE() assertion. Additionally, code calling the function is adapted accordingly. Signed-off-by: NChristian Gromm <christian.gromm@microchip.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Juliana Rodrigues 提交于
This patch fixes a checkpatch warning in a block comment by adapting it to the community preferred coding style. Signed-off-by: NJuliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Juliana Rodrigues 提交于
This patch fixes a checkpatch warning by moving arguments to the right and aligning them to their open parenthesis. Signed-off-by: NJuliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Juliana Rodrigues 提交于
This patch fixes a checkpatch warning by moving arguments to the right and aligning them to the open parenthesis above. Signed-off-by: NJuliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Juliana Rodrigues 提交于
Moved trailing */ to a new line and added * to subsequent lines on a block comment. Signed-off-by: NJuliana Rodrigues <juliana.orod@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 21 9月, 2016 7 次提交
-
-
由 Vaibhav Hiremath 提交于
Add Vaibhav Hiremath as a Maintainer of Greybus platform drivers. Signed-off-by: NVaibhav Hiremath <hvaibhav.linux@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Greg Kroah-Hartman 提交于
CONFIG_MEDIA is not a thing, but CONFIG_MEDIA_SUPPORT is, so use that. Reported-by: NValentin Rothberg <valentinrothberg@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The inline ULTRA_CHANNELCLI_STRING is not being used so remove it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NTim Sell <Timothy.Sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The function spar_channel_client_release_os is not being used so remove it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NTim Sell <Timothy.Sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The function spar_channel_client_acquire_os is not being used so remove it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NTim Sell <Timothy.Sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
The function pathname_last_n_nodes is not used, get rid of it. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NTim Sell <Timothy.Sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 David Kershner 提交于
Remove not needed prototypes in visorhba. Signed-off-by: NDavid Kershner <david.kershner@unisys.com> Reviewed-by: NTim Sell <Timothy.Sell@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-