We don't want to bind to the ES1 device, that would be bad.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Fix three related memory leaks in the init an exit callbacks, where the
gpio-lines array was never freed at all and the controller data wasn't
freed in the init error path.
Signed-off-by: NJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Adds gpio interrupt handling support using an irqchip/irqdomain
instantiation inside the GB GPIO driver. This implementation works
on older kernels such as 3.10 that do not have the gpiolib irqchip
helpers. Any line on a Greybus gpiochip may be configured as an
interrupt. Once configured, IRQ event messages received from a
module fire off the registered interrupt handler.
Signed-off-by: NMatt Porter <mporter@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Make sure to release the spin lock protecting the interface bundle lists
before tearing down the connections and removing the bundle device,
which are operations that may sleep.
Signed-off-by: NJohan Hovold <johan@hovoldconsulting.com>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Use GFP_ATOMIC for IDA memory allocations under spin lock, which must
not sleep.
Signed-off-by: NJohan Hovold <johan@hovoldconsulting.com>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Export gb_operation_response_send() for other modules
Signed-off-by: NMatt Porter <mporter@linaro.org>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Signed-off-by: NViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

- Fixed incorrect use of $$GREYBUS_SRC_PATH variable
- Added quotes around find pattern to stop shell expansion of "*"
Signed-off-by: NMichael Scott <michael.scott@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Signed-off-by: NViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

When initializing the USB device, we were starting up the svc message
queue before the cport urbs were allocated.  This might not be an issue
for "slower" machines, but not having any allocated urbs for a cport
might be an issue if we were to handle svc messages.

So wait until everything is properly initialized and allocated before
starting the svc urb.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

SVC messages come in in an "order", so don't mess them up by processing
them out of order.  Fix this by making our work queue ordered, which
should keep everything in line.
Reported-by: NPerry Hung <perry@leaflabs.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

We now have several modules generated by the greybus build.
Let's add any *.ko files we find to the buid.
Signed-off-by: NMichael Scott <michael.scott@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Make sure destination for greybus modules is consistent and easier to maintain
Signed-off-by: NMichael Scott <michael.scott@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

This reverts commit 241b5fefc54eae95239b0f7dc4e2b0db49457729 as it's
wrong, we want to insert into the correct place in the list.
Reported-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

This reverts commit 57131bf309d34568dd3b8f8e9da7a7ba25e9495e, it isn't
going to be needed as the patch this fixes will be reverted.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

'gb_i2c_transfer_request' is the name given to a function and a struct. Though
we don't get any compilation errors/warnings about it, but the names should be
unique.
Signed-off-by: NViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

'gb_i2c_transfer_response' is the name given to a function and a struct. Though
we don't get any compilation errors/warnings about it, but the names should be
unique.
Signed-off-by: NViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

__gb_protocol_register check if the protocol is not already registred,
and then register it. It register in existing->lists but at this point,
existing is always NULL (we exist just before if not).
Use gb_protocols instead.
Signed-off-by: NAlexandre Bailon <abailon@baylibre.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

These aren't used anymore and so can be removed.
Signed-off-by: NViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

This gets rid of lots of duplication of code.
Signed-off-by: NViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Request type for all other protocols is defined like: GB_<protocol>_TYPE_<operation>,
but for UART is like: GB_<protocol>_REQ_<operation>.

Replace REQ with TYPE to make it consistent. It will also be useful in a later
patch that creates get_version() routines with the help of a macro.
Signed-off-by: NViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Some files are still prefixed with "gb-" with the reasoning that the modules
would be named so, i.e.  gb-*.ko. But this can be done by playing a bit in
Makefile instead and keep uniform naming of .c files.

Lets try it.
Signed-off-by: NViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Some files are prefixed with "gb-" and some are suffixed with "-gb". The
rationale behind the first one is that the modules would be named so, i.e.
gb-*.ko. But there is no reason to keep the "-gb" suffix in the second case.

Remove the unnecessary suffix.
Signed-off-by: NViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

This is just a copy of ES1 for now, things will start to diverge soon.
Any common functionality will be factored out over time.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

In next_free_urb(), just return usb_alloc_urb(), don't waste the time
assigning it to a local variable that we then return.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

in protocol register replace the protocol find code with the call to the already
existing function.
Signed-off-by: NRui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

if error is return when submiting the urb, we need to make sure to release the
urb from the pool, or from the dinamicly allocated. As in it, factor out the free
code and create the free_urb function.
Signed-off-by: NRui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

just return the result of usb_alloc_urb up, no need to rededunt check for NULL
Signed-off-by: NRui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

An extra reference is taken out on an operation in
gb_operation_request_send(). If the response never arrives, we need to
put back the reference.
Signed-off-by: NPerry Hung <perry@leaflabs.com>
Tested-by: NMitchell Tasman <tasman@leaflabs.com>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

If an operation is issued and the response never comes back,
gb_operation_timeout() cancels the operation but never wakes up the
waiter in gb_operation_request_send().

This patch removes the timeout workqueue and changes the request wait to
wait_for_completion_interruptible_timeout(), with timeout set to
OPERATION_TIMEOUT_DEFAULT.
Signed-off-by: NPerry Hung <perry@leaflabs.com>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

offset is defined as unsigned so there is no point checking for
negative values of offset.
Signed-off-by: NBill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Signed-off-by: NBill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

val is an unsigned long so there is no point in checking if it is less
than zero.
Signed-off-by: NBill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

This .c file isn't needed by the kernel driver, it's there for firmware
developers only, so just move it into the Documentation directory to
reduce confusion.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Use the "gb-" prefix for the ES1 Host controller driver.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Use the "gb" prefix for module names, not a suffix.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Use the "gb" prefix for module names, not a suffix.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

This module provides the Bridged PHY protocols, so name the thing
properly.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Provide an install Makefile target for those that want to install the
kernel modules.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

--
v3: resend to list, somehow this thread got taken private and v2 never
    made it there.

v2: add -a option to depmod, thanks to Mitchell

The data_in_size variable was set to 1 for the status byte.
But now, the status byte has move to header. Then, the status byte
is "allocated" twice and cause bad message size error.
Signed-off-by: NAlexandre Bailon <abailon@baylibre.com>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>