1. 12 10月, 2013 1 次提交
  2. 29 7月, 2013 3 次提交
  3. 18 3月, 2013 2 次提交
  4. 08 3月, 2013 1 次提交
  5. 07 9月, 2012 1 次提交
    • P
      usb: dwc3: ep0: correct cache sync issue in case of ep0_bounced · 0416e494
      Pratyush Anand 提交于
      In case of ep0 out, if length is not aligned to maxpacket size then we use
      dwc->ep_bounce_addr for dma transfer and not request->dma. Since, we have
      alreday done memcpy from dwc->ep0_bounce to request->buf, so we do not need to
      issue cache sync function. In fact, cache sync function will bring wrong data
      in request->buf from request->dma in this scenario.
      
      So, cache sync function must not be executed in case of ep0 bounced.
      
      Cc: <stable@vger.kernel.org> # v3.4 v3.5
      Signed-off-by: NPratyush Anand <pratyush.anand@st.com>
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      0416e494
  6. 03 8月, 2012 8 次提交
    • F
      usb: dwc3: ep0: make sure to reinitilize ep1 on STALL · 2dfe37d4
      Felipe Balbi 提交于
      When issuing SetStall on ep0, we must make sure to
      reinitialize all flags on physical ep1 too.
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      2dfe37d4
    • F
      usb: dwc3: ep0: fix status phase delayed status direction · 7125d584
      Felipe Balbi 提交于
      commit 68d3e668 (usb: dwc3: ep0: fix for possible early
      delayed_status) added handling for early delayed status,
      but the current code only works because so far delayed
      status will always be on the IN direction.
      
      This patch makes the code more robust by making sure that
      we can handle all directions properly.
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      7125d584
    • F
      usb: dwc3: ep0: drop XferNotReady(DATA) support · 2e3db064
      Felipe Balbi 提交于
      Due to the late Silicon limitation found, we are
      now pre-starting DATA phase's TRBs. If, still, we
      get XferNotReady(DATA) we will ignore it unless
      we're getting it for the wrong direction.
      
      In that case we must keep the error case handling
      plus add a ENDTRANSFER command to forcefully end
      the Data TRB we started previously, then continue
      to SetStall and so on.
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      2e3db064
    • F
      usb: dwc3: ep0: move DATA phase away from on-demand · fca8892a
      Felipe Balbi 提交于
      We uncovered a limitation of this core WRT to the
      Link Layer Compliance Suite's TD7.06.
      
      On that test, host will start a GetDescriptor(DEVICE)
      standard request, but it will do so only on the
      SETUP phase, meaning there will *NOT* be any DATA or
      STATUS phases.
      
      The idea of the test is to verify robustness of the
      IP WRT framing errors, so the test will send a
      sequence of different SETUP_DPs each with a different
      framing error and the Suite expects us to be able to
      receive all SETUP_DPs with no timeouts.
      
      This core, has the ability to tell us which phase the
      host is expecting before we start it. Whenever we
      receive a TP or DP when no transfers are cached on
      the internal IP's caches, the IP will generate a
      XferNotReady event with status informing us (in case
      of physical ep0/ep1) if it's related to DATA or STATUS
      phases - SETUP phase is expected to be prestarted.
      
      Because we're always waiting for XferNotReady
      events for DATA and STATUS phases, we will never
      be able to know that the Host wants to start another
      SETUP phase instead, which will render us "not
      compliant" with TD7.06.
      
      In order to "fix" the problem we must not rely
      on XferNotReady events for the DATA phase  and try
      to always pre-start DATA transfers on physical
      endpoints 0 and 1. If host goes back to SETUP phase
      from DATA phase we will receive a XferComplete for
      that phase with TRB's status set to SETUP_PENDING,
      which is only useful for printing a debugging log as
      the core expects us to still go through to the STATUS
      phase, initiate a CONTROL_STATUS TRB just so it
      completes right away and, only then, we go back to
      the pending SETUP phase.
      
      SNPS has decided to modify the programming model of
      the core so that on-demand DATA phases will not be
      supported anymore. Note that this limitation does not
      affect 2-stage transfers, meaning that if TD7.06 would
      start a 2-stage transfer instead of a 3-stage transfer,
      we would receive a "fake" XferNotReady(STATUS) which
      would complete right after being initiated with
      SETUP_PENDING status.
      
      Other endpoints are also not affected, so we can still
      use on-demand transfers on Bulk/Isoc/Interrupt endpoints.
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      fca8892a
    • F
      usb: dwc3: ep0: ignore XferNotReady(STATUS) when we're not expecting it · 77fa6df8
      Felipe Balbi 提交于
      Databook doesn't say we should stall if we
      get XferNotReady(STATUS) while we're expecting
      something else.
      
      Instead of stalling and restarting, tests have
      proven that ignoring the event is far more
      effective.
      
      This problem has been caught while rewriting
      ep0 handling in order we pass Link Layer TD7.6.
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      77fa6df8
    • F
      usb: dwc3: ep0: drop dead code · 4635d3f2
      Felipe Balbi 提交于
      There's no such thing as XferNotReady(SETUP), we
      can safely drop all that code with no problems
      whatsoever.
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      4635d3f2
    • F
      usb: dwc3: ep0: split the special cases on ep0_queue · d9b33c60
      Felipe Balbi 提交于
      We can return early from each if () branch
      and split the special cases for clarity. While
      at that also add a comment to the delayed_status
      case.
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      d9b33c60
    • F
      usb: dwc3: ep0: drop unnecessary variable · 35f75696
      Felipe Balbi 提交于
      When returning from ep0_queue, we have an
      unnecessary ret variable which is always
      zero. Remove it.
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      35f75696
  7. 02 7月, 2012 2 次提交
  8. 26 6月, 2012 1 次提交
  9. 25 6月, 2012 1 次提交
  10. 04 6月, 2012 8 次提交
  11. 04 5月, 2012 1 次提交
  12. 02 5月, 2012 2 次提交
  13. 30 4月, 2012 1 次提交
  14. 11 4月, 2012 1 次提交
  15. 10 4月, 2012 2 次提交
  16. 02 3月, 2012 2 次提交
  17. 28 2月, 2012 1 次提交
    • F
      usb: dwc3: gadget: use generic map/unmap routines · 0fc9a1be
      Felipe Balbi 提交于
      those routines have everything we need to map/unmap
      USB requests and it's better to use them.
      
      In order to achieve that, we had to add a simple
      change on how we allocate and use our setup buffer;
      we cannot allocate it from coherent anymore otherwise
      the generic map/unmap routines won't be able to easily
      know that the GetStatus request already has a DMA
      address.
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      0fc9a1be
  18. 13 2月, 2012 1 次提交
    • F
      usb: dwc3: convert TRBs into bitshifts · f6bafc6a
      Felipe Balbi 提交于
      this will get rid of a useless memcpy on
      IRQ handling, thus improving driver performance.
      
      Tested with OMAP5430 running g_mass_storage on
      SuperSpeed and HighSpeed.
      
      Note that we are removing the little endian access
      of the TRB and all accesses will be in System endianness,
      if there happens to be a system in BE, bit 12 of GSBUSCFG0
      should be set so that HW does byte invariant BE accesses
      when fetching TRBs.
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      f6bafc6a
  19. 10 2月, 2012 1 次提交
    • G
      usb: dwc3: ep0: fix SetFeature(TEST) · 3b637367
      Gerard Cauvy 提交于
      When host requests us to enter a test mode,
      we cannot directly enter the test mode before
      Status Phase is completed, otherwise the core
      will never be able to deliver the Status ZLP
      to host, because it has already entered the
      requested Test Mode.
      
      In order to fix the error, we move the actual
      start of Test Mode right after we receive
      Transfer Complete event of the status phase.
      Signed-off-by: NGerard Cauvy <g-cauvy1@ti.com>
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      3b637367