Skip to content

cloud-kernel
cloud-kernel

openanolis / cloud-kernel
接近 2 年 前同步成功

通知 170
Star 36
Fork 7
cloud-kernel
cloud-kernel
切换分支/标签
  1. 01 11月, 2012 9 次提交
  3. 23 10月, 2012 1 次提交
    • J
      net/macb: fix truncate warnings · 95ebcea6
      由 Joachim Eastwood 提交于 
      When building macb on x86_64 the following warnings show up:
  drivers/net/ethernet/cadence/macb.c: In function macb_interrupt:
  drivers/net/ethernet/cadence/macb.c:556:4: warning: large integer implicitly truncated to unsigned type [-Woverflow]
  drivers/net/ethernet/cadence/macb.c: In function macb_reset_hw:
  drivers/net/ethernet/cadence/macb.c:792:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
  drivers/net/ethernet/cadence/macb.c:793:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
  drivers/net/ethernet/cadence/macb.c:796:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]

Use -1 insted of ~0UL, as done in other places in the driver,
to silence these warnings.
Signed-off-by: NJoachim Eastwood <manabian@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      95ebcea6
  5. 20 10月, 2012 2 次提交
  7. 09 7月, 2012 1 次提交
  9. 04 4月, 2012 1 次提交
  11. 16 2月, 2012 1 次提交
  13. 07 2月, 2012 1 次提交
  15. 01 2月, 2012 1 次提交
  17. 11 1月, 2012 1 次提交
  19. 22 12月, 2011 1 次提交
    • O
      net: macb: fix build break with !CONFIG_OF · b17471f5
      由 Olof Johansson 提交于 
      This fixes the build of the macb driver that was broken by the DT changes:

drivers/net/ethernet/cadence/macb.c:1503: error: implicit declaration of function 'of_match_ptr'
drivers/net/ethernet/cadence/macb.c:1503: error: 'macb_dt_ids' undeclared here (not in a function)
drivers/net/ethernet/cadence/macb.c:1503: error: initializer element is not constant
drivers/net/ethernet/cadence/macb.c:1503: error: (near initialization for 'macb_driver.driver.of_match_table')
Signed-off-by: NOlof Johansson <olof@lixom.net>
Acked-by: NNicolas Ferre <nicolas.ferre@atmel.com>
      b17471f5
  21. 16 12月, 2011 1 次提交
  23. 22 11月, 2011 8 次提交
  25. 18 8月, 2011 1 次提交
  27. 13 8月, 2011 1 次提交
  29. 04 8月, 2011 1 次提交
  31. 21 6月, 2011 1 次提交
  33. 10 6月, 2011 1 次提交
  35. 07 6月, 2011 1 次提交
  37. 19 5月, 2011 1 次提交
  39. 14 4月, 2011 1 次提交
  41. 31 3月, 2011 1 次提交
    • J
      drivers/net: Remove IRQF_SAMPLE_RANDOM flag from network drivers · ab392d2d
      由 Javier Martinez Canillas 提交于 
      The IRQF_SAMPLE_RANDOM flag is marked as deprecated and will be removed.

Every input point to the kernel's entropy pool have to better document the
type of entropy source it is.

drivers/char/random.c now implements a set of interfaces that can be used for
devices to collect enviromental noise. IRQF_SAMPLE_RANDOM will be replaced
with these add_*_randomness exported functions.

Network drivers are not a good source of entropy. They use as a source of
entropy essentially a remote host. Which means that the source of entropy can
be potentially controlled by an attacker. Also, with heavy workloads the
entropy decreases due to less hardware interrupts happening thanks to irq
mitigation and NAPI.

If a system relies in its network interface as a entropy source it has a false
sense of security. Systems that don't have devices whose drivers are good
sources of entropy, should either use a hardware random number generator or
feed the kernel's entropy pool from userspace using other sources of entropy
such as EGD, video_entropyd, timer_entropyd and audio-entropyd.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      ab392d2d
  43. 01 3月, 2011 1 次提交
    • J
      macb: don't use platform_set_drvdata() on a net_device · 91523947
      由 Jamie Iles 提交于 
      Commit 71d64290 (Driver core: convert platform_{get,set}_drvdata to
static inline functions) now triggers a warning in the macb network
driver:

  CC      drivers/net/macb.o
drivers/net/macb.c: In function ‘macb_mii_init’:
drivers/net/macb.c:263: warning: passing argument 1 of ‘platform_set_drvdata’ from incompatible pointer type
include/linux/platform_device.h:138: note: expected ‘struct platform_device *’ but argument is of type ‘struct net_device *’

Use dev_set_drvdata() on the device embedded in the net_device instead.

Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: NJamie Iles <jamie@jamieiles.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      91523947
  45. 26 10月, 2010 1 次提交
    • J
      macb: Don't re-enable interrupts while in polling mode · b336369c
      由 Joshua Hoke 提交于 
      On a busy network, the macb driver could get stuck in the interrupt
handler, quickly triggering the watchdog, due to a confluence of
factors:

 1. macb_poll re-enables interrupts unconditionally, even when it will
    be called again because it exhausted its rx budget

 2. macb_interrupt only disables interrupts after scheduling
    macb_poll, but scheduling fails when macb_poll is already scheduled
    because it didn't call napi_complete

 3. macb_interrupt loops until the interrupt status register is clear,
    which will never happen in this case if the driver doesn't disable
    the RX interrupt

Since macb_interrupt runs in interrupt context, this effectively locks
up the machine, triggering the hardware watchdog.

This issue was readily reproducible on a flooded network with a
modified 2.6.27.48 kernel. The same problem appears to still be in the
2.6.36-rc8 driver code, so I am submitting this patch against that
version. I have not tested this version of the patch except to make
sure the kernel compiles.
Signed-off-by: NJoshua Hoke <joshua.hoke@sixnet.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b336369c
  47. 03 9月, 2010 1 次提交