1. 01 9月, 2009 1 次提交
  2. 06 8月, 2009 1 次提交
  3. 04 8月, 2009 1 次提交
    • J
      3c59x: Fix build failure with gcc 3.2 · 0cb13536
      Jean Delvare 提交于
      Fix the following build failure with gcc 3.2:
      
        CC [M]  drivers/net/3c59x.o
      drivers/net/3c59x.c:2726:1: directives may not be used inside a macro argument
      drivers/net/3c59x.c:2725:59: unterminated argument list invoking macro "pr_err"
      drivers/net/3c59x.c: In function `dump_tx_ring':
      drivers/net/3c59x.c:2727: implicit declaration of function `pr_err'
      drivers/net/3c59x.c:2731: syntax error before ')' token
      
      Apparently gcc 3.2 doesn't like #if interleaved with a macro call.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      0cb13536
  4. 06 7月, 2009 1 次提交
  5. 13 6月, 2009 1 次提交
  6. 27 5月, 2009 1 次提交
  7. 27 2月, 2009 1 次提交
  8. 22 1月, 2009 1 次提交
  9. 11 1月, 2009 1 次提交
  10. 13 11月, 2008 1 次提交
    • W
      netdevice: safe convert to netdev_priv() #part-1 · 454d7c9b
      Wang Chen 提交于
      We have some reasons to kill netdev->priv:
      1. netdev->priv is equal to netdev_priv().
      2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
         netdev_priv() is more flexible than netdev->priv.
      But we cann't kill netdev->priv, because so many drivers reference to it
      directly.
      
      This patch is a safe convert for netdev->priv to netdev_priv(netdev).
      Since all of the netdev->priv is only for read.
      But it is too big to be sent in one mail.
      I split it to 4 parts and make every part smaller than 100,000 bytes,
      which is max size allowed by vger.
      Signed-off-by: NWang Chen <wangchen@cn.fujitsu.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      454d7c9b
  11. 11 11月, 2008 1 次提交
  12. 04 11月, 2008 1 次提交
  13. 28 10月, 2008 1 次提交
  14. 16 10月, 2008 1 次提交
  15. 07 8月, 2008 1 次提交
  16. 22 7月, 2008 1 次提交
  17. 27 6月, 2008 1 次提交
    • I
      [netdrvr] 3c59x: remove irqs_disabled warning from local_bh_enable · c5643cab
      Ingo Molnar 提交于
      Original Author: Michael Buesch <mb@bu3sch.de>
      
      net, vortex: fix lockup
      
      Ingo Molnar reported:
      
      -tip testing found that Johannes Berg's "softirq: remove irqs_disabled
      warning from local_bh_enable" enhancement to lockdep triggers a new
      warning on an old testbox that uses 3c59x vortex and netlogging:
      
      ----->
          calling  vortex_init+0x0/0xb0
          PCI: Found IRQ 10 for device 0000:00:0b.0
          PCI: Sharing IRQ 10 with 0000:00:0a.0
          PCI: Sharing IRQ 10 with 0000:00:0b.1
          3c59x: Donald Becker and others.
          0000:00:0b.0: 3Com PCI 3c556 Laptop Tornado at e0800400.
          PCI: Enabling bus mastering for device 0000:00:0b.0
          initcall vortex_init+0x0/0xb0 returned 0 after 47 msecs
      ...
          calling  init_netconsole+0x0/0x1b0
          netconsole: local port 4444
          netconsole: local IP 10.0.1.9
          netconsole: interface eth0
          netconsole: remote port 4444
          netconsole: remote IP 10.0.1.16
          netconsole: remote ethernet address 00:19:xx:xx:xx:xx
          netconsole: device eth0 not up yet, forcing it
          eth0:  setting half-duplex.
          eth0:  setting full-duplex.
      ------------[ cut here ]------------
          WARNING: at kernel/softirq.c:137 local_bh_enable_ip+0xd1/0xe0()
          Pid: 1, comm: swapper Not tainted 2.6.26-rc6-tip #2091
           [<c0125ecf>] warn_on_slowpath+0x4f/0x70
           [<c0126834>] ? release_console_sem+0x1b4/0x1d0
           [<c0126d00>] ? vprintk+0x2a0/0x450
           [<c012fde5>] ? __mod_timer+0xa5/0xc0
           [<c046f7fd>] ? mdio_sync+0x3d/0x50
           [<c0160ef6>] ? marker_probe_cb+0x46/0xa0
           [<c0126ed7>] ? printk+0x27/0x50
           [<c046f4c3>] ? vortex_set_duplex+0x43/0xc0
           [<c046f521>] ? vortex_set_duplex+0xa1/0xc0
           [<c0471b92>] ? vortex_timer+0xe2/0x3e0
           [<c012b361>] local_bh_enable_ip+0xd1/0xe0
           [<c08d9f9f>] _spin_unlock_bh+0x2f/0x40
           [<c0471b92>] vortex_timer+0xe2/0x3e0
           [<c014743b>] ? trace_hardirqs_on+0xb/0x10
           [<c0147358>] ? trace_hardirqs_on_caller+0x88/0x160
           [<c012f8b2>] run_timer_softirq+0x162/0x1c0
           [<c0471ab0>] ? vortex_timer+0x0/0x3e0
           [<c012b361>] local_bh_enable_ip+0xd1/0xe0
           [<c08d9f9f>] _spin_unlock_bh+0x2f/0x40
           [<c0471b92>] vortex_timer+0xe2/0x3e0
           [<c014743b>] ? trace_hardirqs_on+0xb/0x10
           [<c0147358>] ? trace_hardirqs_on_caller+0x88/0x160
           [<c012f8b2>] run_timer_softirq+0x162/0x1c0
           [<c0471ab0>] ? vortex_timer+0x0/0x3e0
           [<c0471ab0>] ? vortex_timer+0x0/0x3e0
           [<c012b60a>] __do_softirq+0x9a/0x160
           [<c012b570>] ? __do_softirq+0x0/0x160
           [<c0106775>] call_on_stack+0x15/0x30
           [<c012b4f5>] ? irq_exit+0x55/0x60
           [<c0106e85>] ? do_IRQ+0x85/0xd0
           [<c0147391>] ? trace_hardirqs_on_caller+0xc1/0x160
           [<c0104888>] ? common_interrupt+0x28/0x30
           [<c08d8ac8>] ? mutex_unlock+0x8/0x10
           [<c08d8180>] ? _cond_resched+0x10/0x30
           [<c07a3be7>] ? netpoll_setup+0x117/0x390
           [<c0cbfcfe>] ? init_netconsole+0x14e/0x1b0
           [<c013d539>] ? ktime_get+0x19/0x40
           [<c0c9bab2>] ? kernel_init+0x1b2/0x2c0
           [<c0cbfbb0>] ? init_netconsole+0x0/0x1b0
           [<c0396aa4>] ? trace_hardirqs_on_thunk+0xc/0x10
           [<c0103f12>] ? restore_nocheck_notrace+0x0/0xe
           [<c0c9b900>] ? kernel_init+0x0/0x2c0
           [<c0c9b900>] ? kernel_init+0x0/0x2c0
           [<c0104aa7>] ? kernel_thread_helper+0x7/0x10
           =======================
      ---[ end trace 37f9c502aff112e0 ]---
          console [netcon0] enabled
          netconsole: network logging started
          initcall init_netconsole+0x0/0x1b0 returned 0 after 2914 msecs
      
      looking at the driver I think the bug is real and the fix actually
      is trivial.
      
      vp->lock is also taken in hardware IRQ context, so we _have_ to always
      use irqsafe locking. As we run in a timer with IRQs disabled,
      we can simply use spin_lock.
      
      Cc: <stable@kernel.org>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      c5643cab
  18. 07 5月, 2008 2 次提交
  19. 18 10月, 2007 1 次提交
  20. 17 10月, 2007 1 次提交
  21. 11 10月, 2007 5 次提交
  22. 14 8月, 2007 1 次提交
  23. 01 8月, 2007 1 次提交
  24. 11 7月, 2007 1 次提交
  25. 09 5月, 2007 1 次提交
  26. 26 4月, 2007 1 次提交
  27. 10 3月, 2007 1 次提交
    • R
      3c59x: Fix several modpost warnings · 95c408a9
      Ralf Baechle 提交于
      WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x4580) and 'vortex_eisa_remove'
      WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x4584) and 'vortex_eisa_remove'
      WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x4588) and 'vortex_eisa_remove'
      WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x458c) and 'vortex_eisa_remove'
      
      Fixed by:
      
       o move definition of vortex_eisa_driver below the functions it references.
       o remove now unnecessary prototypes for vortex_eisa_probe and
         vortex_eisa_remove.
       o Make vortex_eisa_probe an __init function.
       o Make vortex_eisa_remove a __devexit function.
       o Wrap vortex_eisa_driver reference to vortex_eisa_remove with
         __devexit_p().
      Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      
       drivers/net/3c59x.c |   28 +++++++++++++---------------
       1 file changed, 13 insertions(+), 15 deletions(-)
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      95c408a9
  28. 06 3月, 2007 1 次提交
  29. 07 2月, 2007 1 次提交
  30. 05 10月, 2006 1 次提交
    • D
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells 提交于
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: NDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  31. 27 9月, 2006 1 次提交
    • M
      [PATCH] EISA bus MODALIAS attributes support · 07563c71
      Michael Tokarev 提交于
      Add modalias attribute support for the almost forgotten now EISA bus and
      (at least some) EISA-aware modules.
      
      The modalias entry looks like (for an 3c509 NIC):
      
       eisa:sTCM5093
      
      and the in-module alias like:
      
       eisa:sTCM5093*
      
      The patch moves struct eisa_device_id declaration from include/linux/eisa.h
      to include/linux/mod_devicetable.h (so that the former now #includes the
      latter), adds proper MODULE_DEVICE_TABLE(eisa, ...) statements for all
      drivers with EISA IDs I found (some drivers already have that DEVICE_TABLE
      declared), and adds recognision of __mod_eisa_device_table to
      scripts/mod/file2alias.c so that proper modules.alias will be generated.
      
      There's no support for /lib/modules/$kver/modules.eisamap, as it's not used
      by any existing tools, and because with in-kernel modalias mechanism those
      maps are obsolete anyway.
      
      The rationale for this patch is:
      
       a) to make EISA bus to act as other busses with modalias
          support, to unify driver loading
      
       b) to foget about EISA finally - with this patch, kernel
          (who still supports EISA) will be the only one who knows
          how to choose the necessary drivers for this bus ;)
      
      [akpm@osdl.org: fix the kbuild bit]
      Signed-off-by: NMichael Tokarev <mjt@tls.msk.ru>
      Cc: Rusty Russell <rusty@rustcorp.com.au>
      Cc: Randy Dunlap <rdunlap@xenotime.net>
      Acked-the-net-bits-by: NJeff Garzik <jeff@garzik.org>
      Acked-the-tulip-bit-by: NValerie Henson <val_henson@linux.intel.com>
      Cc: James Bottomley <James.Bottomley@steeleye.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      07563c71
  32. 23 9月, 2006 1 次提交
  33. 14 9月, 2006 2 次提交
  34. 12 9月, 2006 1 次提交
    • A
      [PATCH] Remove more unnecessary driver printk's · d5b20697
      Andy Gospodarek 提交于
      As I promised last week, here is the first pass at removing all
      unnecessary printk's that exist in network device drivers currently in
      promiscuous mode.  The duplicate messages are not needed so they have
      been removed.  Some of these drivers are quite old and might not need an
      update, but I did them all anyway.
      
      I am currently auditing the remaining conditional printk's and will send
      out a patch for those soon.
      Signed-off-by: NAndy Gospodarek <andy@greyhouse.net>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      d5b20697