提交 · 24c667db59a9cc4caaafe4f77f6f4ef85899a454 · openanolis / cloud-kernel

24 10月, 2007 40 次提交

[CCID2/3]: Initialisation assignments of 0 are redundant · 24c667db

由 Gerrit Renker 提交于 10月 24, 2007

Assigning initial values of `0' is redundant when loading a new CCID structure,
since in net/dccp/ccid.c the entire CCID structure is zeroed out prior to
initialisation in ccid_new():

    	struct ccid {
    		struct ccid_operations *ccid_ops;
    		char		       ccid_priv[0];
    	};

    	// ...
    	if (rx) {
    		memset(ccid + 1, 0, ccid_ops->ccid_hc_rx_obj_size);
    		if (ccid->ccid_ops->ccid_hc_rx_init != NULL &&
    		    ccid->ccid_ops->ccid_hc_rx_init(ccid, sk) != 0)
    			goto out_free_ccid;
    	} else {
    		memset(ccid + 1, 0, ccid_ops->ccid_hc_tx_obj_size);
    		/* analogous to the rx case */
    	}

This patch therefore removes the redundant assignments. Thanks to Arnaldo for
the inspiration.
Signed-off-by: NGerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: NIan McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>

24c667db

[DCCP]: Unaligned pointer access · 76fd1e87

由 Gerrit Renker 提交于 10月 24, 2007

This fixes `unaligned (read) access' errors of the type

Kernel unaligned access at TPC[100f970c] dccp_parse_options+0x4f4/0x7e0 [dccp]
Kernel unaligned access at TPC[1011f2e4] ccid3_hc_tx_parse_options+0x1ac/0x380 [dccp_ccid3]
Kernel unaligned access at TPC[100f9898] dccp_parse_options+0x680/0x880 [dccp]

by using the get_unaligned macro for parsing options.

Commiter note: Preserved the sparse __be{16,32} annotations.
Signed-off-by: NGerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: NIan McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>

76fd1e87

[DCCP]: Convert Reset code into socket error number · d8ef2c29

由 Gerrit Renker 提交于 10月 24, 2007

This adds support for converting the 11 currently defined Reset codes into system
error numbers, which are stored in sk_err for further interpretation.

This makes the externally visible API behaviour similar to TCP, since a client
connecting to a non-existing port will experience ECONNREFUSED.

* Code 0, Unspecified, is interpreted as non-error (0);
* Code 1, Closed (normal termination), also maps into 0;
* Code 2, Aborted, maps into "Connection reset by peer" (ECONNRESET);
* Code 3, No Connection and
  Code 7, Connection Refused, map into "Connection refused" (ECONNREFUSED);
* Code 4, Packet Error, maps into "No message of desired type" (ENOMSG);
* Code 5, Option Error, maps into "Illegal byte sequence" (EILSEQ);
* Code 6, Mandatory Error, maps into "Operation not supported on transport endpoint" (EOPNOTSUPP);
* Code 8, Bad Service Code, maps into "Invalid request code" (EBADRQC);
* Code 9, Too Busy, maps into "Too many users" (EUSERS);
* Code 10, Bad Init Cookie, maps into "Invalid request descriptor" (EBADR);
* Code 11, Aggression Penalty, maps into "Quota exceeded" (EDQUOT)
  which makes sense in terms of using more than the `fair share' of bandwidth.
Signed-off-by: NGerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: NIan McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>

d8ef2c29

[DCCP]: One more exemption from full sequence number checks · 1238d087

由 Gerrit Renker 提交于 10月 24, 2007

This fixes the following problem: client connects to peer which has no DCCP
enabled or loaded; ICMP error messages ("Protocol Unavailable") can be seen
on the wire, but the application hangs. Reason: ICMP packets don't get through
to dccp_v4_err.

When reporting errors, a sequence number check is made for the DCCP packet
that had caused an ICMP error to arrive.
Such checks can not be made if the socket is in state LISTEN, RESPOND (which
in the implementation is the same as LISTEN), or REQUEST, since update_gsr()
has not been called in these states, hence the sequence window is 0..0.

This patch fixes the problem by adding the REQUEST state as another exemption
to the window check. The error reporting now works as expected on connecting.
Signed-off-by: NGerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: NIan McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: NArnaldo Carvalho de Melo <acme@ghostprotocols.net>

1238d087

[DCCP]: Retrieve packet sequence number for error reporting · fde20105

由 Gerrit Renker 提交于 10月 24, 2007

This fixes a problem when analysing erroneous packets in dccp_v{4,6}_err:
* dccp_hdr_seq currently takes an skb
* however, the transport headers in the skb are shifted, due to the
  preceding IPv4/v6 header.
Fixed for v4 and v6 by changing dccp_hdr_seq to take a struct dccp_hdr as
argument. Verified that the correct sequence number is now reported in the
error handler.
Signed-off-by: NGerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: NIan McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>

fde20105

[IPV4]: Explicitly call fib_get_table() in fib_frontend.c · 03cf786c

由 Pavel Emelyanov 提交于 10月 23, 2007

In case the "multiple tables" config option is y, the ip_fib_local_table
is not a variable, but a macro, that calls fib_get_table(RT_TABLE_LOCAL).

Some code uses this "variable" *3* times in one place, thus implicitly
making 3 calls. Fix it.
Signed-off-by: NPavel Emelyanov <xemul@openvz.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

03cf786c

[NET]: Use BUILD_BUG_ON in net/core/flowi.c · f0fe91de

由 Pavel Emelyanov 提交于 10月 23, 2007

Instead of ugly extern not-existing function.
Signed-off-by: NPavel Emelyanov <xemul@openvz.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

f0fe91de

[NET]: Remove in-code externs for some functions from net/core/dev.c · 342709ef

由 Pavel Emelyanov 提交于 10月 23, 2007

Inconsistent prototype and real type for functions may have worse
consequences, than those for variables, so move them into a header.

Since they are used privately in net/core, make this file reside in
the same place.
Signed-off-by: NPavel Emelyanov <xemul@openvz.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

342709ef

[NET]: Don't declare extern variables in net/core/sysctl_net_core.c · a37ae408

由 Pavel Emelyanov 提交于 10月 23, 2007

Some are already declared in include/linux/netdevice.h, while
some others (xfrm ones) need to be declared.

The driver/net/rrunner.c just uses same extern as well, so
cleanup it also.
Signed-off-by: NPavel Emelyanov <xemul@openvz.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

a37ae408

[TCP]: Remove unneeded implicit type cast when calling tcp_minshall_update() · c1bd24b7

由 Chuck Lever 提交于 10月 23, 2007

The tcp_minshall_update() function is called in exactly one place, and is
passed an unsigned integer for the mss_len argument.  Make the sign of the
argument match the sign of the passed variable in order to eliminate an
unneeded implicit type cast and a mixed sign comparison in
tcp_minshall_update().
Signed-off-by: NChuck Lever <chuck.lever@oracle.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

c1bd24b7

[NET]: Treat the sign of the result of skb_headroom() consistently · c2636b4d

由 Chuck Lever 提交于 10月 23, 2007

In some places, the result of skb_headroom() is compared to an unsigned
integer, and in others, the result is compared to a signed integer.  Make
the comparisons consistent and correct.
Signed-off-by: NChuck Lever <chuck.lever@oracle.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

c2636b4d

R
[9P]: Fix missing unlock before return in p9_mux_poll_start · 0ffdd581
由 Roel Kluin 提交于 10月 23, 2007
```
Signed-off-by: NRoel Kluin <12o3l@tiscali.nl>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
```
0ffdd581

[PKT_SCHED]: Fix sch_prio.c build with CONFIG_NETDEVICES_MULTIQUEUE · 00346226

由 Pavel Emelyanov 提交于 10月 23, 2007

Fix one more user of netiff_subqueue_stopped. To check for the
queue id one must use the __netiff_subqueue_stoped call.

This run out of my sight when I made the:

668f895a
[NET]: Hide the queue_mapping field inside netif_subqueue_stopped

commit :(
Signed-off-by: NPavel Emelyanov <xemul@openvz.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

00346226

[IPV4] ip_gre: sendto/recvfrom NBMA address · 6a5f44d7

由 Timo Teras 提交于 10月 23, 2007

When GRE tunnel is in NBMA mode, this patch allows an application to use
a PF_PACKET socket to:
- send a packet to specific NBMA address with sendto()
- use recvfrom() to receive packet and check which NBMA address it came from

This is required to implement properly NHRP over GRE tunnel.
Signed-off-by: NTimo Teras <timo.teras@iki.fi>
Acked-by: NAlexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

6a5f44d7

[SCTP]: Consolidate sctp_ulpq_renege_xxx functions · 16d14ef9

由 Pavel Emelyanov 提交于 10月 23, 2007

Both are equal, except for the list to be traversed.
Signed-off-by: NPavel Emelyanov <xemul@openvz.org>
Acked-by: NVlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

16d14ef9

[NETLINK]: Fix ACK processing after netlink_dump_start · 5c58298c

由 Denis V. Lunev 提交于 10月 23, 2007

Revert to original netlink behavior. Do not reply with ACK if the
netlink dump has bees successfully started.

libnl has been broken by the cd40b7d3
The following command reproduce the problem:
   /nl-route-get 192.168.1.1
Signed-off-by: NDenis V. Lunev <den@openvz.org>
Acked-by: NThomas Graf <tgraf@suug.ch>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

5c58298c

[VLAN]: MAINTAINERS update · be7f8273

由 Patrick McHardy 提交于 10月 23, 2007

Ben stepped down from VLAN maintainership due to a lack of time, add
myself as new maintainer.
Signed-off-by: NPatrick McHardy <kaber@trash.net>
Acked-by: NBen Greear <greearb@candelatech.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

be7f8273

[DCCP]: Implement SIOCINQ/FIONREAD · 6273172e

由 Arnaldo Carvalho de Melo 提交于 10月 23, 2007

Just like UDP.
Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: NLeandro Melo de Sales <leandroal@gmail.com>
Signed-off-by: NIan McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

6273172e

[NET]: Validate device addr prior to interface-up · bada339b

由 Jeff Garzik 提交于 10月 23, 2007

Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

bada339b

Linux 2.6.24-rc1 · c9927c2b

由 Linus Torvalds 提交于 10月 23, 2007

The patch is big.  Really big.  You just won't believe how vastly hugely
mindbogglingly big it is.  I mean you may think it's a long way down the
road to the chemist, but that's just peanuts to how big the patch from
2.6.23 is.

But it's all good.
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

c9927c2b

add port definition for mcf UART driver · f0c15f48