Driver was checking for direct mode but not locking it.  Use
claim/release helper functions to guarantee the device stays
in direct mode during required raw read cases.
Signed-off-by: NAlison Schofield <amsfield22@gmail.com>
Acked-by: NPeter Meerwald-Stadler <pmeerw@pmeerw.net>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Now the driver is in a reasonable state, lets get it (finally) out
of staging.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Basic tidy up of comments to bring them into a standard style.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Tidied up where checkpatch warning suppressions doesn't effect the
readability of the code.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Previously the device was exposed to userspace and in kernel consumers
before the interrupts had been configured. As nothing stopped them being
enabled in the interval this could cause unhandled interrupts.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

There seems little point in being able to query the part revision number
via sysfs.  Hence just put it in the kernel logs during probe incase
anyone ever wants to know.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

This is now represented by the standard 3db filter frequency controls.
Things get complex wrt to the sampling frequency as these modes change
but that is fine under the IIO ABI where any value is allowed to effect
any other.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Also includes an available attribute.  The ordering of values appears
a bit random, but as the ABI doesn't specify this and we already have
both rising and falling lists I think this is fine.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Given the introduction of IIO_NO_MOD was prior to the first submission
prior to IIO entering staging this has been broken for a while.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Driving towards getting rid of the non standard mode control interface.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Introduce some more masks and generally drive towards consistent naming.
Note the small indents used to indicate parts of registers + parts of
multiplexed registers.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

This is an approach used in some newer drivers as it exposes the
compound channel events to the core rather than hiding their control
in sysfs attributes entirely via the driver.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

In a similar fashion to other newer drivers (e.g. ti_am335x), instead
of using the hardware buffer support in IIO to directly access the hardware
fifo, insert a software fifo and feed that from the hardware one when
interrupts occur.  This gives a simpler structure to the data flows and
allows more flexibility over how often data is shipped to userspace etc.

This was also the only direct user of the simplistic generalization found
in ring_hw.h so that header is removed.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

For now we support only the 50% watershed interrupt and start and stop it
as part of the buffer bring up.  The 75% case may come back in future.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Not clearing the stuff_to_read flag can lead to a false flag being set
on restarting the buffer if the data was not all read the previous time.

The size of the scan is needed to ensure the function
iio_buffer_read_first_n_outer actually tries to read the data.

This stuff has been broken for some time so not stable material.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

This was needed when the buffer support was optional. Pointless wrapper
now so drop it.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

In the early days of IIO we were much more inclined to keep the impact
of the core IIO elements to the minimum.  As time has moved on it has
become clear that hardly any builds are done without buffer support
and that it adds considerable complexity to the drivers.

Hence merge down the buffer and non buffer elements of the sca3000 driver
also allowing us to drop the header file used for the interfaces between
the two.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>

Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Add ABI documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8,
2012) about the infrared suppression that can be controlled
with the proximity_on_chip_ambient_infrared_suppression sysfs attribute.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Driver was checking for direct mode but not locking it.  Use
claim/release helper functions to guarantee the device stays
in direct mode during raw reads.
Signed-off-by: NAlison Schofield <amsfield22@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Driver was checking for direct mode but not locking it.  Use
claim/release helper functions to guarantee the device stays
in direct mode during all write raw operations.
Signed-off-by: NAlison Schofield <amsfield22@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Driver was checking for direct mode but not locking it.  Use
claim/release helper functions to guarantee the device stays
in direct mode during raw reads.
Signed-off-by: NAlison Schofield <amsfield22@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

If attribute/s is/are already enabled (by default or via scripts or
manual interaction), issuing -a will fail to enable the channels thereby
one has to manually disable the said attribute/s before proceeding with
auto-enabling.

Add a command-line option -A to force-activate all channels regardless
of their current state.
Suggested-by: NAlison Schofield <amsfield22@gmail.com>
Signed-off-by: NEva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Use a standard framework to get the reference voltage. It is done that way
in the iio subsystem and it will simplify extending of the driver.

Structure mcp4725_platform_data is left undeleted because it used in the
next patch.

This change breaks the current users of the driver, but there is no
mainline user of struct mcp4725_platform_data.
Signed-off-by: NTomas Novotny <tomas@novotny.cz>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Change in handling of the regulator description means that static
checkers correctly assume we could be using dereferenced pointer to the
regulator. In reality we will never get the -ENODEV error, as current
behavior flow does not predict it, because:
If the device tree or board file does not define suitable regulators for
the component, it will be substituted by a dummy regulator, or, if
regulators are disabled altogether, by stubs.
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Suggested-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NCrt Mori <cmo@melexis.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The "drivers/" part of the path name was missing.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

There is a type mismatch between the buffer which is of type s16 and the
samples stored, which are declared as __le16.

Fix the following sparse warning:
drivers/iio/imu/bmi160/bmi160_core.c:411:26: warning: incorrect type
in assignment (different base types)

drivers/iio/imu/bmi160/bmi160_core.c:411:26: expected signed short
[signed] [short] [explicitly-signed] <noident>
drivers/iio/imu/bmi160/bmi160_core.c:411:26: got restricted __le16
[addressable] [usertype] sample

This is a cosmetic-type patch since it does not alter code behaviour.
The le16 is going into a 16bit buf element, and is labelled as IIO_LE in the
channel buffer definition.
Signed-off-by: Nsayli karnik <karniksayli1995@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Rename description from "ISL 29018" to "Intersil 29018" in Kconfig for
consistency with other drivers in mainline.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Remove blank line between MODULE_DEVICE_TABLE() and its corresponding
structure for consistency with the other device table entries.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Use the return value from isl29018_set_integration_time() as the return
value for isl29018_chip_init() since this is the last piece of work
inside that function.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Change multiline comments from:

/* line1
 * line2
 * ...
 */

to

/*
 * line1
 * line2
 * ...
 */
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

isl29035_detect() did not just do chip detection. Move functionality directly
into isl29018_chip_init() to avoid naming confusion.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Add newlines to improve code readability in preparation for moving the
driver out of staging.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

There is still stuff to be done in the remaining drivers but pretty much
nothing was left from this original TODO.

Sorry Greg, should have been keeping this up to date.
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
Acked-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

mlock is intended to protect only switches between modes.
Given this driver doesn't support more than one mode (sysfs polled reads
only), replace mlock with a local mutex lock.
Signed-off-by: Nsayli karnik <karniksayli1995@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This driver predates the availability of IIO_CHAN_INFO_SAMP_FREQ
attribute wherein usage has some advantages like it can be accessed by
in-kernel consumers as well as reduces the code size.

Therefore, use IIO_CHAN_INFO_SAMP_FREQ to implement the
sampling_frequency attribute instead of using IIO_DEVICE_ATTR() macro.

Move code from the functions associated with IIO_DEVICE_ATTR() into
respective read and write hooks with the mask set to
IIO_CHAN_INFO_SAMP_FREQ.
Signed-off-by: NEva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Attributes that were once privately defined become standard with time
and hence a special global define is used. Hence update driver ad7152 to use
IIO_CHAN_INFO_SAMP_FREQ which is a global define instead of
IIO_DEV_ATTR_SAMP_FREQ.
Move functionality from IIO_DEV_ATTR_SAMP_FREQ attribute into
IIO_CHAN_INFO_SAMP_FREQ to implement the sampling_frequency attribute.
Modify ad7152_read_raw() and ad7152_write_raw() to allow reading and
writing the element as well. Also add a lock in the driver's private
data.
Signed-off-by: Nsayli karnik <karniksayli1995@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Add documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8, 2012)
about the infrared suppression that can be controlled
with the proximity_on_chip_ambient_infrared_suppression sysfs attribute.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>