1. 03 9月, 2017 1 次提交
    • W
      ALSA: hda: Fix regression of hdmi eld control created based on invalid pcm · 1f7f51a6
      Wang YanQing 提交于
      Commit fb087eaa ("ALSA: hda - hdmi eld control created based on pcm")
      forget to filter out invalid pcm numbers, if there is only one invalid pcm
      number, then this issue causes we create eld control for invalid pcm silently,
      but when there are more than one invalid pcm numbers, then this issue bring
      probe error looks like below dmesg:
      "
      kernel: [    1.647283] snd_hda_intel 0000:00:03.0: bound 0000:00:02.0 (ops 0xc2967540)
      kernel: [    1.651192] snd_hda_intel 0000:00:03.0: Too many HDMI devices
      kernel: [    1.651195] snd_hda_intel 0000:00:03.0: Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y
      kernel: [    1.651197] snd_hda_intel 0000:00:03.0: Too many HDMI devices
      kernel: [    1.651199] snd_hda_intel 0000:00:03.0: Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y
      kernel: [    1.651201] snd_hda_intel 0000:00:03.0: Too many HDMI devices
      kernel: [    1.651203] snd_hda_intel 0000:00:03.0: Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y
      kernel: [    1.651676] snd_hda_intel 0000:00:03.0: control 3:0:0:ELD:0 is already present
      kernel: [    1.651787] snd_hda_codec_hdmi: probe of hdaudioC0D0 failed with error -16
      "
      
      This patch add invalid pcm number filter before calling hdmi_create_eld_ctl.
      
      Fixes: fb087eaa ("ALSA: hda - hdmi eld control created based on pcm")
      Signed-off-by: NWang YanQing <udknight@gmail.com>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      1f7f51a6
  2. 31 8月, 2017 1 次提交
  3. 30 8月, 2017 1 次提交
    • T
      ALSA: pcm: Fix power lock unbalance via OSS emulation · bcab3a6e
      Takashi Iwai 提交于
      PCM OSS emulation issues the drain ioctl without power lock.  It used
      to work in the earlier kernels as the power lock was taken inside
      snd_pcm_drain() itself.  But since 68b4acd3 ("ALSA: pcm: Apply
      power lock globally to common ioctls"), the power lock is taken
      outside the function.  Due to that change, the call via OSS emulation
      leads to the unbalanced power lock, thus it deadlocks.
      
      As a quick fix, just take the power lock before snd_pcm_drain() call
      for OSS emulation path.  A better cleanup will follow later.
      
      Fixes: 68b4acd3 ("ALSA: pcm: Apply power lock globally to common ioctls")
      Reported-and-tested-by: NMarkus Trippelsdorf <markus@trippelsdorf.de>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      bcab3a6e
  4. 25 8月, 2017 1 次提交
    • T
      ASoC: rt5677: Reintroduce I2C device IDs · 9ce76511
      Tom Rini 提交于
      Not all devices with ACPI and this combination of sound devices will
      have the required information provided via ACPI.  Reintroduce the I2C
      device ID to restore sound functionality on on the Chromebook 'Samus'
      model.
      
      [ More background note:
       the commit a36afb0a ("ASoC: rt5677: Introduce proper table...")
       moved the i2c ID probed via ACPI ("RT5677CE:00") to a proper
       acpi_device_id table.  Although the action itself is correct per se,
       the overseen issue is the reference id->driver_data at
       rt5677_i2c_probe() for retrieving the corresponding chip model for
       the given id.  Since id=NULL is passed for ACPI matching case, we get
       an Oops now.
      
       We already have queued more fixes for 4.14 and they already address
       the issue, but they are bigger changes that aren't preferable for the
       late 4.13-rc stage.  So, this patch just papers over the bug as a
       once-off quick fix for a particular ACPI matching.  -- tiwai ]
      
      Fixes: a36afb0a ("ASoC: rt5677: Introduce proper table for ACPI enumeration")
      Signed-off-by: NTom Rini <trini@konsulko.com>
      Acked-by: NMark Brown <broonie@kernel.org>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      9ce76511
  5. 23 8月, 2017 1 次提交
  6. 22 8月, 2017 3 次提交
  7. 20 8月, 2017 2 次提交
  8. 18 8月, 2017 2 次提交
  9. 17 8月, 2017 1 次提交
  10. 15 8月, 2017 2 次提交
    • T
      ALSA: usb-audio: Apply sample rate quirk to Sennheiser headset · a8e800fe
      Takashi Iwai 提交于
      A Senheisser headset requires the typical sample-rate quirk for
      avoiding spurious errors from inquiring the current sample rate like:
       usb 1-1: 2:1: cannot get freq at ep 0x4
       usb 1-1: 3:1: cannot get freq at ep 0x83
      
      The USB ID 1395:740a has to be added to the entries in
      snd_usb_get_sample_rate_quirk().
      
      Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1052580
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      a8e800fe
    • D
      ALSA: seq: 2nd attempt at fixing race creating a queue · 7e1d90f6
      Daniel Mentz 提交于
      commit 4842e98f ("ALSA: seq: Fix race at
      creating a queue") attempted to fix a race reported by syzkaller. That
      fix has been described as follows:
      
      "
      When a sequencer queue is created in snd_seq_queue_alloc(),it adds the
      new queue element to the public list before referencing it.  Thus the
      queue might be deleted before the call of snd_seq_queue_use(), and it
      results in the use-after-free error, as spotted by syzkaller.
      
      The fix is to reference the queue object at the right time.
      "
      
      Even with that fix in place, syzkaller reported a use-after-free error.
      It specifically pointed to the last instruction "return q->queue" in
      snd_seq_queue_alloc(). The pointer q is being used after kfree() has
      been called on it.
      
      It turned out that there is still a small window where a race can
      happen. The window opens at
      snd_seq_ioctl_create_queue()->snd_seq_queue_alloc()->queue_list_add()
      and closes at
      snd_seq_ioctl_create_queue()->queueptr()->snd_use_lock_use(). Between
      these two calls, a different thread could delete the queue and possibly
      re-create a different queue in the same location in queue_list.
      
      This change prevents this situation by calling snd_use_lock_use() from
      snd_seq_queue_alloc() prior to calling queue_list_add(). It is then the
      caller's responsibility to call snd_use_lock_free(&q->use_lock).
      
      Fixes: 4842e98f ("ALSA: seq: Fix race at creating a queue")
      Reported-by: NDmitry Vyukov <dvyukov@google.com>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NDaniel Mentz <danielmentz@google.com>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      7e1d90f6
  11. 14 8月, 2017 1 次提交
    • S
      ALSA: hda/realtek - Fix pincfg for Dell XPS 13 9370 · 8df4b003
      Shih-Yuan Lee (FourDollars) 提交于
      The initial pin configs for Dell headset mode of ALC3271 has changed.
      
      /sys/class/sound/hwC0D0/init_pin_configs: (BIOS 0.1.4)
      0x12 0xb7a60130
      0x13 0xb8a61140
      0x14 0x40000000
      0x16 0x411111f0
      0x17 0x90170110
      0x18 0x411111f0
      0x19 0x411111f0
      0x1a 0x411111f0
      0x1b 0x411111f0
      0x1d 0x4087992d
      0x1e 0x411111f0
      0x21 0x04211020
      
      has changed to ...
      
      /sys/class/sound/hwC0D0/init_pin_configs: (BIOS 0.2.0)
      0x12 0xb7a60130
      0x13 0x40000000
      0x14 0x411111f0
      0x16 0x411111f0
      0x17 0x90170110
      0x18 0x411111f0
      0x19 0x411111f0
      0x1a 0x411111f0
      0x1b 0x411111f0
      0x1d 0x4067992d
      0x1e 0x411111f0
      0x21 0x04211020
      
      Fixes: b4576de8 ("ALSA: hda/realtek - Fix typo of pincfg for Dell quirk")
      Signed-off-by: NShih-Yuan Lee (FourDollars) <sylee@canonical.com>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      8df4b003
  12. 11 8月, 2017 1 次提交
    • T
      ALSA: seq: Fix CONFIG_SND_SEQ_MIDI dependency · 4d3a8693
      Takashi Iwai 提交于
      The commit 0181307a ("ALSA: seq: Reorganize kconfig and build")
      rewrote the dependency of each sequencer module in a standard way, but
      there was one change applied mistakenly: CONFIG_SND_SEQ_MIDI isn't
      enabled properly by CONFIG_SND_RAWMIDI.  I seem to have changed the
      wrong one instead, CONFIG_SND_SEQ_MIDI_EMUL, which is eventually
      reverse-selected by CONFIG_SND_SEQ_MIDI itself.  This ended up the
      lack of snd-seq-midi module as reported below.
      
      The fix is to put def_tristate properly to CONFIG_SND_SEQ_MIDI instead
      of *_MIDI_EMUL entry.
      
      Fixes: 0181307a ("ALSA: seq: Reorganize kconfig and build")
      Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196633Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      4d3a8693
  13. 02 8月, 2017 1 次提交
  14. 01 8月, 2017 2 次提交
  15. 28 7月, 2017 2 次提交
  16. 27 7月, 2017 1 次提交
  17. 26 7月, 2017 2 次提交
  18. 24 7月, 2017 1 次提交
    • K
      ASoC: sh: hac: add missing "int ret" · 295c5ba4
      Kuninori Morimoto 提交于
      commit b047e1cc ("ASoC: ac97: Support multi-platform AC'97")
      modified hac_soc_platform_probe(), but "int ret" was missed.
      This patch adds missing "int ret", otherwise, we will get
      
      linux/sound/soc/sh/hac.c: In function 'hac_soc_platform_probe':
      linux/sound/soc/sh/hac.c:318: error: 'ret' undeclared (first use in this function)
      linux/sound/soc/sh/hac.c:318: error: (Each undeclared identifier is reported only once
      linux/sound/soc/sh/hac.c:318: error: for each function it appears in.)
      Signed-off-by: NKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      295c5ba4
  19. 22 7月, 2017 1 次提交
  20. 21 7月, 2017 3 次提交
  21. 20 7月, 2017 1 次提交
  22. 18 7月, 2017 1 次提交
  23. 17 7月, 2017 4 次提交
  24. 15 7月, 2017 1 次提交
  25. 13 7月, 2017 1 次提交
  26. 11 7月, 2017 2 次提交