Return -ENOMEM if kzalloc fails in gpio_keys_get_devtree_pdata().
Signed-off-by: NTobias Klauser <tklauser@distanz.ch>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Add missing device_remove_file() for dev_attr_time in lm8323_remove().
Also calling device_remove_file() in lm8323_probe() error path to
remove sysfs attribute file.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Fix a constant definition and computation of polling time.

[dtor@mail.ru: switched to using DIV_ROUND_UP as was suggested by
 Thierry Reding <thierry.reding@avionic-design.de>]
Signed-off-by: NRakesh Iyer <riyer@nvidia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We need to explicitly include module.h since some of its facilities
are used.
Signed-off-by: NStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

hgpk.c uses interfaces from linux/module.h, so it should include that file.
This fixes build errors.
Signed-off-by: NRandy Dunlap <rdunlap@xenotime.net>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We were testing wrong bit in the extended capability query.
Reported-by: NDaniel Kurtz <djkurtz@chromium.org>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

To support key repeats, keyboard needs to be setup as an autorepeating
device.
Signed-off-by: NRakesh Iyer <riyer@nvidia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

According to the comments we want to call mutex_lock() here instead
of mutex_unlock().  That makes more sense.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We are testing the wrong variable here.  I believe tj9->input_dev
is always NULL at this point, so probe() will fail.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

The implementation does break from the for loop after we assign 'i' to
variable 'found'.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

It's not referenced outside this file so there's no need for it to be in
the global name space.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Make sure we are passing the same cookie in all calls to
request_any_context_irq() and free_irq().
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

The implementation in cy8ctmg110_probe() does not properly set reset_pin
and irq_pin from platform data. Let's fix it.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

i2c_master_send returns negative errno, or else the number of bytes written.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We only care about if there is a successful match from the table (or
no match at all), so let's make dmi_check_system return immediately
instead of iterating thorough the whole table.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We only care about if there is a successful match from the table (or
no match at all), so let's make dmi_check_system return immediately
instead of iterating thorough the whole table.

Make the dmi callback function return 1 then dmi_check_system
will return immediately if we have a successful match.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This reduces amount #ifdeds in the code.
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This patch enables fetching configuration data, which is normally provided
via platform_data, from the device-tree instead.

If the device is configured from device-tree data, the platform_data struct
is not used, and button data needs to be allocated dynamically. Big part of
this patch deals with confining pdata usage to the probe function, to make
this possible.
Signed-off-by: NDavid Jander <david@protonic.nl>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Constant AIPTEK_TOOL_BUTTON_PEN_MODE was defined twice.
Signed-off-by: NEdwin van Vliet <edwin@cheatah.nl>
Reviewed-by: NJesper Juhl <jj@chaosbits.net>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Newer Synaptics firmware allows to query minimum coordinates reported by
the device, let's use this data.
Acked-by: NChase Douglas <chase.douglas@canonical.com>
Acked-by: NHenrik Rydberg <rydberg@euromail.se>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

AGM packets contain valid button bits, too.
This patch refactors packet processing to parse button bits in AGM packets.
However, they aren't actually used or reported.

The point is to more completely process AGM packets,
and prepare for future patches that may actually use AGM packet button bits.
Signed-off-by: NDaniel Kurtz <djkurtz@chromium.org>
Acked-by: NChase Douglas <chase.douglas@canonical.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NDaniel Kurtz <djkurtz@chromium.org>
Acked-by: NChase Douglas <chase.douglas@canonical.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Synaptics touchpads indicate via a capability bit when they perform reduced
filtering on position data. In such a case, use a non-zero fuzz value.
Fuzz = 8 was chosen empirically by observing the raw position data
reported by a clickpad indicating it had reduced filtering.
Signed-off-by: NDaniel Kurtz <djkurtz@chromium.org>
Acked-by: NChase Douglas <chase.douglas@canonical.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Set resolution for MT_POSITION_X and MT_POSITION_Y to match ABS_X and
ABS_Y, respectively.
Signed-off-by: NDaniel Kurtz <djkurtz@chromium.org>
Acked-by: NChase Douglas <chase.douglas@canonical.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

The old code may call input_sync() without sending any other events.
While it will be suppressed by the input core not calling it at all
is still cheaper.
Signed-off-by: NPing Cheng <pingc@wacom.com>
Reviewed-by: NChris Bagwell <chris@cnpbagwell.com>
Reviewed-by: NHenrik Rydberg <rydberg@euromail.se>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Bamboo touch sets BTN_BACK, BTN_FORWARD, BTN_LEFT, and BTN_RIGHT
as the default button events for tablet buttons. Change Graphire4
and old Bamboo to the same settings.
Signed-off-by: NPing Cheng <pingc@wacom.com>
Reviewed-by: NChris Bagwell <chris@cnpbagwell.com>
Reviewed-by: NHenrik Rydberg <rydberg@euromail.se>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

With the removal of BTN_TOOL_FINGER for tablet buttons and
expresskeys, serial number is needed to distingush if the
events were from a regular tool (stylus, eraser, or mouse)
or the attribures (buttons, strips, or wheels) on the tablet
since there are overlapped events between the tools and the
tablet attributes.
Signed-off-by: NPing Cheng <pingc@wacom.com>
Reviewed-by: NChris Bagwell <chris@cnpbagwell.com>
Reviewed-by: NHenrik Rydberg <rydberg@euromail.se>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

BTN_TOOL_FINGER was designed to indicate a single finger touch.
Remove the lines that borrowed this type for expresskeys and
tablet buttons.
Signed-off-by: NPing Cheng <pingc@wacom.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NChris Hudson <chudson@kionix.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Put parentheses around macro argument uses. This avoids pitfalls
for the programmer, where the argument expansion does not give the
expected result, for example:

	ioctl (fd, EVIOCGABS (have_mt ? ABS_MT_POSITION_X : ABS_X), &abs);
Signed-off-by: NSimon Budig <simon.budig@kernelconcepts.de>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Currently, battery drivers also use poll_sample() provided by the
wm97xx-core but this code always checks if the pen is down. Mark the
channels which really need this (i.e. for the touchscreen) with the
PEN_DOWN bit, and skip the checks otherwise. Now, the battery channels
can always be read.
Signed-off-by: NWolfram Sang <w.sang@pengutronix.de>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

The current implementation of poll_sample() has the problem that one of
its arguments, the channel to be selected, differs from wm9713 to other
variants. This parameter gets passed to the (currently unused)
mach-specific functions pre_sample() and post_sample() which thus have
to deal with codec-specific differences. Refactor the routine so that
the argument to poll_sample() is generic for all codecs and do necessary
conversions only in the codec-specific driver. The outcome even uses
less code and removes the non-standard use of the PEN_DOWN bit to mark
the AUX-channels.
Signed-off-by: NWolfram Sang <w.sang@pengutronix.de>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NWolfram Sang <w.sang@pengutronix.de>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: NKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This patch implements rumble support for XBox360 Wireless Controllers.
Signed-off-by: NChris Moeller <kode54@gmail.c>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

The "#if" above should really be an "#ifdef" to avoid this warning:

  CC      drivers/input/keyboard/sh_keysc.o
drivers/input/keyboard/sh_keysc.c:294:5: warning: "CONFIG_PM_SLEEP" is
not defined
Reported-by: NMagnus Damm <magnus.damm@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Handle the objects with multiple instances correctly when the configuration
data is loaded.
Signed-off-by: NIiro Valkonen <iiro.valkonen@atmel.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Update the object list to include new objects, and add unique identifiers
so we can distinguish between old & new generation of the same object.
Signed-off-by: NIiro Valkonen <iiro.valkonen@atmel.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>