1. 18 3月, 2014 4 次提交
  2. 26 8月, 2013 1 次提交
  3. 10 8月, 2013 1 次提交
    • S
      IB/iser: Accept session->cmds_max from user space · b7f04513
      Shlomo Pongratz 提交于
      Use cmds_max passed from user space to be the number of PDUs to be
      supported for the session instead of hard-coded ISCSI_DEF_XMIT_CMDS_MAX.
      This allow controlling the max number of SCSI commands for the session.
      Also don't ignore the qdepth passed from user space.
      
      Derive from session->cmds_max the actual number of RX buffers and FMR
      pool size to allocate during the connection bind phase.
      
      Since the iser transport connection is established before the iscsi
      session/connection are created and bound, we still use one hard-coded
      quantity ISER_DEF_XMIT_CMDS_MAX to compute the maximum number of
      work-requests to be supported by the RC QP used for the connection.
      
      The above quantity is made to be a power of two between ISCSI_TOTAL_CMDS_MIN
      (16) and ISER_DEF_XMIT_CMDS_MAX (512) inclusive.
      Signed-off-by: NShlomo Pongratz <shlomop@mellanox.com>
      Signed-off-by: NOr Gerlitz <ogerlitz@mellanox.com>
      Signed-off-by: NRoland Dreier <roland@purestorage.com>
      b7f04513
  4. 05 6月, 2013 1 次提交
  5. 02 5月, 2013 2 次提交
  6. 19 5月, 2012 1 次提交
  7. 06 3月, 2012 1 次提交
    • O
      IB/iser: Post initial receive buffers before sending the final login request · 89e984e2
      Or Gerlitz 提交于
      An iser target may send iscsi NO-OP PDUs as soon as it marks the iSER
      iSCSI session as fully operative.  This means that there is window
      where there are no posted receive buffers on the initiator side, so
      it's possible for the iSER RC connection to break because of RNR NAK /
      retry errors.  To fix this, rely on the flags bits in the login
      request to have FFP (0x3) in the lower nibble as a marker for the
      final login request, and post an initial chunk of receive buffers
      before sending that login request instead of after getting the login
      response.
      Signed-off-by: NOr Gerlitz <ogerlitz@mellanox.com>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NRoland Dreier <roland@purestorage.com>
      89e984e2
  8. 04 1月, 2012 1 次提交
  9. 05 11月, 2011 1 次提交
  10. 01 11月, 2011 1 次提交
  11. 27 8月, 2011 3 次提交
  12. 18 8月, 2011 1 次提交
  13. 25 2月, 2011 1 次提交
  14. 13 5月, 2010 1 次提交
    • O
      IB/iser: Enhance disconnection logic for multi-pathing · 39ff05db
      Or Gerlitz 提交于
      The iser connection teardown flow isn't over until the underlying
      Connection Manager (e.g the IB CM) delivers a disconnected or timeout
      event through the RDMA-CM.  When the remote (target) side isn't
      reachable, e.g when some HW e.g port/hca/switch isn't functioning or
      taken down administratively, the CM timeout flow is used and the event
      may be generated only after relatively long time -- on the order of
      tens of seconds.
      
      The current iser code exposes this possibly long delay to higher
      layers, specifically to the iscsid daemon and iscsi kernel stack. As a
      result, the iscsi stack doesn't respond well: this low-level CM delay
      is added to the fail-over time under HA schemes such as the one
      provided by DM multipath through the multipathd(8) service.
      
      This patch enhances the reference counting scheme on iser's IB
      connections so that the disconnect flow initiated by iscsid from user
      space (ep_disconnect) doesn't wait for the CM to deliver the
      disconnect/timeout event.  (The connection teardown isn't done from
      iser's view point until the event is delivered)
      
      The iser ib (rdma) connection object is destroyed when its reference
      count reaches zero.  When this happens on the RDMA-CM callback
      context, extra care is taken so that the RDMA-CM does the actual
      destroying of the associated ID, since doing it in the callback is
      prohibited.
      
      The reference count of iser ib connection normally reaches three,
      where the <ref, deref> relations are
      
       1. conn <init, terminate>
       2. conn <bind, stop/destroy>
       3. cma id <create, disconnect/error/timeout callbacks>
      
      With this patch, multipath fail-over time is about 30 seconds, while
      without this patch, multipath fail-over time is about 130 seconds.
      Signed-off-by: NOr Gerlitz <ogerlitz@voltaire.com>
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      39ff05db
  15. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  16. 03 3月, 2010 1 次提交
  17. 25 2月, 2010 3 次提交
    • O
      IB/iser: Use libiscsi passthrough mode · 962b4b52
      Or Gerlitz 提交于
      libiscsi passthrough mode invokes the transport xmit calls directly
      without first going through an internal queue, unlike the other mode,
      which uses a queue and a xmitworker thread.  Now that the "cant_sleep"
      prerequisite of iscsi_host_alloc is met, move to use it.  Handling
      xmit errors is now done by the passthrough flow of libiscsi.  Since
      the queue/worker aren't used in this mode, the code that schedules the
      xmitworker is removed.
      Signed-off-by: NOr Gerlitz <ogerlitz@voltaire.com>
      Reviewed-by: NMike Christie <michaelc@cs.wisc.edu>
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      962b4b52
    • O
      IB/iser: Simplify send flow/descriptors · f19624aa
      Or Gerlitz 提交于
      Simplify and shrink the logic/code used for the send descriptors.
      Changes include removing struct iser_dto (an unnecessary abstraction),
      using struct iser_regd_buf only for handling SCSI commands, using
      dma_sync instead of dma_map/unmap, etc.
      Signed-off-by: NOr Gerlitz <ogerlitz@voltaire.com>
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      f19624aa
    • O
      IB/iser: New receive buffer posting logic · bcc60c38
      Or Gerlitz 提交于
      Currently, the recv buffer posting logic is based on the transactional
      nature of iSER which allows for posting a buffer before sending a PDU.
      Change this to post only when the number of outstanding recv buffers
      is below a water mark and in a batched manner, thus simplifying and
      optimizing the data path.  Use a pre-allocated ring of recv buffers
      instead of allocating from kmem cache.  A special treatment is given
      to the login response buffer whose size must be 8K unlike the size of
      buffers used for any other purpose which is 128 bytes.
      Signed-off-by: NOr Gerlitz <ogerlitz@voltaire.com>
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      bcc60c38
  18. 05 12月, 2009 1 次提交
  19. 03 10月, 2009 1 次提交
  20. 24 5月, 2009 2 次提交
    • M
      [SCSI] libiscsi: add task aborted state · b3cd5050
      Mike Christie 提交于
      If a task did not complete normally due to a TMF, libiscsi will
      now complete the task with the state ISCSI_TASK_ABRT_TMF. Drivers
      like bnx2i that need to free resources if a command did not complete normally
      can then check the task state. If a driver does not need to send
      a special command if we have dropped the session then they can check
      for ISCSI_TASK_ABRT_SESS_RECOV.
      Signed-off-by: NMike Christie <michaelc@cs.wisc.edu>
      Signed-off-by: NJames Bottomley <James.Bottomley@HansenPartnership.com>
      b3cd5050
    • M
      [SCSI] iscsi: pass ep connect shost · 10eb0f01
      Mike Christie 提交于
      When we create the tcp/ip connection by calling ep_connect, we currently
      just go by the routing table info.
      
      I think there are two problems with this.
      
      1. Some drivers do not have access to a routing table. Some drivers like
      qla4xxx do not even know about other ports.
      
      2. If you have two initiator ports on the same subnet, the user may have
      set things up so that session1 was supposed to be run through port1. and
      session2 was supposed to be run through port2. It looks like we could
      end with both sessions going through one of the ports.
      
      Fixes for cxgb3i from Karen Xie.
      Signed-off-by: NMike Christie <michaelc@cs.wisc.edu>
      Signed-off-by: NJames Bottomley <James.Bottomley@HansenPartnership.com>
      10eb0f01
  21. 27 4月, 2009 1 次提交
  22. 14 3月, 2009 5 次提交
  23. 30 12月, 2008 2 次提交
  24. 13 10月, 2008 2 次提交
  25. 15 7月, 2008 1 次提交