1. 15 5月, 2010 3 次提交
  2. 06 5月, 2010 1 次提交
  3. 23 4月, 2010 3 次提交
  4. 06 4月, 2010 3 次提交
  5. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  6. 28 3月, 2010 1 次提交
  7. 23 3月, 2010 2 次提交
    • T
      libata-sff: fix spurious IRQ handling · 332ac7ff
      Tejun Heo 提交于
      Commit 27943620 introduced spurious
      IRQ handling but it has a race condition where valid completion can be
      lost while trying to clear spurious IRQ leading to occassional command
      timeouts.
      
      This patch improves SFF interrupt handler such that
      
      1. Once BMDMA HSM is stopped, the condition is never considered
         spurious.  As there's no way to resume stopped BMDMA HSM, if device
         status doesn't agree with BMDMA status, the only way out is
         aborting the command (otherwise, it will just end up timing out).
      
      2. ap->ops->sff_check_status() can be safely called to clear spurious
         device IRQ as it atomically returns completion status but BMDMA IRQ
         status can't be cleared in safe way if command is in flight.  After
         a spurious IRQ, call ap->ops->sff_irq_clear() only if the
         respective device is idle and retry completion if
         sff_check_status() indicates command completion.
      
      Please note that ata_piix uses bmdma_status for sff_irq_check() and #2
      won't weaken spurious IRQ handling even with in-flight command because
      if bmdma_status indicates IRQ pending but device status is not on
      spurious check, the next IRQ handler invocation will abort the command
      due to #1.
      
      This fixes bko#15537.
      
         https://bugzilla.kernel.org/show_bug.cgi?id=15537Signed-off-by: NTejun Heo <tj@kernel.org>
      Cc: Andrew Benton <b3nton@gmail.com>
      Cc: Petr Uzel <petr.uzel@centrum.cz>
      Cc: Rafael J. Wysocki <rjw@sisk.pl>
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      332ac7ff
    • J
      pata_via: Add VIA VX900 support · 4f1deba4
      JosephChan@via.com.tw 提交于
      Signed-off-by: NJoseph Chan <josephchan@via.com.tw>
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      4f1deba4
  8. 18 3月, 2010 3 次提交
  9. 02 3月, 2010 23 次提交