1. 20 11月, 2014 7 次提交
  2. 28 5月, 2014 2 次提交
    • F
      scsi/NCR5380: fix and standardize NDEBUG macros · 9829e528
      Finn Thain 提交于
      All three NCR5380 core driver implementations share the same NCR5380.h
      header file so they need to agree on certain macro definitions.
      
      The flag bit used by the NDEBUG_MERGING macro in atari_NCR5380 and
      sun3_NCR5380 collides with the bit used by NDEBUG_LISTS.
      
      Moreover, NDEBUG_ABORT appears in NCR5380.c so it should be defined in
      NCR5380.h rather than in each of the many drivers using that core.
      
      An undefined NDEBUG_ABORT macro caused compiler errors and led to dodgy
      workarounds in the core driver that can now be removed.
      (See commits f566a576 and
      185a7a1c.)
      
      Move all of the NDEBUG_ABORT, NDEBUG_TAGS and NDEBUG_MERGING macro
      definitions into NCR5380.h where all the other NDEBUG macros live.
      
      Also, incorrect "#ifdef NDEBUG" becomes "#if NDEBUG" to fix the warning:
      drivers/scsi/mac_scsi.c: At top level:
      drivers/scsi/NCR5380.c:418: warning: 'NCR5380_print' defined but not used
      drivers/scsi/NCR5380.c:459: warning: 'NCR5380_print_phase' defined but not used
      
      The debugging code is now enabled when NDEBUG != 0.
      Signed-off-by: NFinn Thain <fthain@telegraphics.com.au>
      Acked-by: NSam Creasey <sammy@sammy.net>
      Signed-off-by: NChristoph Hellwig <hch@lst.de>
      9829e528
    • F
      scsi/NCR5380: adopt dprintk() · d65e634a
      Finn Thain 提交于
      All NCR5380 drivers already include the NCR5380.h header. Better to
      adopt those macros rather than have three variations on them.
      
      Moreover, the macros in NCR5380.h are preferable because the atari_NCR5380
      and sun3_NCR5380 versions are inflexible. For example, they can't accomodate
      dprintk(NDEBUG_MAIN | NDEBUG_QUEUES, ...)
      
      Replace the *_PRINTK macros from atari_NCR5380.h and sun3_NCR5380.h with
      the equivalent macros from NCR5380.h.
      Signed-off-by: NFinn Thain <fthain@telegraphics.com.au>
      Acked-by: NSam Creasey <sammy@sammy.net>
      Acked-by: NMichael Schmitz <schmitz@debian.org>
      Signed-off-by: NChristoph Hellwig <hch@lst.de>
      d65e634a
  3. 27 5月, 2014 1 次提交
  4. 20 5月, 2014 1 次提交
    • M
      m68k/atari - atari_scsi: change abort/reset return codes · 2b0f834c
      Michael Schmitz 提交于
      [Resend of earlier patch - added equivalent changes to sun3 NCR5380 code]
      
      The abort/reset lowlevel return codes had changed with the new
      error SCSI handling - update Atari and Sun3 NCR5380 drivers to reflect this.
      
      Change reset handling for Atari to clear queues only, do not attempt
      to call done() on each command aborted by the reset. The EH code
      should do that for us. Queues _must_ be cleared, otherwise
      atari_scsi_bus_reset will not release the ST-DMA lock, deadlocking
      further error recovery.
      
      Update the Sun3 NCR5380 driver as well - the Sun3 driver was
      derived from the Atari one. Kudos to Finn Thain for the Sun3 part
      and cleaning up the header files. After the header cleanup, the
      initio.h include (!) can be dropped from sun3_scsi.h now.
      Signed-off-by: NMichael Schmitz <schmitz@debian.org>
      Signed-off-by: NFinn Thain <fthain@telegraphics.com.au>
      Acked-by: NSam Creasey <sammy@sammy.net>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Cc: James E.J. Bottomley <JBottomley@parallels.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: NChristoph Hellwig <hch@lst.de>
      2b0f834c
  5. 11 3月, 2014 1 次提交
    • A
      [SCSI] atari_scsi: Fix sleep_on race · eff9cf8d
      Arnd Bergmann 提交于
      sleep_on is known broken and going away. The atari_scsi driver is one of
      two remaining users in the falcon_get_lock() function, which is a rather
      crazy piece of code. This does not attempt to fix the driver's locking
      scheme in general, but at least prevents falcon_get_lock from going to
      sleep when no other thread holds the same lock or tries to get it,
      and we no longer schedule with irqs disabled.
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      [MSch: fixed completion conditions missed in Arnds' original RFC patch]
      Signed-off-by: NMichael Schmitz <schmitz@debian.org>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Cc: James E.J. Bottomley <JBottomley@parallels.com>
      Cc: linux-scsi@vger.kernel.org
      Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
      eff9cf8d
  6. 10 4月, 2013 1 次提交
  7. 23 4月, 2012 2 次提交
  8. 30 6月, 2011 1 次提交
  9. 17 11月, 2010 1 次提交
    • J
      SCSI host lock push-down · f281233d
      Jeff Garzik 提交于
      Move the mid-layer's ->queuecommand() invocation from being locked
      with the host lock to being unlocked to facilitate speeding up the
      critical path for drivers who don't need this lock taken anyway.
      
      The patch below presents a simple SCSI host lock push-down as an
      equivalent transformation.  No locking or other behavior should change
      with this patch.  All existing bugs and locking orders are preserved.
      
      Additionally, add one parameter to queuecommand,
      	struct Scsi_Host *
      and remove one parameter from queuecommand,
      	void (*done)(struct scsi_cmnd *)
      
      Scsi_Host* is a convenient pointer that most host drivers need anyway,
      and 'done' is redundant to struct scsi_cmnd->scsi_done.
      
      Minimal code disturbance was attempted with this change.  Most drivers
      needed only two one-line modifications for their host lock push-down.
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      Acked-by: NJames Bottomley <James.Bottomley@suse.de>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      f281233d
  10. 27 3月, 2009 1 次提交
  11. 15 10月, 2008 1 次提交
  12. 25 11月, 2007 1 次提交
    • J
      [SCSI] NCR5380: Fix bugs and canonicalize irq handler usage · 1e641664
      Jeff Garzik 提交于
      * Always pass the same value to free_irq() that we pass to
        request_irq().  This fixes several bugs.
      
      * Always call NCR5380_intr() with 'irq' and 'dev_id' arguments.
      
        Note, scsi_falcon_intr() is the only case now where dev_id is not the
        scsi_host.
      
      * Always pass Scsi_Host to request_irq().  For most cases, the drivers
        already did so, and I merely neated the source code line.  In other
        cases, either NULL or a non-sensical value was passed, verified to be
        unused, then changed to be Scsi_Host in anticipation of the future.
      
      In addition to the bugs fixes, this change makes the interface usage
      consistent, which in turn enables the possibility of directly
      referencing Scsi_Host from all NCR5380_intr() invocations.
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@HansenPartnership.com>
      1e641664
  13. 05 5月, 2007 3 次提交
  14. 15 2月, 2007 1 次提交
    • T
      [PATCH] remove many unneeded #includes of sched.h · cd354f1a
      Tim Schmielau 提交于
      After Al Viro (finally) succeeded in removing the sched.h #include in module.h
      recently, it makes sense again to remove other superfluous sched.h includes.
      There are quite a lot of files which include it but don't actually need
      anything defined in there.  Presumably these includes were once needed for
      macros that used to live in sched.h, but moved to other header files in the
      course of cleaning it up.
      
      To ease the pain, this time I did not fiddle with any header files and only
      removed #includes from .c-files, which tend to cause less trouble.
      
      Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
      arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
      allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
      configs in arch/arm/configs on arm.  I also checked that no new warnings were
      introduced by the patch (actually, some warnings are removed that were emitted
      by unnecessarily included header files).
      Signed-off-by: NTim Schmielau <tim@physik3.uni-rostock.de>
      Acked-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      cd354f1a
  15. 05 10月, 2006 1 次提交
    • D
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells 提交于
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: NDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  16. 01 7月, 2006 1 次提交
  17. 26 3月, 2006 1 次提交
  18. 10 11月, 2005 1 次提交
  19. 17 4月, 2005 1 次提交
    • L
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds 提交于
      Initial git repository build. I'm not bothering with the full history,
      even though we have it. We can create a separate "historical" git
      archive of that later if we want to, and in the meantime it's about
      3.2GB when imported into git - space that would just make the early
      git days unnecessarily complicated, when we don't have a lot of good
      infrastructure for it.
      
      Let it rip!
      1da177e4