1. 21 9月, 2009 4 次提交
    • H
      thinkpad-acpi: hotkey event driver update · 0d922e3b
      Henrique de Moraes Holschuh 提交于
      Update the HKEY event driver to:
      
      1. Handle better the second-gen firmware, which has no HKEY mask
         support but does report FN+F3, FN+F4 and FN+F12 without the need
         for NVRAM polling.
      
         a) always make the mask-related attributes available in sysfs;
         b) use DMI quirks to detect the second-gen firmware;
         c) properly report that FN+F3, FN+F4 and FN+F12 are enabled,
            and available even on mask-less second-gen firmware;
      
      2. Decouple the issuing of hotkey events towards userspace from
         their reception from the firmware.  ALSA mixer and brightness
         event reporting support will need this feature.
      
      3. Clean up the mess in the hotkey driver a great deal.  It is
         still very convoluted, and wants a full refactoring into a
         proper event API interface, but that is not going to happen
         today.
      
      4. Fully reset firmware interface on resume (restore hotkey
         mask and status).
      
      5. Stop losing polled events for no good reason when changing the
         mask and poll frequencies.  We will still lose them when the
         hotkey_source_mask is changed, as well as any that happened
         between driver suspend and driver resume.
      
      The hotkey subdriver now has the notion of user-space-visible hotkey
      event mask, as well as of the set of "hotkey" events the driver needs
      (because brightness/volume change reports are not just keypress
      reports in most ThinkPad models).
      
      With this rewrite, the ABI level is bumped to 0x020500 should
      userspace need to know it is dealing with the updated hotkey
      subdriver.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      0d922e3b
    • H
      thinkpad-acpi: drop HKEY event 0x5010 · 176dd985
      Henrique de Moraes Holschuh 提交于
      HKEY event 0x5010 is useless to us: old ThinkPads don't issue it.  Newer
      ThinkPads won't issue it anymore.  And all ThinkPads issue 0x1010 and
      0x1011 events.
      
      Just silently drop it instead of sending it to userspace.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      176dd985
    • H
      thinkpad-acpi: remove uneeded tp_features.hotkey tests in hotkey_exit · 4be73005
      Henrique de Moraes Holschuh 提交于
      hotkey_exit() is only called if hotkey_init() finished sucessfully, or
      by direct calls inside hotkey_init().  The tp_features.hotkey test is
      always true, and just adds to the confusion, remove it.  Also, avoid
      calling hotkey_mask_set() when it won't do anything useful.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      4be73005
    • H
      thinkpad-acpi: don't leave ERR_PTR() pointers around · 435c47e2
      Henrique de Moraes Holschuh 提交于
      backlight_device_register returns ERR_PTR() in case of problems, and
      the current code would leave that ERR_PTR in ibm_backlight_device.
      
      The current code paths won't touch it in that situation, but that could
      change.  Make sure to set ibm_backlight_device to NULL in the error
      path.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      435c47e2
  2. 19 9月, 2009 9 次提交
  3. 10 9月, 2009 1 次提交
  4. 09 9月, 2009 3 次提交
    • E
      aoe: allocate unused request_queue for sysfs · 7135a71b
      Ed Cashin 提交于
      Andy Whitcroft reported an oops in aoe triggered by use of an
      incorrectly initialised request_queue object:
      
        [ 2645.959090] kobject '<NULL>' (ffff880059ca22c0): tried to add
      		an uninitialized object, something is seriously wrong.
        [ 2645.959104] Pid: 6, comm: events/0 Not tainted 2.6.31-5-generic #24-Ubuntu
        [ 2645.959107] Call Trace:
        [ 2645.959139] [<ffffffff8126ca2f>] kobject_add+0x5f/0x70
        [ 2645.959151] [<ffffffff8125b4ab>] blk_register_queue+0x8b/0xf0
        [ 2645.959155] [<ffffffff8126043f>] add_disk+0x8f/0x160
        [ 2645.959161] [<ffffffffa01673c4>] aoeblk_gdalloc+0x164/0x1c0 [aoe]
      
      The request queue of an aoe device is not used but can be allocated in
      code that does not sleep.
      
      Bruno bisected this regression down to
      
        cd43e26f
      
        block: Expose stacked device queues in sysfs
      
      "This seems to generate /sys/block/$device/queue and its contents for
       everyone who is using queues, not just for those queues that have a
       non-NULL queue->request_fn."
      
      Addresses http://bugs.launchpad.net/bugs/410198
      Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13942
      
      Note that embedding a queue inside another object has always been
      an illegal construct, since the queues are reference counted and
      must persist until the last reference is dropped. So aoe was
      always buggy in this respect (Jens).
      Signed-off-by: NEd Cashin <ecashin@coraid.com>
      Cc: Andy Whitcroft <apw@canonical.com>
      Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
      Cc: Bruno Premont <bonbons@linux-vserver.org>
      Cc: Martin K. Petersen <martin.petersen@oracle.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NJens Axboe <jens.axboe@oracle.com>
      7135a71b
    • L
      i915: disable interrupts before tearing down GEM state · e6890f6f
      Linus Torvalds 提交于
      Reinette Chatre reports a frozen system (with blinking keyboard LEDs)
      when switching from graphics mode to the text console, or when
      suspending (which does the same thing). With netconsole, the oops
      turned out to be
      
      	BUG: unable to handle kernel NULL pointer dereference at 0000000000000084
      	IP: [<ffffffffa03ecaab>] i915_driver_irq_handler+0x26b/0xd20 [i915]
      
      and it's due to the i915_gem.c code doing drm_irq_uninstall() after
      having done i915_gem_idle(). And the i915_gem_idle() path will do
      
        i915_gem_idle() ->
          i915_gem_cleanup_ringbuffer() ->
            i915_gem_cleanup_hws() ->
              dev_priv->hw_status_page = NULL;
      
      but if an i915 interrupt comes in after this stage, it may want to
      access that hw_status_page, and gets the above NULL pointer dereference.
      
      And since the NULL pointer dereference happens from within an interrupt,
      and with the screen still in graphics mode, the common end result is
      simply a silently hung machine.
      
      Fix it by simply uninstalling the irq handler before idling rather than
      after. Fixes
      
          http://bugzilla.kernel.org/show_bug.cgi?id=13819Reported-and-tested-by: NReinette Chatre <reinette.chatre@intel.com>
      Acked-by: NJesse Barnes <jbarnes@virtuousgeek.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      e6890f6f
    • Z
      drm/i915: fix mask bits setting · 7c8460db
      Zhenyu Wang 提交于
      eDP is exclusive connector too, and add missing crtc_mask
      setting for TV.
      
      This fixes
      
      	http://bugzilla.kernel.org/show_bug.cgi?id=14139Signed-off-by: NZhenyu Wang <zhenyuw@linux.intel.com>
      Reported-and-tested-by: NCarlos R. Mafra <crmafra2@gmail.com>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      7c8460db
  5. 08 9月, 2009 5 次提交
  6. 07 9月, 2009 2 次提交
  7. 06 9月, 2009 16 次提交