提交 · 0cfc7da3ff4b39a3aac261ab3f6b1329e2485653 · openanolis / cloud-kernel

20 5月, 2006 3 次提交

[JFFS2] Reduce calls to ref_totlen() in jffs2_mark_node_obsolete() · 1417fc44

由 David Woodhouse 提交于 5月 20, 2006

We were calling ref_totlen() 18 times. Even before that becomes a real
function rather than just a dereference, apparently some compilers still
suck anyway. It'll _certainly_ suck after ref_totlen() becomes more
complicated, so calculate it once and don't rely on CSE.
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

1417fc44

[JFFS2] Optimise reading of eraseblock summary nodes · 9641b784

由 David Woodhouse 提交于 5月 20, 2006

This improves the time to mount 512MiB of NAND flash on my OLPC prototype
by about 4%. We used to read the last page of the eraseblock twice -- once
to find the offset of the summary node, and again to actually _read_ the
summary node. Now we read the last page only once, and read more only if
we need to.

We also don't allocate a new buffer just for the summary code -- we use
the buffer which was already allocated for the scan. Better still, if the
'buffer' for the scan is actually just a pointer directly into NOR flash,
we use that too, avoiding the memcpy() which we used to do.
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

9641b784

[JFFS2] Remove forgotten summary code · 8e4482fb

由 Ferenc Havasi 提交于 5月 19, 2006

Remove forgotten lines from jffs2_scan_eraseblock() which
were unnecessary and may cause problem in some environments.

Thanks to Alexander Belyakov <alexander.belyakov@intel.com>.
Signed-off-by: NFerenc Havasi <havasi@inf.u-szeged.hu>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

8e4482fb

19 5月, 2006 1 次提交

[JFFS2] Support new device nodes · aef9ab47

由 David Woodhouse 提交于 5月 19, 2006

Device node major/minor numbers are just stored in the payload of a single
data node. Just extend that to 4 bytes and use new_encode_dev() for it.

We only use the 4-byte format if we _need_ to, if !old_valid_dev(foo).
This preserves backwards compatibility with older code as much as
possible. If we do make devices with major or minor numbers above 255, and
then mount the file system with the old code, it'll just read the first
two bytes and get the numbers wrong. If it comes to garbage-collect it,
it'll then write back those wrong numbers. But that's about the best we
can expect.
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

aef9ab47

17 5月, 2006 1 次提交

[JFFS2] Fix printk format in jffs2_sum_write_data() error message. · c41ff6e5

由 David Woodhouse 提交于 5月 16, 2006

fs/jffs2/summary.c: In function ‘jffs2_sum_write_data’:
fs/jffs2/summary.c:658: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 4 has type ‘uint32_t’
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

c41ff6e5

16 5月, 2006 3 次提交

[JFFS2] Fix section mismatch warnings in JFFS2. · 7d2beb13

由 David Brownell 提交于 5月 16, 2006

Mark certain functions with __init and __exit appropriately.
Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

7d2beb13

[PATCH] jffs2: memory leak in jffs2_scan_medium() · 5b5ffbc1

由 Florin Malita 提交于 5月 15, 2006

If jffs2_scan_eraseblock() fails and the exit path is taken, 's' is not
being deallocated.

Reported by Coverity, CID: 1258.
Signed-off-by: NFlorin Malita <fmalita@gmail.com>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

5b5ffbc1

[PATCH] jffs2 warning fixes · 194a61b8

由 Andrew Morton 提交于 5月 15, 2006

fs/jffs2/nodelist.c: In function `check_node_data':
fs/jffs2/nodelist.c:441: warning: unsigned int format, different type arg (arg 4)
fs/jffs2/nodelist.c:464: warning: int format, different type arg (arg 5)
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NLinus Torvalds <torvalds@osdl.org>

194a61b8

15 5月, 2006 2 次提交

[JFFS2] Fix printk format in some error messages. · 184f5652

由 Andrew Morton 提交于 5月 15, 2006

fs/jffs2/nodelist.c: In function `check_node_data':
fs/jffs2/nodelist.c:441: warning: unsigned int format, different type arg (arg 4)
fs/jffs2/nodelist.c:464: warning: int format, different type arg (arg 5)

Modified from Andrew's original fix because while his terminal may indeed
only have eighty columns, mine only has _TWENTYFOUR_ lines. So the
cosmetic fluff is perfectly OK out past column 80 where it was -- the
casual reader doesn't _care_ about anything more than the fact that it
goes 'if (foo) JFFS2_WARNING...', and there's no point wasting a whole
line to display the tail end of the printk which nobody actually cares
about.
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

184f5652

[JFFS2] Don't pack on-medium structures, because GCC emits crappy code · 3e68fbb5

由 David Woodhouse 提交于 5月 15, 2006

If we use __attribute__((packed)), GCC will _also_ assume that the
structures aren't sensibly aligned, and it'll emit code to cope with
that instead of straight word load/save. This can be _very_ suboptimal
on architectures like ARM.

Ideally, we want an attribute which just tells GCC not to do any
padding, without the alignment side-effects. In the absense of that,
we'll just drop the 'packed' attribute and hope that everything stays as
it was (which to be fair is fairly much what we expect). And add some
paranoia checks in the initialisation code, which should be optimised
away completely in the normal case.
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

3e68fbb5

14 5月, 2006 1 次提交

[JFFS2] Reduce excessive node count for syslog files. · cf5eba53

由 David Woodhouse 提交于 5月 14, 2006

We currently get fairly poor behaviour with files which get many short
writes, such as system logs. This is because we end up with many tiny
data nodes, and the rbtree gets massive. None of these nodes are
actually obsolete, so they are counted as 'clean' space. Eraseblocks can
be entirely full of these nodes (which are REF_NORMAL instead of
REF_PRISTINE), and still they count entirely towards 'used_size' and the
eraseblocks can sit on the clean_list for a long time without being
picked for GC.

One way to alleviate this in the long term is to account REF_NORMAL
space separately from REF_PRISTINE space, rather than counting them both
towards used_size. Then these eraseblocks can be picked for GC and the
offending nodes will be garbage collected.

The short-term fix, though -- which probably makes sense even if we do
eventually implement the above -- is to merge these nodes as they're
written. When we write the last byte in a page, write the _whole_ page.
This obsoletes the earlier nodes in the page _immediately_ and we don't
even need to wait for the garbage collection to do it.

Original implementation from Ferenc Havasi <havasi@inf.u-szeged.hu>
Signed-off-by: NDavid Woodhouse <dwmw2@infradead.org>

cf5eba53

13 5月, 2006 12 次提交

[JFFS2][XATTR] Fix obvious typo · 21b9879b