1. 22 3月, 2018 4 次提交
  2. 13 2月, 2018 1 次提交
  3. 31 1月, 2018 1 次提交
    • B
      scsi: qla2xxx: Avoid triggering undefined behavior in qla2x00_mbx_completion() · c02189e1
      Bart Van Assche 提交于
      A left shift must shift less than the bit width of the left argument.
      Avoid triggering undefined behavior if ha->mbx_count == 32.
      
      This patch avoids that UBSAN reports the following complaint:
      
      UBSAN: Undefined behaviour in drivers/scsi/qla2xxx/qla_isr.c:275:14
      shift exponent 32 is too large for 32-bit type 'int'
      Call Trace:
       dump_stack+0x4e/0x6c
       ubsan_epilogue+0xd/0x3b
       __ubsan_handle_shift_out_of_bounds+0x112/0x14c
       qla2x00_mbx_completion+0x1c5/0x25d [qla2xxx]
       qla2300_intr_handler+0x1ea/0x3bb [qla2xxx]
       qla2x00_mailbox_command+0x77b/0x139a [qla2xxx]
       qla2x00_mbx_reg_test+0x83/0x114 [qla2xxx]
       qla2x00_chip_diag+0x354/0x45f [qla2xxx]
       qla2x00_initialize_adapter+0x2c2/0xa4e [qla2xxx]
       qla2x00_probe_one+0x1681/0x392e [qla2xxx]
       pci_device_probe+0x10b/0x1f1
       driver_probe_device+0x21f/0x3a4
       __driver_attach+0xa9/0xe1
       bus_for_each_dev+0x6e/0xb5
       driver_attach+0x22/0x3c
       bus_add_driver+0x1d1/0x2ae
       driver_register+0x78/0x130
       __pci_register_driver+0x75/0xa8
       qla2x00_module_init+0x21b/0x267 [qla2xxx]
       do_one_initcall+0x5a/0x1e2
       do_init_module+0x9d/0x285
       load_module+0x20db/0x38e3
       SYSC_finit_module+0xa8/0xbc
       SyS_finit_module+0x9/0xb
       do_syscall_64+0x77/0x271
       entry_SYSCALL64_slow_path+0x25/0x25
      Reported-by: NMeelis Roos <mroos@linux.ee>
      Signed-off-by: NBart Van Assche <bart.vanassche@wdc.com>
      Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
      Reviewed-by: NLaurence Oberman <loberman@redhat.com>
      Acked-by: NHimanshu Madhani <himanshu.madhani@cavium.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      c02189e1
  4. 04 1月, 2018 4 次提交
  5. 12 12月, 2017 1 次提交
  6. 08 12月, 2017 2 次提交
  7. 17 10月, 2017 5 次提交
  8. 31 8月, 2017 1 次提交
  9. 25 8月, 2017 6 次提交
    • S
    • Q
      scsi: qla2xxx: Add ability to autodetect SFP type · e4e3a2ce
      Quinn Tran 提交于
      SFP can come in 2 formats: short range/SR and long range/LR.  For LR,
      user the can increase the number of Buffer to Buffer credits between end
      points via Cavium's command line tool.  By default, FW uses a lower BB
      Credit value optimized for SR.  This patch will read the SFP for each
      link up event and during chip reset sequence. If the SFP type and
      setting are mismatch, then the chip is reset 1 time to use the
      appropriate setting.
      Signed-off-by: NQuinn Tran <quinn.tran@cavium.com>
      Signed-off-by: NHimanshu Madhani <himanshu.madhani@cavium.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      e4e3a2ce
    • Q
      scsi: qla2xxx: Remove extra register read · dc62c3be
      Quinn Tran 提交于
      Remove extra register read for each interrupt for performance
      improvement.
      Signed-off-by: NQuinn Tran <quinn.tran@cavium.com>
      Signed-off-by: NHimanshu Madhani <himanshu.madhani@cavium.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      dc62c3be
    • D
      scsi: qla2xxx: Fix system panic due to pointer access problem · a1730595
      Duane Grigsby 提交于
      [ 1013.772926] BUG: unable to handle kernel paging request at 0000000300000020
      [ 1013.772950] IP: qla24xx_els_ct_entry.isra.17+0x78/0x2a0 [qla2xxx]
      [ 1013.772951] PGD 0
      [ 1013.772952] P4D 0
      [ 1013.772952]
      [ 1013.772953] Oops: 0000 [#1] SMP
      [ 1013.772955] Modules linked in: qla2xxx(+) scsi_transport_fc nvme_fc
      nvme_fabrics nvme_core netconsole configfs af_packet iscsi_ibft
      iscsi_boot_sysfs xfs intel_rapl sb_edac libcrc32c x86_pkg_temp_thermal
      intel_powerclamp coretemp mgag200 kvm_intel ttm kvm drm_kms_helper
      ipmi_ssif irqbypass tg3 drm fb_sys_fops crct10dif_pclmul syscopyarea
      crc32_pclmul ghash_clmulni_intel ptp pcbc sysfillrect pps_core
      aesni_intel joydev aes_x86_64 sysimgblt crypto_simd iTCO_wdt libphy
      iTCO_vendor_support i2c_algo_bit glue_helper ipmi_si lpc_ich hpwdt
      ioatdma cryptd ipmi_devintf pcspkr mfd_core pcc_cpufreq ipmi_msghandler
      hpilo thermal dca button shpchp btrfs xor raid6_pq hid_generic usbhid
      sr_mod cdrom sd_mod ata_generic crc32c_intel serio_raw ata_piix ahci
      libahci uhci_hcd ehci_pci ehci_hcd libata usbcore hpsa scsi_transport_sas
      [ 1013.772994]  sg scsi_mod autofs4
      [ 1013.772998] CPU: 0 PID: 374 Comm: systemd-journal Not tainted 4.13.0-rc1-2-default #2
      [ 1013.772999] Hardware name: HP ProLiant DL380p Gen8, BIOS P70 07/15/2012
      [ 1013.773000] task: ffff88082c188380 task.stack: ffffc90004d7c000
      [ 1013.773011] RIP: 0010:qla24xx_els_ct_entry.isra.17+0x78/0x2a0 [qla2xxx]
      [ 1013.773012] RSP: 0000:ffff88042f603d90 EFLAGS: 00010082
      [ 1013.773013] RAX: ffff88039f723ac8 RBX: ffff88039f723ac8 RCX: ffff8803a2e18010
      [ 1013.773014] RDX: ffff88039f723ac0 RSI: ffff88042f603dc4 RDI: ffff88041b6787c0
      [ 1013.773015] RBP: ffff88042f603e00 R08: 0000000000000002 R09: 000000000000000d
      [ 1013.773016] R10: 0000000000000002 R11: 0000000000000000 R12: ffff8803a2e80080
      [ 1013.773016] R13: ffff88041b6787c0 R14: 0000000300000000 R15: 0000000000000102
      [ 1013.773018] FS:  00007fa2e0a73880(0000) GS:ffff88042f600000(0000) knlGS:0000000000000000
      [ 1013.773019] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [ 1013.773020] CR2: 0000000300000020 CR3: 000000042cd7e000 CR4: 00000000000406f0
      [ 1013.773021] Call Trace:
      [ 1013.773022]  <IRQ>
      [ 1013.773026]  ? consume_skb+0x34/0xa0
      [ 1013.773040]  qla24xx_process_response_queue+0x319/0x700 [qla2xxx]
      [ 1013.773050]  qla24xx_msix_rsp_q+0x7b/0xd0 [qla2xxx]
      [ 1013.773054]  __handle_irq_event_percpu+0x3c/0x1b0
      [ 1013.773056]  handle_irq_event_percpu+0x23/0x60
      [ 1013.773057]  handle_irq_event+0x42/0x70
      [ 1013.773059]  handle_edge_irq+0x8f/0x190
      [ 1013.773062]  handle_irq+0x1d/0x30
      [ 1013.773065]  do_IRQ+0x48/0xd0
      [ 1013.773067]  common_interrupt+0x93/0x93
      [ 1013.773068] RIP: 0033:0xed622c6e42
      [ 1013.773069] RSP: 002b:00007ffee8b5c820 EFLAGS: 00000202 ORIG_RAX: ffffffffffffff17
      [ 1013.773071] RAX: 000000ed6316a3f0 RBX: 000000ed6316a840 RCX: 00000000000c4e33
      [ 1013.773071] RDX: 000000ed6316a878 RSI: 000000ed6316a840 RDI: 000000ed631682d0
      [ 1013.773072] RBP: 0000000000000001 R08: 0000000000000001 R09: 000000ed63179b70
      [ 1013.773073] R10: 000000000005f6f8 R11: 0000000000000202 R12: 0000000000000001
      [ 1013.773074] R13: 00007ffee8b5c85c R14: 000000ed6316a840 R15: 00007ffee8b5c850
      [ 1013.773074]  </IRQ>
      [ 1013.773076] Code: a9 8a 9a e0 48 8d 75 c4 48 89 da 4c 89 e1 4c 89 ef
      e8 54 6e fb ff 48 85 c0 48 89 c3 0f 84 0e 02 00 00 44 0f b7 48 36 4c 8b
      70 58 <4d> 8b 7e 20 41 8d 41 fd 66 83 f8 0c 77 6c 0f b7 c0 ff 24 c5 88
      [ 1013.773102] RIP: qla24xx_els_ct_entry.isra.17+0x78/0x2a0 [qla2xxx] RSP: ffff88042f603d90
      [ 1013.773102] CR2: 0000000300000020
      [ 1013.773129] ---[ end trace 532363559924f426 ]---
      [ 1013.773131] Kernel panic - not syncing: Fatal exception in interrupt
      [ 1013.777719] Kernel Offset: disabled
      [ 1013.827528] ---[ end Kernel panic - not syncing: Fatal exception in interrupt
      Signed-off-by: NDuane Grigsby <Duane.Grigsby@cavium.com>
      Signed-off-by: NQuinn Tran <quinn.tran@cavium.com>
      Signed-off-by: NHimanshu Madhani <himanshu.madhani@cavium.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      a1730595
    • M
      scsi: qla2xxx: Fix target multiqueue configuration · b7edfa23
      Michael Hernandez 提交于
      Following error will be logged in to message file while trying to
      configure target with multiqueue.
      
      "Cmd 0x1f aborted with timeout since ISP Abort is pending"
      "qla25xx_init_queues Rsp que: 1 init failed."
      
      Fixes: 82de802a ("scsi: qla2xxx: Preparation for Target MQ.")
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NQuinn Tran <quinn.tran@cavium.com>
      Signed-off-by: NMichael Hernandez <michael.hernandez@cavium.com>
      Signed-off-by: NHimanshu Madhani <himanshu.madhani@cavium.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      b7edfa23
    • C
      scsi: qla2xxx: fix spelling mistake of variable sfp_additonal_info · b4a028a5
      Colin Ian King 提交于
      Trivial fix to variable name, sfp_additonal_info should be
      sfp_additional_info (add in missing i).
      Signed-off-by: NColin Ian King <colin.king@canonical.com>
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      b4a028a5
  10. 08 8月, 2017 3 次提交
  11. 04 7月, 2017 1 次提交
  12. 02 7月, 2017 1 次提交
  13. 28 6月, 2017 7 次提交
  14. 13 6月, 2017 2 次提交
  15. 25 5月, 2017 1 次提交