1. 03 3月, 2012 5 次提交
    • C
      NFS: Clean up debugging in decode_pathname() · 02a2976c
      Chuck Lever 提交于
      I noticed recently that decode_attr_fs_locations() is not generating
      very pretty debugging output.  The pathname components each appear on
      a separate line of output, though that does not appear to be the
      intended display behavior.  The preferred way to generate continued
      lines of output on the console is to use pr_cont().
      
      Note that incoming pathname4 components contain a string that is not
      necessarily NUL-terminated.  I did actually see some trailing garbage
      on the console.  In addition to correcting the line continuation
      problem, add a string precision format specifier to ensure that each
      component string is displayed properly, and that vsnprintf() does
      not Oops.
      
      Someone pointed out that allowing incoming network data to possibly
      generate a console line of unbounded length may not be such a good
      idea.  Since this output will rarely be enabled, and there is a hard
      upper bound (NFS4_PATHNAME_MAXCOMPONENTS) in our implementation, this
      is probably not a major concern.
      
      It might be useful to additionally sanity-check the length of each
      incoming component, however.  RFC 3530bis15 does not suggest a maximum
      number of UTF-8 characters per component for either the pathname4 or
      component4 types.  However, we could invent one that is appropriate
      for our implementation.
      
      Another possibility is to scrap all of this and print these pathnames
      in upper layers after a reasonable amount of sanity checking in the
      XDR layer.  This would give us an opportunity to allocate a full
      buffer so that the whole pathname would be output via a single
      dprintk.
      
      Introduced by commit 7aaa0b3b: "NFSv4: convert fs-locations-components
      to conform to RFC3530," (June 9, 2006).
      Signed-off-by: NChuck Lever <chuck.lever@oracle.com>
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      02a2976c
    • C
      NFS: Make nfs_cache_array.size a signed integer · 88b8e133
      Chuck Lever 提交于
      Eliminate a number of implicit type casts in comparisons, and these
      compiler warnings:
      
      fs/nfs/dir.c: In function ‘nfs_readdir_clear_array’:
      fs/nfs/dir.c:264:16: warning: comparison between signed and unsigned
      		integer expressions [-Wsign-compare]
      fs/nfs/dir.c: In function ‘nfs_readdir_search_for_cookie’:
      fs/nfs/dir.c:352:16: warning: comparison between signed and unsigned
      		integer expressions [-Wsign-compare]
      fs/nfs/dir.c: In function ‘nfs_do_filldir’:
      fs/nfs/dir.c:769:38: warning: comparison between signed and unsigned
      		integer expressions [-Wsign-compare]
      fs/nfs/dir.c:780:9: warning: comparison between signed and unsigned
      		integer expressions [-Wsign-compare]
      Signed-off-by: NChuck Lever <chuck.lever@oracle.com>
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      88b8e133
    • T
    • T
      NFS: Ensure we display the minor version correctly in /proc/mounts etc. · 7bbceb6f
      Trond Myklebust 提交于
      The 'minorversion' mount option is now deprecated, so we need to display
      the minor version number in the 'vers=' format.
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      7bbceb6f
    • T
      NFS: Extend the -overs= mount option to allow 4.x minorversions · 0d71b058
      Trond Myklebust 提交于
      Allow the user to mount an NFSv4.0 or NFSv4.1 partition using a
      standard syntax of '-overs=4.0', or '-overs=4.1' rather than the
      more cumbersome '-overs=4,minorversion=1'.
      
      See also the earlier patch by Dros Adamson, which added the
      Linux-specific syntax '-ov4.0', '-ov4.1'.
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      0d71b058
  2. 02 3月, 2012 6 次提交
  3. 28 2月, 2012 1 次提交
  4. 27 2月, 2012 1 次提交
  5. 19 2月, 2012 2 次提交
  6. 18 2月, 2012 2 次提交
  7. 17 2月, 2012 1 次提交
  8. 16 2月, 2012 1 次提交
  9. 15 2月, 2012 10 次提交
  10. 07 2月, 2012 11 次提交