- 15 4月, 2017 3 次提交
-
-
由 Martin Kepplinger 提交于
ar1021_i2c also supports the ar1020 device I'm using. This is tested. They also share the same datasheet: http://ww1.microchip.com/downloads/en/DeviceDoc/40001393C.pdf So let users see that they have a compatible in front of them by adding AR1020 to the driver's description. Signed-off-by: NMartin Kepplinger <martin.kepplinger@ginzinger.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
由 Dmitry Torokhov 提交于
We should not be forcing edge triggered interrupt, but rather let platform decide the kind of trigger it needs to use. Also, the driver is not quite safe with regard to edge-triggered interrupts as it does not try to kick the controller after requesting/enabling IRQ. Reviewed-By: NChristian Gmeiner <christian.gmeiner@gmail.com> Tested-by: NMartin Kepplinger <martin.kepplinger@ginzinger.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
由 Dmitry Torokhov 提交于
The name field in structure i2c_device_id is 20 characters, and we expect it to be NULL-terminated, however we are trying to stuff it with 21 bytes and thus NULL-terminator is lost. This causes issues when one creates device with name "MICROCHIP_AR1021_I2C" as i2c core cuts off the last "C", and automatic module loading by alias does not work as result. The -I2C suffix in the device name is superfluous, we know what bus we are dealing with, so let's drop it. Also, no other driver uses capitals, and the manufacturer name is normally not included, except in very rare cases of incompatible name collisions. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116211 Fixes: dd4cae8b ("Input: Add Microchip AR1021 i2c touchscreen") Reviewed-By: NChristian Gmeiner <christian.gmeiner@gmail.com> Tested-by: NMartin Kepplinger <martin.kepplinger@ginzinger.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
- 12 4月, 2017 1 次提交
-
-
由 Martin Kepplinger 提交于
Use the common kernel coding style and corrently align parameters with open parenthesis. Signed-off-by: NMartin Kepplinger <martin.kepplinger@ginzinger.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
- 19 1月, 2017 1 次提交
-
-
由 Guenter Roeck 提交于
There is no call to i2c_get_clientdata() or dev_get_drvdata(). Drop the unnecessary call to i2c_set_clientdata(). Signed-off-by: NGuenter Roeck <linux@roeck-us.net> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
- 18 7月, 2015 1 次提交
-
-
由 Krzysztof Kozlowski 提交于
i2c_driver does not need to set an owner because i2c_register_driver() will set it. Signed-off-by: NKrzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
- 20 3月, 2015 1 次提交
-
-
由 Fabian Frederick 提交于
of_device_id is always used as const argument (See driver.of_match_table and open firmware functions). Signed-off-by: NFabian Frederick <fabf@skynet.be> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
- 10 10月, 2014 1 次提交
-
-
由 Christian Gmeiner 提交于
This patch adds support for the ar1021 i2c based touchscreen. The driver is quite simple and only supports the Touch Reporting Protocol. This is the final version for an RFC patch send a while ago. http://www.spinics.net/lists/linux-input/msg29419.htmlSigned-off-by: NChristian Gmeiner <christian.gmeiner@gmail.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-