1. 05 1月, 2011 4 次提交
  2. 09 9月, 2010 1 次提交
  3. 17 5月, 2010 4 次提交
  4. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  5. 08 3月, 2010 1 次提交
  6. 27 2月, 2010 2 次提交
  7. 09 2月, 2010 2 次提交
  8. 04 1月, 2010 1 次提交
  9. 19 12月, 2009 1 次提交
  10. 23 9月, 2009 2 次提交
  11. 11 9月, 2009 1 次提交
  12. 22 6月, 2009 5 次提交
  13. 12 6月, 2009 2 次提交
  14. 14 4月, 2009 1 次提交
  15. 26 3月, 2009 8 次提交
    • J
      [S390] qdio: merge inbound and outbound handler functions · 9c8a08d7
      Jan Glauber 提交于
      The inbound and outbound handlers are nearly identical if the outbound
      handler uses first_to_check as end index instead of last_move. Since both
      values are identical at that point the handlers can be merged.
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      9c8a08d7
    • J
      [S390] qdio: report SIGA errors directly · d303b6fd
      Jan Glauber 提交于
      Errors from SIGA instructions are stored in the per queue qdio_error
      and reported back when the queue handler is called. That opens a race
      when multiple error conditions occur simultanously.
      
      Report SIGA errors immediately in the return value of do_QDIO so the
      upper layer can react and SIGA errors no longer interfere with other
      errors.
      
      Move the SIGA error handling in qeth from the outbound handler to
      qeth_flush_buffers.
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      d303b6fd
    • J
      [S390] qdio: seperate last move index and polling index · e85dea0e
      Jan Glauber 提交于
      The index value that indicated that the input queue moved was also used to
      store the index of the first acknowledged buffer. For non-qebsm only the
      newest buffer is acknowledged which may be different from the last move index
      so two seperate values are needed to track the input queue.
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      e85dea0e
    • J
      [S390] qdio: move ACK to newest buffer for devices without QEBSM · 3fdf1e18
      Jan Glauber 提交于
      The ACKnowledgement state should be set on the newest SBAL so an
      adapter interrupt surpression check needs to scan fewer SBALs.
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      3fdf1e18
    • J
      [S390] qdio: call qdio_free also if qdio_shutdown fails · 700e982f
      Jan Glauber 提交于
      qdio_cleanup is a wrapper function that should call qdio_shutdown and
      qdio_free. qdio_free was not called if an error occured in qdio_shutdown
      resulting in a missing free of allocated resources.
      
      Call qdio_free regardless of the return value of qdio_shutdown.
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      700e982f
    • J
      [S390] qdio: proper kill of qdio tasklets · c38f9608
      Jan Glauber 提交于
      The queue tasklets were stopped with tasklet_disable. Although tasklet_disable
      prevents the tasklet from beeing executed it is still possible that a tasklet
      is scheduled on a CPU at that point. A following qdio_establish calls
      tasklet_init which clears the tasklet count and the tasklet state leading to
      the following Oops:
      
          <2>kernel BUG at kernel/softirq.c:392!
          <4>illegal operation: 0001 [#1] SMP
          <4>Modules linked in: iptable_filter ip_tables x_tables dm_round_robin dm_multipath scsi_dh sg sd_mod crc_t10dif nfs lockd nfs
      _acl sunrpc fuse loop dm_mod qeth_l3 ipv6 zfcp qeth scsi_transport_fc qdio scsi_tgt scsi_mod chsc_sch ccwgroup dasd_eckd_mod dasdm
      od ext3 mbcache jbd
          <4>Supported: Yes
          <4>CPU: 0 Not tainted 2.6.27.13-1.1.mz13-default #1
          <4>Process blast.LzS_64 (pid: 16445, task: 000000006cc02538, ksp: 000000006cb67998)
          <4>Krnl PSW : 0704c00180000000 00000000001399f4 (tasklet_action+0xc8/0x1d4)
          <4>           R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 EA:3
          <4>Krnl GPRS: ffffffff00000030 0000000000000002 0000000000000002 fffffffffffffffe
          <4>           000000000013aabe 00000000003b6a18 fffffffffffffffd 0000000000000000
          <4>           00000000006705a8 000000007d0914a8 000000007d0914b0 000000007fecfd30
          <4>           0000000000000000 00000000003b63e8 000000007fecfd90 000000007fecfd30
          <4>Krnl Code: 00000000001399e8: b9200021            cgr     %r2,%r1
          <4>           00000000001399ec: a7740004            brc     7,1399f4
          <4>           00000000001399f0: a7f40001            brc     15,1399f2
          <4>          >00000000001399f4: c0100027e8ee        larl    %r1,636bd0
          <4>           00000000001399fa: bf1f1008            icm     %r1,15,8(%r1)
          <4>           00000000001399fe: a7840019            brc     8,139a30
          <4>           0000000000139a02: c0300027e8ef        larl    %r3,636be0
          <4>           0000000000139a08: e3c030000004        lg      %r12,0(%r3)
          <4>Call Trace:
          <4>([<0000000000139c12>] tasklet_hi_action+0x112/0x1d4)
          <4> [<000000000013aabe>] __do_softirq+0xde/0x1c4
          <4> [<000000000010fa2e>] do_softirq+0x96/0xb0
          <4> [<000000000013a8d8>] irq_exit+0x70/0xcc
          <4> [<000000000010d1d8>] do_extint+0xf0/0x110
          <4> [<0000000000113b10>] ext_no_vtime+0x16/0x1a
          <4> [<000003e0000a3662>] ext3_dirty_inode+0xe6/0xe8 [ext3]
          <4>([<00000000001f6cf2>] __mark_inode_dirty+0x52/0x1d4)
          <4> [<000003e0000a44f0>] ext3_ordered_write_end+0x138/0x190 [ext3]
          <4> [<000000000018d5ec>] generic_perform_write+0x174/0x230
          <4> [<0000000000190144>] generic_file_buffered_write+0xb4/0x194
          <4> [<0000000000190864>] __generic_file_aio_write_nolock+0x418/0x454
          <4> [<0000000000190ee2>] generic_file_aio_write+0x76/0xe4
          <4> [<000003e0000a05c2>] ext3_file_write+0x3e/0xc8 [ext3]
          <4> [<00000000001cc2fe>] do_sync_write+0xd6/0x120
          <4> [<00000000001ccfc8>] vfs_write+0xac/0x184
          <4> [<00000000001cd218>] SyS_write+0x68/0xe0
          <4> [<0000000000113402>] sysc_noemu+0x10/0x16
          <4> [<0000020000043188>] 0x20000043188
          <4>Last Breaking-Event-Address:
          <4> [<00000000001399f0>] tasklet_action+0xc4/0x1d4
          <6>qdio: 0.0.c61b ZFCP on SC f67 using AI:1 QEBSM:0 PCI:1 TDD:1 SIGA: W AOP
          <4> <0>Kernel panic - not syncing: Fatal exception in interrupt
      
      Use tasklet_kill instead of tasklet_disbale. Since tasklet_schedule must not be
      called after tasklet_kill use the QDIO_IRQ_STATE_STOPPED to inidicate that a
      queue is going down and prevent further tasklet schedules in that case.
      
      Remove superflous tasklet_schedule from input queue setup, at that time
      the queues are not ready so the schedule results in a NOP.
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      c38f9608
    • J
      [S390] qdio: Dont call qdio_shutdown in case qdio_activate fails · e4c14e20
      Jan Glauber 提交于
      Remove the call to qdio_shutdown from qdio_activate since the upper-layer
      drivers are responsible to call qdio_shutdown when qdio_activate returns
      with an error.
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      e4c14e20
    • J
      [S390] qdio: add missing tiq_list locking · b4547402
      Jan Glauber 提交于
      Add a mutex to protect the tiq_list. Although reading the list is done
      using RCU adding and removing elements from the list must still
      happen locked since multiple qdio devices may change the list in parallel
      otherwise.
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      b4547402
  16. 09 1月, 2009 1 次提交
  17. 25 12月, 2008 3 次提交
    • J
      [S390] qdio: fix error reporting for hipersockets · 7a0b4cbc
      Jan Glauber 提交于
      Hipersocket connections can encounter temporary busy conditions.
      In case of the busy bit set we retry the SIGA operation immediatelly.
      If the busy condition still persists after 100 ms we fail and report
      the error to the upper layer. The second stage retry logic is removed.
      In case of ongoing busy conditions the upper layer needs to reset the
      connection.
      
      The reporting of a SIGA error is now done synchronously to allow the
      network driver to requeue the buffers. Also no error trace is created
      for the temporary SIGA errors so the error message view is not flooded.
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      7a0b4cbc
    • J
      [S390] qdio: improve inbound buffer acknowledgement · 50f769df
      Jan Glauber 提交于
      - Use automatic acknowledgement of incoming buffers in QEBSM mode
      - Move ACK for non-QEBSM mode always to the newest buffer to prevent
        a race with qdio_stop_polling
      - Remove the polling spinlock, the upper layer drivers return new buffers
        in the same code path and could not run in parallel
      - Don't flood the error log in case of no-target-buffer-empty
      - In handle_inbound we check if we would overwrite an ACK'ed buffer, if so
        advance the pointer to the oldest ACK'ed buffer so we don't overwrite an
        empty buffer in qdio_stop_polling
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      50f769df
    • J
      [S390] qdio: rework debug feature logging · 22f99347
      Jan Glauber 提交于
      - make qdio_trace a per device view
      - remove s390dbf exceptions
      - remove CONFIG_QDIO_DEBUG, not needed anymore if we check for the level
        before calling sprintf
      - use snprintf for dbf entries
      - add start markers to see if the dbf view wrapped
      - add a global error view for all queues
      Signed-off-by: NJan Glauber <jang@linux.vnet.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      22f99347