1. 30 12月, 2008 2 次提交
  2. 23 12月, 2008 1 次提交
  3. 22 12月, 2008 1 次提交
    • D
      IB/iser: Avoid recv buffer exhaustion caused by unexpected PDUs · bba7ebba
      David Disseldorp 提交于
      iSCSI/iSER targets may send PDUs without a prior request from the
      initiator.  RFC 5046 refers to these PDUs as "unexpected".  NOP-In PDUs
      with itt=RESERVED and Asynchronous Message PDUs occupy this category.
      
      The amount of active "unexpected" PDU's an iSER target may have at any
      time is governed by the MaxOutstandingUnexpectedPDUs key, which is not
      yet supported.
      
      Currently when an iSER target sends an "unexpected" PDU, the
      initiators recv buffer consumed by the PDU is not replaced.  If over
      initial_post_recv_bufs_num "unexpected" PDUs are received then the
      receive queue will run out of receive work requests entirely.
      
      This patch ensures recv buffers consumed by "unexpected" PDUs are
      replaced in the next iser_post_receive_control() call.
      Signed-off-by: NDavid Disseldorp <ddiss@sgi.com>
      Signed-off-by: NKen Sandars <ksandars@sgi.com>
      Acked-by: NOr Gerlitz <ogerlitz@voltaire.com>
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      bba7ebba
  4. 13 11月, 2008 3 次提交
  5. 31 10月, 2008 1 次提交
  6. 30 10月, 2008 1 次提交
  7. 29 10月, 2008 3 次提交
  8. 23 10月, 2008 2 次提交
  9. 14 10月, 2008 1 次提交
  10. 13 10月, 2008 2 次提交
  11. 11 10月, 2008 1 次提交
  12. 01 10月, 2008 1 次提交
    • R
      IPoIB: Use netif_tx_lock() and get rid of private tx_lock, LLTX · 943c246e
      Roland Dreier 提交于
      Currently, IPoIB is an LLTX driver that uses its own IRQ-disabling
      tx_lock.  Not only do we want to get rid of LLTX, this actually causes
      problems because of the skb_orphan() done with this tx_lock held: some
      skb destructors expect to be run with interrupts enabled.
      
      The simplest fix for this is to get rid of the driver-private tx_lock
      and stop using LLTX.  We kill off priv->tx_lock and use
      netif_tx_lock[_bh]() instead; the patch to do this is a tiny bit
      tricky because we need to update places that take priv->lock inside
      the tx_lock to disable IRQs, rather than relying on tx_lock having
      already disabled IRQs.
      
      Also, there are a couple of places where we need to disable BHs to
      make sure we have a consistent context to call netif_tx_lock() (since
      we no longer can use _irqsave() variants), and we also have to change
      ipoib_send_comp_handler() to call drain_tx_cq() through a timer rather
      than directly, because ipoib_send_comp_handler() runs in interrupt
      context and drain_tx_cq() must run in BH context so it can call
      netif_tx_lock().
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      943c246e
  13. 26 9月, 2008 2 次提交
  14. 17 9月, 2008 1 次提交
    • Y
      IPoIB: Fix deadlock on RTNL between bcast join comp and ipoib_stop() · e8224e4b
      Yossi Etigin 提交于
      Taking rtnl_lock in ipoib_mcast_join_complete() causes a deadlock with
      ipoib_stop().  We avoid it by scheduling the piece of code that takes
      the lock on ipoib_workqueue instead of executing it directly.  This
      works because we only flush the ipoib_workqueue with the RTNL not held.
      
      The deadlock happens because ipoib_stop() calls ipoib_ib_dev_down()
      which calls ipoib_mcast_dev_flush(), which calls ipoib_mcast_free(),
      which calls ipoib_mcast_leave(). The latter calls
      ib_sa_free_multicast(), and this waits until the multicast completion
      handler finishes.  This handler is ipoib_mcast_join_complete(), which
      waits for the rtnl_lock(), which was already taken by ipoib_stop().
      
      This bug was introduced in commit a77a57a1 ("IPoIB: Fix deadlock on
      RTNL in ipoib_stop()").
      Signed-off-by: NYossi Etigin <yosefe@voltaire.com>
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      e8224e4b
  15. 24 8月, 2008 1 次提交
  16. 20 8月, 2008 1 次提交
    • R
      IPoIB: Fix deadlock on RTNL in ipoib_stop() · a77a57a1
      Roland Dreier 提交于
      Commit c8c2afe3 ("IPoIB: Use rtnl lock/unlock when changing device
      flags") added a call to rtnl_lock() in ipoib_mcast_join_task(), which
      is run from the ipoib_workqueue.  However, ipoib_stop() (which is run
      inside rtnl_lock()) flushes this workqueue, which leads to a deadlock
      if the join task is pending.
      
      Fix this by simply not flushing the workqueue from ipoib_stop().  It
      turns out that we really don't care about workqueue tasks running
      during or after ipoib_stop(), as long as we make sure to flush the
      workqueue before unregistering a netdev.
      
      This fixes <https://bugs.openfabrics.org/show_bug.cgi?id=1114>.
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      a77a57a1
  17. 09 8月, 2008 1 次提交
  18. 30 7月, 2008 1 次提交
  19. 25 7月, 2008 2 次提交
  20. 23 7月, 2008 2 次提交
  21. 15 7月, 2008 10 次提交