提交 f7c3f96a 编写于 作者: J Julia Lawall 提交者: David S. Miller

drivers/net/ethernet/ibm/emac/mal.c: use WARN

Use WARN rather than printk followed by WARN_ON(1), for conciseness.

A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression list es;
@@

-printk(
+WARN(1,
  es);
-WARN_ON(1);
// </smpl>
Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 bb263e18
...@@ -738,13 +738,11 @@ static int __devexit mal_remove(struct platform_device *ofdev) ...@@ -738,13 +738,11 @@ static int __devexit mal_remove(struct platform_device *ofdev)
/* Synchronize with scheduled polling */ /* Synchronize with scheduled polling */
napi_disable(&mal->napi); napi_disable(&mal->napi);
if (!list_empty(&mal->list)) { if (!list_empty(&mal->list))
/* This is *very* bad */ /* This is *very* bad */
printk(KERN_EMERG WARN(1, KERN_EMERG
"mal%d: commac list is not empty on remove!\n", "mal%d: commac list is not empty on remove!\n",
mal->index); mal->index);
WARN_ON(1);
}
dev_set_drvdata(&ofdev->dev, NULL); dev_set_drvdata(&ofdev->dev, NULL);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册