提交 e8bc3c99 编写于 作者: D Dan Carpenter 提交者: Mark Brown

ASoC: Intel: Skylake: pointer math issue

"data" is a u32 pointer so this copies the information to wrong place
entirely.

Fixes: 140adfba ('ASoC: Intel: Skylake: Add tlv byte kcontrols')
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Acked-by: NVinod Koul <vinod.koul@intel.com>
Tested-by: NDharageswari R <dharageswari.r@intel.com>
Signed-off-by: NMark Brown <broonie@kernel.org>
上级 db4e5613
......@@ -919,9 +919,9 @@ static int skl_tplg_tlv_control_get(struct snd_kcontrol *kcontrol,
if (bc->params) {
if (copy_to_user(data, &bc->param_id, sizeof(u32)))
return -EFAULT;
if (copy_to_user(data + sizeof(u32), &size, sizeof(u32)))
if (copy_to_user(data + 1, &size, sizeof(u32)))
return -EFAULT;
if (copy_to_user(data + 2 * sizeof(u32), bc->params, size))
if (copy_to_user(data + 2, bc->params, size))
return -EFAULT;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册