提交 e49452c6 编写于 作者: T Tejun Heo 提交者: Linus Torvalds

sysfs: make sysfs_lookup() return ERR_PTR(-ENOENT) on failed lookup

sysfs tries to keep dcache a strict subset of sysfs_dirent tree by
shooting down dentries when a node is removed, that is, no negative
dentry for sysfs.  However, the lookup function returned NULL and thus
created negative dentries when the target node didn't exist.

Make sysfs_lookup() return ERR_PTR(-ENOENT) on lookup failure.  This
fixes the NULL dereference bug in sysfs_get_dentry() discovered by
bluetooth rfcomm device moving around.
Signed-off-by: NTejun Heo <htejun@gmail.com>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
上级 cbd9c883
...@@ -678,8 +678,10 @@ static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry, ...@@ -678,8 +678,10 @@ static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry,
sd = sysfs_find_dirent(parent_sd, dentry->d_name.name); sd = sysfs_find_dirent(parent_sd, dentry->d_name.name);
/* no such entry */ /* no such entry */
if (!sd) if (!sd) {
ret = ERR_PTR(-ENOENT);
goto out_unlock; goto out_unlock;
}
/* attach dentry and inode */ /* attach dentry and inode */
inode = sysfs_get_inode(sd); inode = sysfs_get_inode(sd);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册