提交 e0de78df 编写于 作者: A Andi Kleen 提交者: Linus Torvalds

mm, hwpoison: add comment describing when to add new cases

Here's another comment fix for hwpoison.

It describes the "guiding principle" on when to add new
memory error recovery code.
Signed-off-by: NAndi Kleen <ak@linux.intel.com>
Acked-by: NNaoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
上级 1ed58b60
...@@ -20,6 +20,14 @@ ...@@ -20,6 +20,14 @@
* this code has to be extremely careful. Generally it tries to use * this code has to be extremely careful. Generally it tries to use
* normal locking rules, as in get the standard locks, even if that means * normal locking rules, as in get the standard locks, even if that means
* the error handling takes potentially a long time. * the error handling takes potentially a long time.
*
* It can be very tempting to add handling for obscure cases here.
* In general any code for handling new cases should only be added iff:
* - You know how to test it.
* - You have a test that can be added to mce-test
* https://git.kernel.org/cgit/utils/cpu/mce/mce-test.git/
* - The case actually shows up as a frequent (top 10) page state in
* tools/vm/page-types when running a real workload.
* *
* There are several operations here with exponential complexity because * There are several operations here with exponential complexity because
* of unsuitable VM data structures. For example the operation to map back * of unsuitable VM data structures. For example the operation to map back
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册