提交 c2d474d6 编写于 作者: M Matt Fleming

sh: Remove any reference to recursive functions from comments

Originally, dwarf_unwind_stack() was a recursive function and it seems
that some of the old comments were never updated.
Signed-off-by: NMatt Fleming <matt@console-pimps.org>
上级 ed4fe7f4
...@@ -540,7 +540,8 @@ void dwarf_free_frame(struct dwarf_frame *frame) ...@@ -540,7 +540,8 @@ void dwarf_free_frame(struct dwarf_frame *frame)
} }
/** /**
* dwarf_unwind_stack - recursively unwind the stack * dwarf_unwind_stack - unwind the stack
*
* @pc: address of the function to unwind * @pc: address of the function to unwind
* @prev: struct dwarf_frame of the previous stackframe on the callstack * @prev: struct dwarf_frame of the previous stackframe on the callstack
* *
...@@ -558,9 +559,9 @@ struct dwarf_frame * dwarf_unwind_stack(unsigned long pc, ...@@ -558,9 +559,9 @@ struct dwarf_frame * dwarf_unwind_stack(unsigned long pc,
unsigned long addr; unsigned long addr;
/* /*
* If this is the first invocation of this recursive function we * If we're starting at the top of the stack we need get the
* need get the contents of a physical register to get the CFA * contents of a physical register to get the CFA in order to
* in order to begin the virtual unwinding of the stack. * begin the virtual unwinding of the stack.
* *
* NOTE: the return address is guaranteed to be setup by the * NOTE: the return address is guaranteed to be setup by the
* time this function makes its first function call. * time this function makes its first function call.
...@@ -582,9 +583,8 @@ struct dwarf_frame * dwarf_unwind_stack(unsigned long pc, ...@@ -582,9 +583,8 @@ struct dwarf_frame * dwarf_unwind_stack(unsigned long pc,
fde = dwarf_lookup_fde(pc); fde = dwarf_lookup_fde(pc);
if (!fde) { if (!fde) {
/* /*
* This is our normal exit path - the one that stops the * This is our normal exit path. There are two reasons
* recursion. There's two reasons why we might exit * why we might exit here,
* here,
* *
* a) pc has no asscociated DWARF frame info and so * a) pc has no asscociated DWARF frame info and so
* we don't know how to unwind this frame. This is * we don't know how to unwind this frame. This is
...@@ -626,10 +626,10 @@ struct dwarf_frame * dwarf_unwind_stack(unsigned long pc, ...@@ -626,10 +626,10 @@ struct dwarf_frame * dwarf_unwind_stack(unsigned long pc,
} else { } else {
/* /*
* Again, this is the first invocation of this * Again, we're starting from the top of the
* recurisve function. We need to physically * stack. We need to physically read
* read the contents of a register in order to * the contents of a register in order to get
* get the Canonical Frame Address for this * the Canonical Frame Address for this
* function. * function.
*/ */
frame->cfa = dwarf_read_arch_reg(frame->cfa_register); frame->cfa = dwarf_read_arch_reg(frame->cfa_register);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册