提交 c102659d 编写于 作者: M Michael S. Tsirkin

virtio: simplify feature bit handling

Now that we use u64 for bits, we can simply & them together.
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: NDavid Hildenbrand <dahi@linux.vnet.ibm.com>
Reviewed-by: NCornelia Huck <cornelia.huck@de.ibm.com>


上级 cb3f6d9d
...@@ -160,6 +160,7 @@ static int virtio_dev_probe(struct device *_d) ...@@ -160,6 +160,7 @@ static int virtio_dev_probe(struct device *_d)
struct virtio_device *dev = dev_to_virtio(_d); struct virtio_device *dev = dev_to_virtio(_d);
struct virtio_driver *drv = drv_to_virtio(dev->dev.driver); struct virtio_driver *drv = drv_to_virtio(dev->dev.driver);
u64 device_features; u64 device_features;
u64 driver_features;
unsigned status; unsigned status;
/* We have a driver! */ /* We have a driver! */
...@@ -168,15 +169,16 @@ static int virtio_dev_probe(struct device *_d) ...@@ -168,15 +169,16 @@ static int virtio_dev_probe(struct device *_d)
/* Figure out what features the device supports. */ /* Figure out what features the device supports. */
device_features = dev->config->get_features(dev); device_features = dev->config->get_features(dev);
/* Features supported by both device and driver into dev->features. */ /* Figure out what features the driver supports. */
dev->features = 0; driver_features = 0;
for (i = 0; i < drv->feature_table_size; i++) { for (i = 0; i < drv->feature_table_size; i++) {
unsigned int f = drv->feature_table[i]; unsigned int f = drv->feature_table[i];
BUG_ON(f >= 64); BUG_ON(f >= 64);
if (device_features & (1ULL << f)) driver_features |= (1ULL << f);
__virtio_set_bit(dev, f);
} }
dev->features = driver_features & device_features;
/* Transport features always preserved to pass to finalize_features. */ /* Transport features always preserved to pass to finalize_features. */
for (i = VIRTIO_TRANSPORT_F_START; i < VIRTIO_TRANSPORT_F_END; i++) for (i = VIRTIO_TRANSPORT_F_START; i < VIRTIO_TRANSPORT_F_END; i++)
if (device_features & (1ULL << i)) if (device_features & (1ULL << i))
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册