提交 bf5091c8 编写于 作者: D David Sterba

btrfs: use kvzalloc for EXTENT_SAME temporary data

The dedupe range is 16 MiB, with 4 KiB pages and 8 byte pointers, the
arrays can be 32KiB large. To avoid allocation failures due to
fragmented memory, use the allocation with fallback to vmalloc.

The arrays are allocated and freed only inside btrfs_extent_same and
reused for all the ranges.
Reviewed-by: NNikolay Borisov <nborisov@suse.com>
Signed-off-by: NDavid Sterba <dsterba@suse.com>
上级 67b07bd4
......@@ -3144,12 +3144,13 @@ static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen,
* locking. We use an array for the page pointers. Size of the array is
* bounded by len, which is in turn bounded by BTRFS_MAX_DEDUPE_LEN.
*/
cmp.src_pages = kcalloc(num_pages, sizeof(struct page *), GFP_KERNEL);
cmp.dst_pages = kcalloc(num_pages, sizeof(struct page *), GFP_KERNEL);
cmp.src_pages = kvmalloc_array(num_pages, sizeof(struct page *),
GFP_KERNEL | __GFP_ZERO);
cmp.dst_pages = kvmalloc_array(num_pages, sizeof(struct page *),
GFP_KERNEL | __GFP_ZERO);
if (!cmp.src_pages || !cmp.dst_pages) {
kfree(cmp.src_pages);
kfree(cmp.dst_pages);
return -ENOMEM;
ret = -ENOMEM;
goto out_free;
}
for (i = 0; i < chunk_count; i++) {
......@@ -3172,8 +3173,9 @@ static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen,
else
btrfs_double_inode_unlock(src, dst);
kfree(cmp.src_pages);
kfree(cmp.dst_pages);
out_free:
kvfree(cmp.src_pages);
kvfree(cmp.dst_pages);
return ret;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册